a123ff5f82
In previous patches (I469b4b9dd9966be8477f3cefbd6284bdaf17ca17 and I4981ad558195895341c91fa37803713c8c0ab684) we assumed that unit tests were failing because they needed to be updated, but that's only half of the issue. The other half is that the DBMS plugin needs to be updated as well. This misunderstanding lead to a broken DBMS system that unit tests don't detect. This patch fixes the DBMS system and reverts changes to unit tests that those 2 patches introduced and are not necessary as well as removed the FIXME comments that are now fixed. Here's a brief description of why some of the issues were happening: - Locked database issues were happening when a unit test from TestBasePersistence run before a DBMS unit test. It was caused by the replacement of the main_context_manager when it had not been used. No longer a problem since we no longer replace it and we only replace its transaction factory when it has been used. - "ValueError: Backend named fake_backend already exists with a different configuration" error was caused because in TestDBPersistence the tearDown method only called the parent's tearDown after the cleanup of the DB, so if the cleanup of the DB failed then the global existing backend would remain and a following test would have trouble with it. Calling it first now to fix this. - Splitting the running of unit tests in tox.ini was necessary because methods in Cinder DB API were always using the context manager transaction factory from the first DBMS Test Case class. So some DBMS plugin methods would end up writing data to the previous database while others would write to the new database. Now that we replace the transaction factory everything is going to the same DB. Change-Id: I74ce945291697bc1fcc63a35d60ef71494fdaf19 |
||
|---|---|---|
| .. | ||
| bin | ||
| cmd | ||
| persistence | ||
| tests | ||
| __init__.py | ||
| _fake_packages.py | ||
| cinderlib.py | ||
| exception.py | ||
| objects.py | ||
| serialization.py | ||
| utils.py | ||