Use assertIsNone(...) instead of assertIs(None,...)
Following OpenStack Style Guidelines: [1] Unit test assertions tend to give better messages for more specific assertions. As a result, assertIsNone(...) is preferred over assertIs(None, ...) [1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises Change-Id: Ie4ee3be201f799d87c06378cd2c9a0a3c34c24df
This commit is contained in:
parent
772e16d6bb
commit
02e89274e2
|
@ -73,9 +73,9 @@ class TestInteractiveMode(base.TestBase):
|
|||
app.interactive_app_factory = mock.MagicMock(
|
||||
name='interactive_app_factory'
|
||||
)
|
||||
self.assertIs(None, app.interpreter)
|
||||
self.assertIsNone(app.interpreter)
|
||||
app.run([])
|
||||
self.assertIsNot(None, app.interpreter)
|
||||
self.assertIsNotNone(app.interpreter)
|
||||
cmdloop = app.interactive_app_factory.return_value.cmdloop
|
||||
cmdloop.assert_called_once_with()
|
||||
|
||||
|
|
Loading…
Reference in New Issue