From 1b723946ef7b5736048cf2d45f3eadb0e2255940 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Martin=20M=C3=A1gr?= <mmagr@redhat.com>
Date: Fri, 11 Apr 2025 10:47:21 +0200
Subject: [PATCH] Improve devstack plugin configuration

This patch:
  - adds possibility to set required configuration
    for prometheus collector
  - adds possibility to set required configuration
    for prometheus fetcher
  - adds possibility to use user created metrics.yml

Change-Id: I05cae8b8e7168883ccb593a51f5aa807bc16b22d
---
 devstack/plugin.sh | 11 +++++++++--
 devstack/settings  |  6 +++++-
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/devstack/plugin.sh b/devstack/plugin.sh
index e2f87f91..2491ab7b 100755
--- a/devstack/plugin.sh
+++ b/devstack/plugin.sh
@@ -110,7 +110,7 @@ function configure_cloudkitty {
     iniset $CLOUDKITTY_CONF oslo_policy policy_file 'policy.yaml'
 
     cp $CLOUDKITTY_DIR$CLOUDKITTY_CONF_DIR/api_paste.ini $CLOUDKITTY_CONF_DIR
-    cp $CLOUDKITTY_DIR$CLOUDKITTY_CONF_DIR/metrics.yml $CLOUDKITTY_CONF_DIR
+    cp $CLOUDKITTY_METRICS_CONF $CLOUDKITTY_CONF_DIR
     iniset_rpc_backend cloudkitty $CLOUDKITTY_CONF DEFAULT
 
     iniset $CLOUDKITTY_CONF DEFAULT notification_topics 'notifications'
@@ -135,6 +135,10 @@ function configure_cloudkitty {
     iniset $CLOUDKITTY_CONF "fetcher_$CLOUDKITTY_FETCHER" auth_section authinfos
     if [[ "$CLOUDKITTY_FETCHER" == "keystone" ]]; then
         iniset $CLOUDKITTY_CONF fetcher_keystone keystone_version 3
+    elif [ $CLOUDKITTY_FETCHER == 'prometheus' ]; then
+        iniset $CLOUDKITTY_CONF "fetcher_prometheus" prometheus_url $CLOUDKITTY_PROMETHEUS_URL
+        iniset $CLOUDKITTY_CONF "fetcher_prometheus" metric $CLOUDKITTY_FETCHER_METRIC
+        iniset $CLOUDKITTY_CONF "fetcher_prometheus" scope_attribute $CLOUDKITTY_FETCHER_SCOPE_ATTRIBUTE
     fi
 
     if [ "$CLOUDKITTY_STORAGE_BACKEND" == "influxdb" ] && [ "$CLOUDKITTY_INFLUX_VERSION" == 1 ]; then
@@ -166,7 +170,10 @@ function configure_cloudkitty {
     # collect
     iniset $CLOUDKITTY_CONF collect collector $CLOUDKITTY_COLLECTOR
     iniset $CLOUDKITTY_CONF "collector_${CLOUDKITTY_COLLECTOR}" auth_section authinfos
-    iniset $CLOUDKITTY_CONF collect metrics_conf $CLOUDKITTY_CONF_DIR/$CLOUDKITTY_METRICS_CONF
+    if [ $CLOUDKITTY_COLLECTOR == 'prometheus' ]; then
+        iniset $CLOUDKITTY_CONF collector_prometheus prometheus_url $CLOUDKITTY_PROMETHEUS_URL
+    fi
+    iniset $CLOUDKITTY_CONF collect metrics_conf $CLOUDKITTY_CONF_DIR/$(basename $CLOUDKITTY_METRICS_CONF)
     # DO NOT DO THIS IN PRODUCTION! This is done in order to get data quicker
     # when starting a devstack installation, but is NOT a recommended setting
     iniset $CLOUDKITTY_CONF collect wait_periods 0
diff --git a/devstack/settings b/devstack/settings
index 9497b464..13b12e35 100644
--- a/devstack/settings
+++ b/devstack/settings
@@ -41,10 +41,14 @@ CLOUDKITTY_PRICING_TENANT=${CLOUDKITTY_PRICING_TENANT:-"demo"}
 
 # Set CloudKitty fetcher info
 CLOUDKITTY_FETCHER=${CLOUDKITTY_FETCHER:-gnocchi}
+# Prometheus fetcher related setting
+CLOUDKITTY_FETCHER_METRIC=${CLOUDKITTY_FETCHER_METRIC:-openstack_identity_projects_info}
+CLOUDKITTY_FETCHER_SCOPE_ATTRIBUTE=${CLOUDKITTY_FETCHER_SCOPE_ATTRIBUTE:-id}
 
 # Set CloudKitty collect info
 CLOUDKITTY_COLLECTOR=${CLOUDKITTY_COLLECTOR:-gnocchi}
-CLOUDKITTY_METRICS_CONF=metrics.yml
+CLOUDKITTY_METRICS_CONF=${CLOUDKITTY_METRICS_CONF:-$CLOUDKITTY_DIR$CLOUDKITTY_CONF_DIR/metrics.yml}
+CLOUDKITTY_PROMETHEUS_URL=${CLOUDKITTY_PROMETHEUS_URL:-http://localhost:9090/api/v1}
 
 # Set CloudKitty storage info
 CLOUDKITTY_STORAGE_BACKEND=${CLOUDKITTY_STORAGE_BACKEND:-"influxdb"}