openstack
/
cloudkitty
Code Issues Proposed changes

Replace assertItemsEqual with assertCountEqual 

assertItemsEqual was removed from Python's unittest.TestCase in
Python 3.3 [1][2]. We have been able to use them since then, because
testtools required unittest2, which still included it. With testtools
removing Python 2.7 support [3][4], we will lose support for
assertItemsEqual, so we should switch to use assertCountEqual.

[1] - https://bugs.python.org/issue17866
[2] - https://hg.python.org/cpython/rev/d9921cb6e3cd
[3] - testing-cabal/testtools#286
[4] - testing-cabal/testtools#277

Change-Id: Ib8c2acb373db791c0b74b8bea30d424dc44325a5
This commit is contained in:
wangzihao 2020-09-17 17:19:01 +08:00
parent 28b41c17e2
commit cff987ef67
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cloudkitty/tests/fetchers/test_prometheus.py
View File

@ -89,7 +89,7 @@ class PrometheusFetcherTest(tests.TestCase):
with response:
scopes = self.fetcher.get_tenants()
self.assertItemsEqual(scopes, [
self.assertCountEqual(scopes, [
'scope_id1', 'scope_id2', 'scope_id3',
])