From 12e62d6d0954bb0d8ed9aba7cfe0f0d4f890b725 Mon Sep 17 00:00:00 2001 From: Artem Goncharov Date: Mon, 4 Nov 2024 17:44:30 +0100 Subject: [PATCH] Replace wrongly used logging.warn This was long time deprecated and it is a surprise no linter found that before. Change-Id: I921c01254fa04ff57d309f63265313dcc26257da --- codegenerator/metadata.py | 4 ++-- codegenerator/openapi/base.py | 4 ++-- codegenerator/openapi/keystone.py | 4 ++-- codegenerator/openapi/utils.py | 8 ++++---- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/codegenerator/metadata.py b/codegenerator/metadata.py index 781b2f8..ee0654e 100644 --- a/codegenerator/metadata.py +++ b/codegenerator/metadata.py @@ -336,7 +336,7 @@ class MetadataGenerator(BaseGenerator): elif method == "delete": operation_key = "delete" if not operation_key: - logging.warn( + logging.warning( f"Cannot identify op name for {path}:{method}" ) @@ -459,7 +459,7 @@ class MetadataGenerator(BaseGenerator): # Flavor update/create/delete # operations are exposed ALSO as wsgi # actions. This is wrong and useless. - logging.warn( + logging.warning( "Skipping generating %s:%s action", resource_name, action_name, diff --git a/codegenerator/openapi/base.py b/codegenerator/openapi/base.py index 3052178..aa3787a 100644 --- a/codegenerator/openapi/base.py +++ b/codegenerator/openapi/base.py @@ -419,7 +419,7 @@ class OpenStackServerSourceBase: if key and key in versioned_methods: # ACTION with version bounds if len(versioned_methods[key]) > 1: - logging.warn( + logging.warning( f"There are multiple callables for action {key} instead of multiple bodies" ) for ver_method in versioned_methods[key]: @@ -1149,7 +1149,7 @@ class OpenStackServerSourceBase: action_name=None, ) -> tuple[str | None, str | None]: if schema_def is UNSET: - logging.warn( + logging.warning( "No Schema definition for %s[%s] is known", name, action_name ) # Create dummy schema since we got no data for it diff --git a/codegenerator/openapi/keystone.py b/codegenerator/openapi/keystone.py index 64745f7..b1049c9 100644 --- a/codegenerator/openapi/keystone.py +++ b/codegenerator/openapi/keystone.py @@ -313,7 +313,7 @@ class KeystoneGenerator(OpenStackServerSourceBase): sig = inspect.signature(func) for param in args: if param not in sig.parameters: - logging.warn( + logging.warning( "Skipping %s:%s because controller does not support parameter %s", path, method, @@ -328,7 +328,7 @@ class KeystoneGenerator(OpenStackServerSourceBase): and param.name not in args ): # Param with no default is not a path argument - logging.warn( + logging.warning( "Skipping %s:%s because controller requires parameter %s not present in path", path, method, diff --git a/codegenerator/openapi/utils.py b/codegenerator/openapi/utils.py index 47b71ad..3d0f591 100644 --- a/codegenerator/openapi/utils.py +++ b/codegenerator/openapi/utils.py @@ -156,7 +156,7 @@ def merge_api_ref_doc( op_spec = getattr(path_spec, method.lower(), None) if not op_spec: - logging.warn( + logging.warning( f"Cannot find {method} operation for {url} in the spec" ) continue @@ -194,7 +194,7 @@ def merge_api_ref_doc( ): # Found request details if not details_child.table: - logging.warn( + logging.warning( "No Parameters description table found for %s:%s in html", url, method, @@ -259,7 +259,7 @@ def merge_api_ref_doc( ): # Found response details if not details_child.table: - logging.warn( + logging.warning( "No Response Parameters description table found for %s:%s in html", url, method, @@ -340,7 +340,7 @@ def _doc_process_operation_table( else: param_def = src_param if not param_def: - logging.warn("Cannot find parameter %s", src_param) + logging.warning("Cannot find parameter %s", src_param) if ( param_def.location == doc_param_location