openstack
/
congress-tempest-plugin
Code Issues Proposed changes

Fix skipping of tests 

The plugin defines a 'congress' option in the '[service_available]' group
but does not respect it, so if the plugin is installed but
[service_available]/congress=false, the tests will still run unless
blacklisted. This patch corrects the issue by defining the tempest
skip_checks class method.

Change-Id: I8b00f4274afcc22400a3ead9ebd7340b629454b7
This commit is contained in:
Xing Zhang 2020-01-15 14:36:31 +08:00
parent 49cf9efc57
commit dd3bbcb9b0
No known key found for this signature in database
GPG Key ID: 43F80E57B910E3B0
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
congress_tempest_plugin/tests/scenario/manager.py
View File

@ -44,6 +44,12 @@ class ScenarioTest(tempest.test.BaseTestCase):
credentials = ['primary']
@classmethod
def skip_checks(cls):
super(ScenarioTest, cls).skip_checks()
if not CONF.service_available.congress:
raise cls.skipException("Congress support is required")
@classmethod
def setup_clients(cls):
super(ScenarioTest, cls).setup_clients()