Update patch set 3

Patch Set 3: Code-Review-1

(7 comments)

@Eric, Thanks for the patch. Some questions/suggestions inline

Patch-set: 3
Reviewer: Gerrit User 11278 <11278@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1

4dce00b0dbe7500b0e4397f7b48747c8b1e08e86

@@ -0,0 +1,165 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "bf659307_5f471fbd",
+        "filename": "congress/api/row_model.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 183,
+      "author": {
+        "id": 11278
+      },
+      "writtenOn": "2018-04-02T10:44:17Z",
+      "side": 1,
+      "message": "is modify supported too?",
+      "range": {
+        "startLine": 183,
+        "startChar": 30,
+        "endLine": 183,
+        "endChar": 36
+      },
+      "revId": "4dce00b0dbe7500b0e4397f7b48747c8b1e08e86",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bf659307_6aab4374",
+        "filename": "congress/datasources/datasource_driver.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 1264,
+      "author": {
+        "id": 11278
+      },
+      "writtenOn": "2018-04-02T10:44:17Z",
+      "side": 1,
+      "message": "is separate class required? can we merge this with PushedDatasourceDriver ?",
+      "range": {
+        "startLine": 1264,
+        "startChar": 5,
+        "endLine": 1264,
+        "endChar": 31
+      },
+      "revId": "4dce00b0dbe7500b0e4397f7b48747c8b1e08e86",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bf659307_ffb95378",
+        "filename": "congress/datasources/datasource_driver.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 1367,
+      "author": {
+        "id": 11278
+      },
+      "writtenOn": "2018-04-02T10:44:17Z",
+      "side": 1,
+      "message": "required again, it is already exposed as part of PushedDatasource endpoints right?",
+      "range": {
+        "startLine": 1363,
+        "startChar": 0,
+        "endLine": 1367,
+        "endChar": 64
+      },
+      "revId": "4dce00b0dbe7500b0e4397f7b48747c8b1e08e86",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bf659307_eab433f4",
+        "filename": "congress/tests/api/test_row_model.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 145,
+      "author": {
+        "id": 11278
+      },
+      "writtenOn": "2018-04-02T10:44:17Z",
+      "side": 1,
+      "message": "could you help me understand here, updates here are performed in same order?\ninitially , there is remove op here, that wont result in error? as no items ?",
+      "range": {
+        "startLine": 142,
+        "startChar": 0,
+        "endLine": 145,
+        "endChar": 72
+      },
+      "revId": "4dce00b0dbe7500b0e4397f7b48747c8b1e08e86",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bf659307_2a08ebd7",
+        "filename": "congress/tests/api/test_row_model.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 151,
+      "author": {
+        "id": 11278
+      },
+      "writtenOn": "2018-04-02T10:44:17Z",
+      "side": 1,
+      "message": "not required",
+      "range": {
+        "startLine": 151,
+        "startChar": 8,
+        "endLine": 151,
+        "endChar": 24
+      },
+      "revId": "4dce00b0dbe7500b0e4397f7b48747c8b1e08e86",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bf659307_4a343f93",
+        "filename": "congress/tests/api/test_row_model.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 155,
+      "author": {
+        "id": 11278
+      },
+      "writtenOn": "2018-04-02T10:44:17Z",
+      "side": 1,
+      "message": "as only one item here, we can directly use expected_state[0] , or assertEqual doesnt work?",
+      "range": {
+        "startLine": 155,
+        "startChar": 25,
+        "endLine": 155,
+        "endChar": 29
+      },
+      "revId": "4dce00b0dbe7500b0e4397f7b48747c8b1e08e86",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bf659307_2aa46bb9",
+        "filename": "congress/tests/api/test_row_model.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 170,
+      "author": {
+        "id": 11278
+      },
+      "writtenOn": "2018-04-02T10:44:17Z",
+      "side": 1,
+      "message": "imports at start would be better?",
+      "range": {
+        "startLine": 170,
+        "startChar": 7,
+        "endLine": 170,
+        "endChar": 38
+      },
+      "revId": "4dce00b0dbe7500b0e4397f7b48747c8b1e08e86",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}