openstack
/
congress
Code Issues Proposed changes

Replace assertEqual(*, None) with assertIsNone in tests. 

For more clear messages in case of failure.
Closes-bug: #1280522

Change-Id: Icd110ab619dc500cd6bb10137e4f839812533f7b
This commit is contained in:
vishal mahajan 2016-01-18 12:52:19 +05:30
parent ec6f93668f
commit 0e65d5f920
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
congress/tests/datalog/test_compiler.py
View File

@ -29,12 +29,12 @@ class TestParser(base.TestCase):
"""Test correct parsing of tablenames."""
p = compile.parse1('p(1)')
self.assertEqual(p.table.table, 'p')
self.assertEqual(p.table.modal, None)
self.assertEqual(p.table.service, None)
self.assertIsNone(p.table.modal)
self.assertIsNone(p.table.service)
p = compile.parse1('nova:p(1)')
self.assertEqual(p.table.table, 'p')
self.assertEqual(p.table.modal, None)
self.assertIsNone(p.table.modal)
self.assertEqual(p.table.service, 'nova')
p = compile.parse1('execute[nova:p(1)]')
@ -185,7 +185,7 @@ class TestColumnReferences(base.TestCase):
lit = rule.body[0]
self.assertFalse(lit.is_negated())
self.assertEqual(lit.table.table, "q")
self.assertEqual(lit.table.modal, None)
self.assertIsNone(lit.table.modal)
self.assertEqual(lit.table.service, 'nova')
self.assertEqual(len(lit.arguments), 0)
self.assertEqual(len(lit.named_arguments), 1)

2
congress/tests/db/test_db_policy_rules.py
View File

@ -76,7 +76,7 @@ class TestPolicyRulesDb(base.SqlTestCase):
comment=comment)
db_policy_rules.delete_policy_rule(id)
rule = db_policy_rules.get_policy_rule(id, policy_name)
self.assertEqual(rule, None)
self.assertIsNone(rule)
def test_add_delete_get_deleted_policy_rule(self):
id = uuidutils.generate_uuid()