From 8691341ace55a937549ef3fcef475e73987ab64d Mon Sep 17 00:00:00 2001 From: Eric K Date: Wed, 2 Nov 2016 15:01:03 -0700 Subject: [PATCH] remove useless ds-add recovery code code removed because 1. code is correct and would cause error if executed (should be self.bus.delete...) 2. code is not needed because dse_node.add_datasource handles proper recovery internally 3. the code is (I think) unreachable because obj is always None if exception raised by dse_node.add_datasource Change-Id: I2787f0dffce6f52d93b747e93569b6d2c619f190 --- congress/api/datasource_model.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/congress/api/datasource_model.py b/congress/api/datasource_model.py index 4009181ff..0b6cfcda3 100644 --- a/congress/api/datasource_model.py +++ b/congress/api/datasource_model.py @@ -82,10 +82,6 @@ class DatasourceModel(base.APIModel): exception.DriverNotFound, exception.DatasourceCreationError) as e: LOG.exception(_("Datasource creation failed.")) - if obj: - # Do cleanup - # Note(thread-safety): blocking call - self.delete_datasource(obj) raise webservice.DataModelException(e.code, str(e), http_status_code=e.code)