Enable: F812 list comprehension redefines name from line

Change-Id: I282ea334d94cc189c5f392bd08b99361b35b7f55
Closes-Bug: #1398549
This commit is contained in:
Amey Bhide 2014-12-15 15:19:50 -08:00
parent 3f65de3f30
commit 661f6176b3
3 changed files with 4 additions and 5 deletions

View File

@ -73,5 +73,5 @@ class SchemaModel(deepsix.deepSix):
return self._create_table_dict(table, schema)
# all tables
tables = [self._create_table_dict(table, schema) for table in schema]
tables = [self._create_table_dict(table_, schema) for table_ in schema]
return {'tables': tables}

View File

@ -2187,8 +2187,8 @@ class Runtime (object):
new = set(actual_formulas)
to_add = new - old
to_rem = old - new
to_add = [Event(formula) for formula in to_add]
to_rem = [Event(formula, insert=False) for formula in to_rem]
to_add = [Event(formula_) for formula_ in to_add]
to_rem = [Event(formula_, insert=False) for formula_ in to_rem]
self.table_log(None, "Initialize converted to update with %s and %s",
iterstr(to_add), iterstr(to_rem))
return self.update(to_add + to_rem, target=target)

View File

@ -39,7 +39,6 @@ commands = python setup.py testr --no-parallel --testr-args='test_benchmark {pos
# E251 unexpected spaces around keyword / parameter equals
# F402 import module shadowed by loop variable
# F811 redefinition of unused variable
# F812 list comprehension redefines name from line
# H237 module is removed in Python 3
# H305 imports not grouped correctly
# H401 docstring should not start with a space
@ -50,6 +49,6 @@ commands = python setup.py testr --no-parallel --testr-args='test_benchmark {pos
show-source = True
ignore = E128,E129,E251,F402,F811,F812,H237,H305,H401,H405,H904,H302
ignore = E128,E129,E251,F402,F811,H237,H305,H401,H405,H904,H302
builtins = _
exclude=.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,*thirdparty/*,CongressLexer.py,CongressParser.py