openstack
/
cookbook-openstack-block-storage
Code Issues Proposed changes

Rubocop support for metadata.rb and Gemfile 

Replace double-quotes with single-quotes for now, expect this to act as a gate
in the future.

Change-Id: I10ff8b23517cb334905b162ce14059dbf23d7bc8
This commit is contained in:
Matt Ray 2013-12-24 09:40:34 -06:00
parent caff601e2c
commit 0ef57f0473
4 changed files with 34 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
.rubocop.yml Normal file
View File

@ -0,0 +1,7 @@
# UTF-8 headers not generally in these files
Encoding:
Enabled: false
# ignore long lines
LineLength:
Enabled: false

16
Gemfile
View File

@ -1,9 +1,9 @@
source "https://rubygems.org" source 'https://rubygems.org'
gem "chef", "~> 11.4.4" gem 'chef', '~> 11.4.4'
gem "json", "<= 1.7.7" # chef 11 dependency gem 'json', '<= 1.7.7' # chef 11 dependency
gem "berkshelf", "~> 2.0.10" gem 'berkshelf', '~> 2.0.10'
gem "chefspec", "~> 3.0.2" gem 'chefspec', '~> 3.0.2'
gem "foodcritic", "~> 3.0.3" gem 'foodcritic', '~> 3.0.3'
gem "strainer" gem 'strainer'
gem "rubocop" gem 'rubocop'

2
Strainerfile
View File

@ -1,5 +1,7 @@
# Strainerfile # Strainerfile
rubocop: bundle exec rubocop $SANDBOX/$COOKBOOK/attributes/ rubocop: bundle exec rubocop $SANDBOX/$COOKBOOK/attributes/
rubocop: bundle exec rubocop $SANDBOX/$COOKBOOK/metadata.rb
rubocop: bundle exec rubocop $SANDBOX/$COOKBOOK/Gemfile
# rubocop: bundle exec rubocop $SANDBOX/$COOKBOOK # rubocop: bundle exec rubocop $SANDBOX/$COOKBOOK
# may want to add rubocop check for Berksfile and Gemfile # may want to add rubocop check for Berksfile and Gemfile
knife test: bundle exec knife cookbook test $COOKBOOK knife test: bundle exec knife cookbook test $COOKBOOK

34
metadata.rb
View File

@ -1,24 +1,24 @@
name "openstack-block-storage" name 'openstack-block-storage'
maintainer "AT&T Services, Inc." maintainer 'AT&T Services, Inc.'
maintainer_email "cookbooks@lists.tfoundry.com" maintainer_email 'cookbooks@lists.tfoundry.com'
license "Apache 2.0" license 'Apache 2.0'
description "The OpenStack Advanced Volume Management service Cinder." description 'The OpenStack Advanced Volume Management service Cinder.'
long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) long_description IO.read(File.join(File.dirname(__FILE__), 'README.md'))
version "8.0.0" version '8.0.0'
recipe "openstack-block-storage::common", "Defines the common pieces of repeated code from the other recipes" recipe 'openstack-block-storage::common', 'Defines the common pieces of repeated code from the other recipes'
recipe "openstack-block-storage::api", "Installs the cinder-api, sets up the cinder database, and cinder service/user/endpoints in keystone" recipe 'openstack-block-storage::api', 'Installs the cinder-api, sets up the cinder database, and cinder service/user/endpoints in keystone'
recipe "openstack-block-storage::keystone_registration", "Registers cinder service/user/endpoints in keystone" recipe 'openstack-block-storage::keystone_registration', 'Registers cinder service/user/endpoints in keystone'
recipe "openstack-block-storage::scheduler", "Installs the cinder-scheduler service" recipe 'openstack-block-storage::scheduler', 'Installs the cinder-scheduler service'
recipe "openstack-block-storage::volume", "Installs the cinder-volume service and sets up the iscsi helper" recipe 'openstack-block-storage::volume', 'Installs the cinder-volume service and sets up the iscsi helper'
%w{ ubuntu fedora redhat centos suse }.each do |os| %w{ ubuntu fedora redhat centos suse }.each do |os|
supports os supports os
end end
depends "apt" depends 'apt'
depends "openstack-common", "~> 8.0" depends 'openstack-common', '~> 8.0'
depends "openstack-identity", "~> 8.0" depends 'openstack-identity', '~> 8.0'
depends "openstack-image", "~> 8.0" depends 'openstack-image', '~> 8.0'
depends "selinux" depends 'selinux'
depends "python" depends 'python'