Per the mailing list thread, introducing Rubocop as a replacement for Tailor. Assuming Jenkins likes this, more pedantic patches will follow to make Rubocop happy. So far this is just spacing issues and adding UTF-8 headers, but more work will need to be done to remove all of the changes for the .rubocop-todo.yml Addresses: blueprint rubocop-for-block-storage Change-Id: Ibb11739e452016c101995a371d031faeeb7e7683
149 lines
5.2 KiB
Ruby
149 lines
5.2 KiB
Ruby
# encoding: UTF-8
|
|
#
|
|
# Cookbook Name:: openstack-block-storage
|
|
|
|
require_relative "spec_helper"
|
|
|
|
describe "openstack-block-storage::volume" do
|
|
before { block_storage_stubs }
|
|
describe "ubuntu" do
|
|
before do
|
|
@chef_run = ::ChefSpec::Runner.new ::UBUNTU_OPTS do |n|
|
|
n.set["openstack"]["block-storage"]["syslog"]["use"] = true
|
|
end
|
|
@chef_run.converge "openstack-block-storage::volume"
|
|
end
|
|
|
|
expect_runs_openstack_common_logging_recipe
|
|
|
|
it "doesn't run logging recipe" do
|
|
chef_run = ::ChefSpec::Runner.new ::UBUNTU_OPTS
|
|
chef_run.converge "openstack-block-storage::volume"
|
|
|
|
expect(chef_run).not_to include_recipe "openstack-common::logging"
|
|
end
|
|
|
|
it "installs cinder volume packages" do
|
|
expect(@chef_run).to upgrade_package "cinder-volume"
|
|
end
|
|
|
|
it "installs mysql python packages by default" do
|
|
expect(@chef_run).to upgrade_package "python-mysqldb"
|
|
end
|
|
|
|
it "installs postgresql python packages if explicitly told" do
|
|
chef_run = ::ChefSpec::Runner.new ::UBUNTU_OPTS
|
|
node = chef_run.node
|
|
node.set["openstack"]["db"]["volume"]["db_type"] = "postgresql"
|
|
chef_run.converge "openstack-block-storage::volume"
|
|
|
|
expect(chef_run).to upgrade_package "python-psycopg2"
|
|
expect(chef_run).not_to upgrade_package "python-mysqldb"
|
|
end
|
|
|
|
it "installs cinder iscsi packages" do
|
|
expect(@chef_run).to upgrade_package "tgt"
|
|
end
|
|
|
|
it "installs nfs packages" do
|
|
chef_run = ::ChefSpec::Runner.new ::UBUNTU_OPTS do |n|
|
|
n.set["openstack"]["block-storage"]["volume"]["driver"] = "cinder.volume.drivers.netapp.nfs.NetAppDirect7modeNfsDriver"
|
|
end
|
|
chef_run.converge "openstack-block-storage::volume"
|
|
|
|
expect(chef_run).to upgrade_package "nfs-common"
|
|
end
|
|
|
|
it "creates the nfs mount point" do
|
|
chef_run = ::ChefSpec::Runner.new ::UBUNTU_OPTS do |n|
|
|
n.set["openstack"]["block-storage"]["volume"]["driver"] = "cinder.volume.drivers.netapp.nfs.NetAppDirect7modeNfsDriver"
|
|
end
|
|
chef_run.converge "openstack-block-storage::volume"
|
|
|
|
expect(chef_run).to create_directory "/mnt/cinder-volumes"
|
|
end
|
|
|
|
it "configures netapp dfm password" do
|
|
::Chef::Recipe.any_instance.stub(:service_password).with("netapp")
|
|
.and_return "netapp-pass"
|
|
chef_run = ::ChefSpec::Runner.new ::UBUNTU_OPTS do |n|
|
|
n.set["openstack"]["block-storage"]["volume"]["driver"] = "cinder.volume.drivers.netapp.iscsi.NetAppISCSIDriver"
|
|
end
|
|
chef_run.converge "openstack-block-storage::volume"
|
|
n = chef_run.node["openstack"]["block-storage"]["netapp"]["dfm_password"]
|
|
|
|
expect(n).to eq "netapp-pass"
|
|
end
|
|
|
|
it "configures rbd password" do
|
|
::Chef::Recipe.any_instance.stub(:service_password).with("rbd")
|
|
.and_return "rbd-pass"
|
|
chef_run = ::ChefSpec::Runner.new ::UBUNTU_OPTS do |n|
|
|
n.set["openstack"]["block-storage"]["volume"]["driver"] = "cinder.volume.drivers.RBDDriver"
|
|
end
|
|
chef_run.converge "openstack-block-storage::volume"
|
|
n = chef_run.node["openstack"]["block-storage"]["rbd_secret_uuid"]
|
|
|
|
expect(n).to eq "rbd-pass"
|
|
end
|
|
|
|
it "starts cinder volume" do
|
|
expect(@chef_run).to start_service "cinder-volume"
|
|
end
|
|
|
|
it "starts cinder volume on boot" do
|
|
expect(@chef_run).to enable_service "cinder-volume"
|
|
end
|
|
|
|
expect_creates_cinder_conf "service[cinder-volume]", "cinder", "cinder"
|
|
|
|
it "starts iscsi target on boot" do
|
|
expect(@chef_run).to enable_service "tgt"
|
|
end
|
|
|
|
describe "targets.conf" do
|
|
before do
|
|
@file = @chef_run.template "/etc/tgt/targets.conf"
|
|
end
|
|
|
|
it "has proper modes" do
|
|
expect(sprintf("%o", @file.mode)).to eq "600"
|
|
end
|
|
|
|
it "notifies iscsi restart" do
|
|
expect(@file).to notify("service[iscsitarget]").to(:restart)
|
|
end
|
|
|
|
it "has ubuntu include" do
|
|
expect(@chef_run).to render_file(@file.name).with_content("include /etc/tgt/conf.d/*.conf")
|
|
expect(@chef_run).not_to render_file(@file.name).with_content("include /var/lib/cinder/volumes/*")
|
|
end
|
|
end
|
|
|
|
describe "create_vg" do
|
|
before do
|
|
@chef_run = ::ChefSpec::Runner.new ::UBUNTU_OPTS do |n|
|
|
n.set["openstack"]["block-storage"]["volume"]["driver"] = "cinder.volume.drivers.lvm.LVMISCSIDriver"
|
|
n.set["openstack"]["block-storage"]["volume"]["create_volume_group"] = true
|
|
end
|
|
stub_command("vgs cinder-volumes").and_return(false)
|
|
@chef_run.converge "openstack-block-storage::volume"
|
|
end
|
|
|
|
it "cinder vg active" do
|
|
expect(@chef_run).to enable_service "cinder-group-active"
|
|
end
|
|
|
|
it "create volume group" do
|
|
volume_size = @chef_run.node["openstack"]["block-storage"]["volume"]["volume_group_size"]
|
|
seek_count = volume_size.to_i * 1024
|
|
group_name = @chef_run.node["openstack"]["block-storage"]["volume"]["volume_group"]
|
|
path = @chef_run.node["openstack"]["block-storage"]["volume"]["state_path"]
|
|
vg_file = "#{path}/#{group_name}.img"
|
|
cmd = "dd if=/dev/zero of=#{vg_file} bs=1M seek=#{seek_count} count=0; vgcreate cinder-volumes $(losetup --show -f #{vg_file})"
|
|
expect(@chef_run).to run_execute(cmd)
|
|
end
|
|
end
|
|
end
|
|
end
|