This updates all references of let(:chef_run) to cached(:chef_run) to speed up
tests. By doing this, we have to create a new cached(:chef_run) block whenever
we need to adjust node attributes for testing.
Some additional fixes include:
- Add default['openstack']['common']['search_count_max'] attribute to allow speed
ups during testing.
- Improved a few tests
- Adjusted some formatting
- Remove deprecated ChefSpec::Coverage.start function
- Show warnings
- Use major version for redhat platform
- Update to Ubuntu 18.04
Speed was improved from 4 minutes 16 seconds to 41.98 seconds.
Change-Id: Icb9147036a01f92ec48a24c692dd022258e294c0
4000e8aa96