openstack/cookbook-openstack-compute
Code Issues Proposed changes

Foodcritic cleanups

Browse Source 
Think I got em all right, esp the subscribes...

FC033: Missing template: cookbook-nova/recipes/nova-common.rb:124
FC033: Missing template: cookbook-nova/recipes/nova-common.rb:132
FC033: Missing template: cookbook-nova/recipes/nova-common.rb:140
FC033: Missing template: cookbook-nova/recipes/nova-common.rb:148
FC034: Unused template variables: cookbook-nova/templates/default/nova.conf.erb:1
FC034: Unused template variables: cookbook-nova/templates/default/openrc.erb:1
FC043: Prefer new notification syntax: cookbook-nova/recipes/api-ec2.rb:50
FC043: Prefer new notification syntax: cookbook-nova/recipes/api-ec2.rb:138
FC043: Prefer new notification syntax: cookbook-nova/recipes/api-metadata.rb:50
FC043: Prefer new notification syntax: cookbook-nova/recipes/api-metadata.rb:65
FC043: Prefer new notification syntax: cookbook-nova/recipes/api-os-compute.rb:50
FC043: Prefer new notification syntax: cookbook-nova/recipes/api-os-compute.rb:137
FC043: Prefer new notification syntax: cookbook-nova/recipes/compute.rb:54
FC043: Prefer new notification syntax: cookbook-nova/recipes/libvirt.rb:72
FC043: Prefer new notification syntax: cookbook-nova/recipes/libvirt.rb:84
FC043: Prefer new notification syntax: cookbook-nova/recipes/libvirt.rb:95
FC043: Prefer new notification syntax: cookbook-nova/recipes/network.rb:32
FC043: Prefer new notification syntax: cookbook-nova/recipes/nova-cert.rb:31
FC043: Prefer new notification syntax: cookbook-nova/recipes/scheduler.rb:40
FC043: Prefer new notification syntax: cookbook-nova/recipes/vncproxy.rb:39
FC043: Prefer new notification syntax: cookbook-nova/recipes/vncproxy.rb:47
This commit is contained in:
John Dewey
2013-01-03 22:55:11 -08:00
parent af7eed6316
commit e59e131ad8
16 changed files with 24 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
recipes/libvirt.rb
View File

@@ -78,7 +78,7 @@ template "/etc/libvirt/libvirtd.conf" do
:auth_tcp => node["nova"]["libvirt"]["auth_tcp"]
)
notifies :restart, resources(:service => "libvirt-bin"), :immediately
notifies :restart, service['libvirt-bin'], :immediately
end
template "/etc/default/libvirt-bin" do
@@ -87,7 +87,7 @@ template "/etc/default/libvirt-bin" do
group "root"
mode 00644
notifies :restart, resources(:service => "libvirt-bin"), :immediately
notifies :restart, service['libvirt-bin'], :immediately
only_if { platform? %w{ubuntu debian} }
end
@@ -98,7 +98,7 @@ template "/etc/sysconfig/libvirtd" do
group "root"
mode 00644
notifies :restart, resources(:service => "libvirt-bin"), :immediately
notifies :restart, service['libvirt-bin'], :immediately
only_if { platform? %w{fedora redhat centos} }
end