Foodcritic cleanups

Think I got em all right, esp the subscribes...

FC033: Missing template: cookbook-nova/recipes/nova-common.rb:124
FC033: Missing template: cookbook-nova/recipes/nova-common.rb:132
FC033: Missing template: cookbook-nova/recipes/nova-common.rb:140
FC033: Missing template: cookbook-nova/recipes/nova-common.rb:148
FC034: Unused template variables: cookbook-nova/templates/default/nova.conf.erb:1
FC034: Unused template variables: cookbook-nova/templates/default/openrc.erb:1
FC043: Prefer new notification syntax: cookbook-nova/recipes/api-ec2.rb:50
FC043: Prefer new notification syntax: cookbook-nova/recipes/api-ec2.rb:138
FC043: Prefer new notification syntax: cookbook-nova/recipes/api-metadata.rb:50
FC043: Prefer new notification syntax: cookbook-nova/recipes/api-metadata.rb:65
FC043: Prefer new notification syntax: cookbook-nova/recipes/api-os-compute.rb:50
FC043: Prefer new notification syntax: cookbook-nova/recipes/api-os-compute.rb:137
FC043: Prefer new notification syntax: cookbook-nova/recipes/compute.rb:54
FC043: Prefer new notification syntax: cookbook-nova/recipes/libvirt.rb:72
FC043: Prefer new notification syntax: cookbook-nova/recipes/libvirt.rb:84
FC043: Prefer new notification syntax: cookbook-nova/recipes/libvirt.rb:95
FC043: Prefer new notification syntax: cookbook-nova/recipes/network.rb:32
FC043: Prefer new notification syntax: cookbook-nova/recipes/nova-cert.rb:31
FC043: Prefer new notification syntax: cookbook-nova/recipes/scheduler.rb:40
FC043: Prefer new notification syntax: cookbook-nova/recipes/vncproxy.rb:39
FC043: Prefer new notification syntax: cookbook-nova/recipes/vncproxy.rb:47

attributes/default.rb

@@ -159,7 +159,7 @@ default["nova"]["ratelimit"]["api"]["enabled"] = true
 default["nova"]["api"]["signing_dir"] = "/tmp/keystone-sign-nova"
 
 case platform
-when "fedora", "redhat", "centos"
+when "fedora", "redhat", "centos" # :pragma-foodcritic: ~FC024 - won't fix this
   default["nova"]["platform"] = {
     "api_ec2_packages" => ["openstack-nova-api"],
     "api_ec2_service" => "openstack-nova-api",

recipes/api-ec2.rb

@@ -50,7 +50,7 @@ end
 service "nova-api-ec2" do
   service_name platform_options["api_ec2_service"]
   supports :status => true, :restart => true
-  subscribes :restart, resources(:template => "/etc/nova/nova.conf"), :delayed
+  subscribes :restart, resources("template['/etc/nova/nova.conf']")
 
   action :enable
 end
@@ -145,5 +145,5 @@ template "/etc/nova/api-paste.ini" do
     "service_password" => service_pass
   )
 
-  notifies :restart, resources(:service => "nova-api-ec2"), :delayed
+  notifies :restart, service['nova-api-ec2']
 end

recipes/api-metadata.rb

@@ -50,7 +50,7 @@ end
 service "nova-api-metadata" do
   service_name platform_options["nova_api_metadata_service"]
   supports :status => true, :restart => true
-  subscribes :restart, resources(:template => "/etc/nova/nova.conf"), :delayed
+  subscribes :restart, resources("template['/etc/nova/nova.conf']")
 
   action :enable
 end
@@ -72,5 +72,5 @@ template "/etc/nova/api-paste.ini" do
     "service_password" => service_pass
   )
 
-  notifies :restart, resources(:service => "nova-api-metadata"), :delayed
+  notifies :restart, service['nova-api-metadata']
 end

recipes/api-os-compute.rb

@@ -50,7 +50,7 @@ end
 service "nova-api-os-compute" do
   service_name platform_options["api_os_compute_service"]
   supports :status => true, :restart => true
-  subscribes :restart, resources(:template => "/etc/nova/nova.conf"), :delayed
+  subscribes :restart, resources("template['/etc/nova/nova.conf']")
 
   action :enable
 end
@@ -144,5 +144,5 @@ template "/etc/nova/api-paste.ini" do
     "service_password" => service_pass
   )
 
-  notifies :restart, resources(:service => "nova-api-os-compute"), :delayed
+  notifies :restart, service['nova-api-os-compute']
 end

recipes/compute.rb

@@ -54,7 +54,7 @@ end
 service "nova-compute" do
   service_name platform_options["nova_compute_service"]
   supports :status => true, :restart => true
-  subscribes :restart, resources(:template => "/etc/nova/nova.conf"), :delayed
+  subscribes :restart, resources("template['/etc/nova/nova.conf']")
 
   action :enable
 end

recipes/libvirt.rb

@@ -78,7 +78,7 @@ template "/etc/libvirt/libvirtd.conf" do
     :auth_tcp => node["nova"]["libvirt"]["auth_tcp"]
   )
 
-  notifies :restart, resources(:service => "libvirt-bin"), :immediately
+  notifies :restart, service['libvirt-bin'], :immediately
 end
 
 template "/etc/default/libvirt-bin" do
@@ -87,7 +87,7 @@ template "/etc/default/libvirt-bin" do
   group  "root"
   mode   00644
 
-  notifies :restart, resources(:service => "libvirt-bin"), :immediately
+  notifies :restart, service['libvirt-bin'], :immediately
 
   only_if { platform? %w{ubuntu debian} }
 end
@@ -98,7 +98,7 @@ template "/etc/sysconfig/libvirtd" do
   group  "root"
   mode   00644
 
-  notifies :restart, resources(:service => "libvirt-bin"), :immediately
+  notifies :restart, service['libvirt-bin'], :immediately
 
   only_if { platform? %w{fedora redhat centos} }
 end

recipes/network.rb

@@ -32,7 +32,7 @@ end
 service "nova-network" do
   service_name platform_options["nova_network_service"]
   supports :status => true, :restart => true
-  subscribes :restart, resources(:template => "/etc/nova/nova.conf"), :delayed
+  subscribes :restart, resources("template['/etc/nova/nova.conf']")
 
   action :enable
 end

recipes/nova-cert.rb

@@ -31,7 +31,7 @@ end
 service "nova-cert" do
   service_name platform_options["nova_cert_service"]
   supports :status => true, :restart => true
-  subscribes :restart, resources(:template => "/etc/nova/nova.conf"), :delayed
+  subscribes :restart, resources("template['/etc/nova/nova.conf']")
 
   action :enable
 end

recipes/nova-common.rb

@@ -103,13 +103,14 @@ template "/etc/nova/nova.conf" do
   mode 00644
   variables(
     :sql_connection => sql_connection,
-    :vncserver_listen => "0.0.0.0",
     :vncserver_proxyclient_address => novnc_proxy_endpoint.host,
     :novncproxy_base_url => novnc_endpoint.to_s,
     :xvpvncproxy_bind_host => xvpvnc_endpoint.host,
     :xvpvncproxy_bind_port => xvpvnc_endpoint.port,
     :xvpvncproxy_base_url => xvpvnc_endpoint.to_s,
     :rabbit_ipaddress => rabbit_info["host"],
+    #TODO(retr0h): Will be changed with our HA work
+    :rabbit_password => "guest",
     :rabbit_port => rabbit_info["port"],
     :identity_endpoint => identity_endpoint,
     # TODO(jaypipes): No support here for >1 image API servers
@@ -122,7 +123,7 @@ template "/etc/nova/nova.conf" do
 end
 
 template "/etc/nova/rootwrap.conf" do
-  source "rootwrap.conf"
+  source "rootwrap.conf.erb"
   # Must be root!
   owner  "root"
   group  "root"
@@ -130,7 +131,7 @@ template "/etc/nova/rootwrap.conf" do
 end
 
 template "/etc/nova/rootwrap.d/api-metadata.filters" do
-  source "rootwrap.d/api-metadata.filters"
+  source "rootwrap.d/api-metadata.filters.erb"
   # Must be root!
   owner  "root"
   group  "root"
@@ -138,7 +139,7 @@ template "/etc/nova/rootwrap.d/api-metadata.filters" do
 end
 
 template "/etc/nova/rootwrap.d/compute.filters" do
-  source "rootwrap.d/compute.filters"
+  source "rootwrap.d/compute.filters.erb"
   # Must be root!
   owner  "root"
   group  "root"
@@ -146,7 +147,7 @@ template "/etc/nova/rootwrap.d/compute.filters" do
 end
 
 template "/etc/nova/rootwrap.d/network.filters" do
-  source "rootwrap.d/network.filters"
+  source "rootwrap.d/network.filters.erb"
   # Must be root!
   owner  "root"
   group  "root"
@@ -167,14 +168,12 @@ template "/root/openrc" do
     :tenant => ksadmin_tenant_name,
     :password => ksadmin_pass,
     :identity_admin_endpoint => identity_admin_endpoint,
-    :nova_api_ipaddress => nova_api_endpoint.host,
     :nova_api_version => "1.1",
     :auth_strategy => "keystone",
     :ec2_url => ec2_public_endpoint.to_s
   )
 end
 
-
 execute "enable nova login" do
   command "usermod -s /bin/sh nova"
 end

recipes/scheduler.rb

@@ -40,7 +40,7 @@ end
 service "nova-scheduler" do
   service_name platform_options["nova_scheduler_service"]
   supports :status => true, :restart => true
-  subscribes :restart, resources(:template => "/etc/nova/nova.conf"), :delayed
+  subscribes :restart, resources("template['/etc/nova/nova.conf']")
 
   action [:enable, :start]
 end

recipes/vncproxy.rb

@@ -39,7 +39,7 @@ end
 service "nova-vncproxy" do
   service_name platform_options["nova_vncproxy_service"]
   supports :status => true, :restart => true
-  subscribes :restart, resources(:template => "/etc/nova/nova.conf"), :delayed
+  subscribes :restart, resources("template['/etc/nova/nova.conf']")
 
   action :enable
 end
@@ -47,7 +47,7 @@ end
 service "nova-consoleauth" do
   service_name platform_options["nova_vncproxy_consoleauth_service"]
   supports :status => true, :restart => true
-  subscribes :restart, resources(:template => "/etc/nova/nova.conf"), :delayed
+  subscribes :restart, resources("template['/etc/nova/nova.conf']")
 
   action [ :enable, :start ]
 end

templates/default/nova.conf.erb

@@ -16,8 +16,8 @@ state_path=/var/lib/nova
 lock_path=/var/lock/nova
 
 ##### RABBITMQ #####
-rabbit_password=guest
-rabbit_port=5672
+rabbit_password=<%= @rabbit_password %>
+rabbit_port=<%= @rabbit_port %>
 rabbit_host=<%= @rabbit_ipaddress %>
 
 ##### SCHEDULER #####