a855056aa9
Patch Set 3: Code-Review-1 (7 comments) Patch-set: 3 Reviewer: Gerrit User 13252 <13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
112 lines
3.7 KiB
Plaintext
112 lines
3.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_6aa191a8",
|
|
"filename": "attributes/default.rb",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 27,
|
|
"author": {
|
|
"id": 13252
|
|
},
|
|
"writtenOn": "2018-07-12T14:14:16Z",
|
|
"side": 1,
|
|
"message": "I think this is wrong, the plain endpoint should not need to contain the version information.",
|
|
"revId": "d9fffcbd1740cc207b29edde29fceba3299fe493",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_2a22b9a4",
|
|
"filename": "recipes/common.rb",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 73,
|
|
"author": {
|
|
"id": 13252
|
|
},
|
|
"writtenOn": "2018-07-12T14:14:16Z",
|
|
"side": 1,
|
|
"message": "Actually it is a bit debatable whether internal services (from a user pov) should be using the public or the internal endpoint. Instead of hardcoding the public endpoint, which to me seems like a step into the wrong direction, we should stick to the internal one in my opinionated view.\n\nAn alternative would be to make this choice configurable for the deployer, but I\u0027m not sure that that added complexity is useful.",
|
|
"revId": "d9fffcbd1740cc207b29edde29fceba3299fe493",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_0a3c9d90",
|
|
"filename": "recipes/identity_registration.rb",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 27,
|
|
"author": {
|
|
"id": 13252
|
|
},
|
|
"writtenOn": "2018-07-12T14:14:16Z",
|
|
"side": 1,
|
|
"message": "Same thing here, I\u0027d rather use the internal endpoint.",
|
|
"revId": "d9fffcbd1740cc207b29edde29fceba3299fe493",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_6a0511c1",
|
|
"filename": "recipes/identity_registration.rb",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 28,
|
|
"author": {
|
|
"id": 13252
|
|
},
|
|
"writtenOn": "2018-07-12T14:14:16Z",
|
|
"side": 1,
|
|
"message": "I think we should drop these transformations everywhere, just use the version we have in the endpoint. But that may be better done in a separate patch series that fixes this consistently for all cookbooks.",
|
|
"revId": "d9fffcbd1740cc207b29edde29fceba3299fe493",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_cae1c5ff",
|
|
"filename": "recipes/neutron_int.rb",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 26,
|
|
"author": {
|
|
"id": 13252
|
|
},
|
|
"writtenOn": "2018-07-12T14:14:16Z",
|
|
"side": 1,
|
|
"message": "I\u0027m thinking that this may add the version path twice. It is really only needed because neutron lacks the ability to do version discovery properly. I\u0027d rather leave this the original version.",
|
|
"revId": "d9fffcbd1740cc207b29edde29fceba3299fe493",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_caca256e",
|
|
"filename": "recipes/neutron_int.rb",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 29,
|
|
"author": {
|
|
"id": 13252
|
|
},
|
|
"writtenOn": "2018-07-12T14:14:16Z",
|
|
"side": 1,
|
|
"message": "Same comments as for other recipes apply.",
|
|
"range": {
|
|
"startLine": 28,
|
|
"startChar": 0,
|
|
"endLine": 29,
|
|
"endChar": 97
|
|
},
|
|
"revId": "d9fffcbd1740cc207b29edde29fceba3299fe493",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |