Browse Source

Remove superfluous role_name arguments

This patch removes the role_name when using openstack_user's :create
action (it gets ignored by the target method).

Note that the spec test would still pass if only the line in
identity_registration.rb (but not the test) were changed, because the
code that actually does grant the role to the resource is executed right
after user creation and before any tests check the resource for the
existence of the role_name attribute. In other words: if the argument
were required in a call but only supplied in another call, the spec
tests would not catch it. Something to watch out for.

Change-Id: I9061b748281910bef3927757bdf22edfd36b7448
Roger Luethi 1 year ago
parent
commit
7402658214
2 changed files with 0 additions and 2 deletions
  1. 0
    1
      recipes/identity_registration.rb
  2. 0
    1
      spec/identity_registration_spec.rb

+ 0
- 1
recipes/identity_registration.rb View File

@@ -86,7 +86,6 @@ end
86 86
 # Register Service User
87 87
 openstack_user service_user do
88 88
   project_name service_tenant_name
89
-  role_name service_role
90 89
   password service_pass
91 90
   connection_params connection_params
92 91
 end

+ 0
- 1
spec/identity_registration_spec.rb View File

@@ -68,7 +68,6 @@ describe 'openstack-network::identity_registration' do
68 68
         service_user
69 69
       ).with(
70 70
         project_name: project_name,
71
-        role_name: role_name,
72 71
         password: password,
73 72
         connection_params: connection_params
74 73
       )

Loading…
Cancel
Save