openstack/cookbook-openstack-ops-messaging
Code Issues Proposed changes

Update patch set 4

Browse Source 
Patch Set 4: I would prefer that you didn't merge this

(5 inline comments)

Few nits inline. As for the service_ and user_password comment (see inline), I'm cool doing that on a followup commit.

Patch-set: 4
Label: Code-Review=-1
Label: Workflow=0
This commit is contained in:
Gerrit User 7 2013-06-26 19:38:22 +00:00 committed by Gerrit Code Review
parent 889d41ae0b
commit 532c9e6471
1 changed files with 89 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

89
4b9493680f1b340496bc2550b083013c254d2f02 Normal file
View File

@ -0,0 +1,89 @@
{
"comments": [
{
"key": {
"uuid": "AAAAPn//nGU\u003d",
"filename": "metadata.rb",
"patchSetId": 4
},
"lineNbr": 9,
"author": {
"id": 7
},
"writtenOn": "2013-06-26T19:38:22Z",
"side": 1,
"message": "s/configured/configures",
"revId": "4b9493680f1b340496bc2550b083013c254d2f02",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAPn//nGI\u003d",
"filename": "recipes/rabbit-server.rb",
"patchSetId": 4
},
"lineNbr": 3,
"author": {
"id": 7
},
"writtenOn": "2013-06-26T19:38:22Z",
"side": 1,
"message": "s/mysql-server/rabbit-server/",
"revId": "4b9493680f1b340496bc2550b083013c254d2f02",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAPn//nF0\u003d",
"filename": "recipes/rabbit-server.rb",
"patchSetId": 4
},
"lineNbr": 27,
"author": {
"id": 7
},
"writtenOn": "2013-06-26T19:38:22Z",
"side": 1,
"message": "service_password is only used (so far at least) for OpenStack services, not infrastructure services... I actually think it would be best to remove the separate user_ service_ and db_ password routines in openstack-common and replace with just a single \"secret\" or \"password\" library routine.",
"revId": "4b9493680f1b340496bc2550b083013c254d2f02",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAPn//nE8\u003d",
"filename": "spec/rabbit-server_spec.rb",
"patchSetId": 4
},
"lineNbr": 80,
"author": {
"id": 7
},
"writtenOn": "2013-06-26T19:38:22Z",
"side": 1,
"message": "Please uncomment above test :)",
"revId": "4b9493680f1b340496bc2550b083013c254d2f02",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAPn//nEE\u003d",
"filename": "spec/spec_helper.rb",
"patchSetId": 4
},
"lineNbr": 26,
"author": {
"id": 7
},
"writtenOn": "2013-06-26T19:38:22Z",
"side": 1,
"message": "I don\u0027t understand why the above would need to be commented out?",
"revId": "4b9493680f1b340496bc2550b083013c254d2f02",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}