openstack
/
cookbook-openstack-ops-messaging
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: I would prefer that you didn't merge this

(1 inline comment)



Patch-set: 3
Reviewer: Gerrit User 2340 <2340@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Label: Workflow=0
This commit is contained in:
Gerrit User 2340 2013-06-25 13:26:05 +00:00 committed by Gerrit Code Review
parent a99ea72318
commit bf8d13db3c
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
564d55b4464fa442faec6ef3ff5d0d8fccf3440a Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "AAAAPn//rZc\u003d",
"filename": "README.md",
"patchSetId": 3
},
"lineNbr": 8,
"author": {
"id": 2340
},
"writtenOn": "2013-06-25T13:26:05Z",
"side": 1,
"message": "I don\u0027t really like the idea of having to maintain this plugin separately from upstream. This work will have to be duplicated by all distributions/users of these cookbooks.\n\nThe code looks simple enough. Just a helper function. Can\u0027t we just put it in a library? in openstack-common for example?",
"revId": "564d55b4464fa442faec6ef3ff5d0d8fccf3440a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}