Browse Source

Remove superfluous role_name arguments

This patch removes the role_name when using openstack_user's :create
action (it gets ignored by the target method).

Note that the spec test would still pass if only the line in
identity_registration.rb (but not the test) were changed, because the
code that actually does grant the role to the resource is executed right
after user creation and before any tests check the resource for the
existence of the role_name attribute. In other words: if the argument
were required in a call but only supplied in another call, the spec
tests would not catch it. Something to watch out for.

Change-Id: Ic45dd42453d9f8ae2a8c4d04f830cff67740cac6
Roger Luethi 1 year ago
parent
commit
48fdd181f9
2 changed files with 0 additions and 3 deletions
  1. 0
    2
      recipes/identity_registration.rb
  2. 0
    1
      spec/identity_registration_spec.rb

+ 0
- 2
recipes/identity_registration.rb View File

@@ -101,7 +101,6 @@ end
101 101
 # Register Service User
102 102
 openstack_user service_user do
103 103
   project_name service_project_name
104
-  role_name service_role
105 104
   password service_pass
106 105
   connection_params connection_params
107 106
 end
@@ -164,7 +163,6 @@ end
164 163
 
165 164
 openstack_user stack_domain_admin do
166 165
   domain_name heat_domain_name
167
-  role_name 'admin'
168 166
   password stack_domain_admin_password
169 167
   connection_params connection_params
170 168
 end

+ 0
- 1
spec/identity_registration_spec.rb View File

@@ -66,7 +66,6 @@ describe 'openstack-orchestration::identity_registration' do
66 66
         service_user
67 67
       ).with(
68 68
         project_name: project_name,
69
-        role_name: role_name,
70 69
         password: password,
71 70
         connection_params: connection_params
72 71
       )

Loading…
Cancel
Save