From 7d83cde3b96839c018f33675a5b4fc405095ee22 Mon Sep 17 00:00:00 2001 From: Gerrit User 13252 <13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 18 Nov 2019 15:12:13 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: (3 comments) Patch-set: 2 Label: Verified=0 --- 0c072b88b959519504a59cfa672902d35fa4af7f | 21 +++++++++++++ fd3d9ceb621e5f82a8278cce23e623393a98c160 | 38 ++++++++++++++++++++++++ 2 files changed, 59 insertions(+) create mode 100644 0c072b88b959519504a59cfa672902d35fa4af7f create mode 100644 fd3d9ceb621e5f82a8278cce23e623393a98c160 diff --git a/0c072b88b959519504a59cfa672902d35fa4af7f b/0c072b88b959519504a59cfa672902d35fa4af7f new file mode 100644 index 0000000..dc8edf7 --- /dev/null +++ b/0c072b88b959519504a59cfa672902d35fa4af7f @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "key": { + "uuid": "3fa7e38b_ba90e74f", + "filename": "attributes/default.rb", + "patchSetId": 2 + }, + "lineNbr": 30, + "author": { + "id": 13252 + }, + "writtenOn": "2019-11-18T15:12:13Z", + "side": 1, + "message": "Wouldn\u0027t you drop \"telemetry\" from this loop completely, if that is defining the API endpoint?", + "revId": "0c072b88b959519504a59cfa672902d35fa4af7f", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file diff --git a/fd3d9ceb621e5f82a8278cce23e623393a98c160 b/fd3d9ceb621e5f82a8278cce23e623393a98c160 new file mode 100644 index 0000000..3fae02f --- /dev/null +++ b/fd3d9ceb621e5f82a8278cce23e623393a98c160 @@ -0,0 +1,38 @@ +{ + "comments": [ + { + "key": { + "uuid": "3fa7e38b_da93634d", + "filename": "attributes/ceilometer_conf.rb", + "patchSetId": 2 + }, + "lineNbr": 5, + "author": { + "id": 13252 + }, + "writtenOn": "2019-11-18T15:12:13Z", + "side": 0, + "message": "How is this related to dropping telemetry-api?", + "revId": "fd3d9ceb621e5f82a8278cce23e623393a98c160", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "3fa7e38b_7a6fcf5f", + "filename": "spec/gnocchi_install_spec.rb", + "patchSetId": 2 + }, + "lineNbr": 14, + "author": { + "id": 13252 + }, + "writtenOn": "2019-11-18T15:12:13Z", + "side": 0, + "message": "Hmm, gnocchi-api seems different from telemetry-api, why is this being dropped?", + "revId": "fd3d9ceb621e5f82a8278cce23e623393a98c160", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file