From 4841f1d721fede79582c86ee55468c8520e76c2f Mon Sep 17 00:00:00 2001 From: Gerrit User 34665 <34665@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Thu, 24 Aug 2023 12:04:19 +0000 Subject: [PATCH] Update patch set 6 Patch Set 6: (2 comments) Patch-set: 6 Attention: {"person_ident":"Gerrit User 34665 \u003c34665@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34665\u003e replied on the change"} --- 0b76cd8fb1a4ffbaa84caa446daa409af02ed634 | 48 ++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/0b76cd8fb1a4ffbaa84caa446daa409af02ed634 b/0b76cd8fb1a4ffbaa84caa446daa409af02ed634 index 959eacc5..7fe0d574 100644 --- a/0b76cd8fb1a4ffbaa84caa446daa409af02ed634 +++ b/0b76cd8fb1a4ffbaa84caa446daa409af02ed634 @@ -69,6 +69,30 @@ "revId": "0b76cd8fb1a4ffbaa84caa446daa409af02ed634", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": true, + "key": { + "uuid": "021d8859_c96dd04c", + "filename": "cyborg/common/placement_client.py", + "patchSetId": 5 + }, + "lineNbr": 158, + "author": { + "id": 34665 + }, + "writtenOn": "2023-08-24T12:04:19Z", + "side": 1, + "message": "when disable a device, we need update the reserved\u0027s value to total; the placment api from 1.26 support this.\n------\nStarting from microversion 1.26, this value has to be less than or equal to the value of total.\nhttps://docs.openstack.org/api-ref/placement/?expanded\u003dupdate-resource-provider-inventory-detail#update-resource-provider-inventory", + "parentUuid": "d4aaebd9_b221f78b", + "range": { + "startLine": 158, + "startChar": 37, + "endLine": 158, + "endChar": 53 + }, + "revId": "0b76cd8fb1a4ffbaa84caa446daa409af02ed634", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -91,6 +115,30 @@ }, "revId": "0b76cd8fb1a4ffbaa84caa446daa409af02ed634", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "9114d266_5bb48eb9", + "filename": "cyborg/common/policy.py", + "patchSetId": 5 + }, + "lineNbr": 52, + "author": { + "id": 34665 + }, + "writtenOn": "2023-08-24T12:04:19Z", + "side": 1, + "message": "according to the bp, we allow the admin user to disable/enable device only.\n-------\n404(the device is not found),403(the role is not admin)\n\nhttps://review.opendev.org/c/openstack/cyborg-specs/+/891310/5/specs/2023.2/approved/disable-enable-device.rst", + "parentUuid": "cbc0ed45_e52e4604", + "range": { + "startLine": 52, + "startChar": 0, + "endLine": 52, + "endChar": 40 + }, + "revId": "0b76cd8fb1a4ffbaa84caa446daa409af02ed634", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file