openstack/cyborg
Code Issues Proposed changes

Fix minor error in extarq job

Browse Source 
The patch fix the var need_job init value to False,
In some case, The None will cause some errors that
are not easy to be detected.

Change-Id: Ic4eac2fbc274fc5dfe9b2f4b796888b96bd78d0c
Story: 2007352
Task: 38932
This commit is contained in:
chenke 2020-03-04 21:22:16 +08:00
parent e9db6e8797
commit 4c4b732f4e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cyborg/objects/extarq/ext_arq_job.py
View File

@ -33,10 +33,10 @@ class ExtARQJobMixin(object):
def _bind_job(self, context, deployable):
"""The bind process of an acclerator."""
check_extra_job = getattr(self, "_need_extra_bind_job", None)
need_job = None
need_job = False
if check_extra_job:
need_job = check_extra_job(context, deployable)
if getattr(self.bind, "is_job", False) and need_job is not False:
if getattr(self.bind, "is_job", False) and need_job:
LOG.info("Start job for ARQ(%s) bind.", self.arq.uuid)
works = utils.ThreadWorks()
job = works.spawn(self.bind, context, deployable)
@ -228,7 +228,7 @@ class ExtARQJobMixin(object):
except ValueError:
raise exception.InvalidParameterValue(
'Resources nummber is a invalid in'
'device_profile_group: %s' % group)
' device_profile_group: %s' % group)
return res_type, res_num
@classmethod