openstack/deb-bandit
Code Issues Proposed changes

Allow precise #nosec placement

Browse Source 
allow #nosec in exactly the same place the error was reported rather than at the
beginning of a function call. For example the error is reported on the second
line of:

    Popen("foo *",
          shell=True)

so #nosec on the same line should be interpreted correctly.

The original behaviour of #nosec at the start of function call is still allowed
for backwards compatibility.

Plugins which check keyword arguments must explicitly pass the line of the
argument to the Issue constructor now.

Closes-bug: 1477739
Change-Id: I71f25e2920e0533649ad8dc65b9883559fc31311
This commit is contained in:
Stanisław Pitucha
2016-01-04 16:51:56 +11:00
parent c29fdccad9
commit c5e2eb9974
15 changed files with 88 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
bandit/core/manager.py
View File

@@ -248,7 +248,15 @@ class BanditManager():
lines = data.splitlines()
self.metrics.begin(fname)
self.metrics.count_locs(lines)
score = self._execute_ast_visitor(fname, data, lines)
if self.ignore_nosec:
nosec_lines = set()
else:
nosec_lines = set(
lineno + 1 for
(lineno, line) in enumerate(lines)
if b'#nosec' in line or b'# nosec' in line)
score = self._execute_ast_visitor(fname, data,
nosec_lines)
self.scores.append(score)
self.metrics.count_issues([score, ])
except KeyboardInterrupt as e:
@@ -271,7 +279,7 @@ class BanditManager():
# do final aggregation of metrics
self.metrics.aggregate()
def _execute_ast_visitor(self, fname, data, lines):
def _execute_ast_visitor(self, fname, data, nosec_lines):
'''Execute AST parse on each file
:param fname: The name of the file being parsed
@@ -282,9 +290,9 @@ class BanditManager():
score = []
res = b_node_visitor.BanditNodeVisitor(fname, self.b_conf, self.b_ma,
self.b_ts, self.debug,
self.ignore_nosec, self.metrics)
nosec_lines, self.metrics)
score = res.process(data, lines)
score = res.process(data)
self.results.extend(res.tester.results)
return score