d9faf1c204
This patch includes several separate sets of changes which have been reviewed individually but must be submitted together to get past the newly updated version of pep8 and changes to the nova code base. 1. Replace our CONF object with the one from openstack.common.cfg. There's no need to use our own, especially since some option are already registered on it for us. Signed-off-by: Julien Danjou <julien.danjou@enovance.com> 2. Instead of importing the RPC code from nova, use the openstack.common.rpc package. This change copies that code in from openstack-common, changes the imports throughout ceilometer, and fixes the way the configuration settings are initialized. 3. Resolve PEP-8 issues introduced by an even more pedantic version of pep8 (1.3.1). Some of the changes are fixed, and some warnings/errors are suppressed. 4. Ignore import errors in impl_qpid because the qpid package is not installed on the stackforge test server. 5. Fix missing imports from gettextutils in openstack.common. Change-Id: I0ee7d4b3278d8ff1951ca27592e3be8a87fe4854
65 lines
2.2 KiB
Python
65 lines
2.2 KiB
Python
#!/usr/bin/env python
|
|
# -*- encoding: utf-8 -*-
|
|
#
|
|
# Copyright © 2012 eNovance <licensing@enovance.com>
|
|
#
|
|
# Author: Julien Danjou <julien@danjou.info>
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import unittest
|
|
import logging
|
|
|
|
from ceilometer import log
|
|
from ceilometer.openstack.common import cfg
|
|
|
|
|
|
class LoggerTestCase(unittest.TestCase):
|
|
def setUp(self):
|
|
super(LoggerTestCase, self).setUp()
|
|
self.log = log.getLogger()
|
|
|
|
def test_log_level(self):
|
|
cfg.CONF.log_level = "info"
|
|
log.setup()
|
|
self.assertEqual(logging.INFO, self.log.getEffectiveLevel())
|
|
|
|
def test_child_log_level(self):
|
|
cfg.CONF.log_level = "info"
|
|
log.setup()
|
|
self.assertEqual(logging.INFO, log.getLogger('ceilometer.foobar').getEffectiveLevel())
|
|
|
|
|
|
class LogfilePathTestCase(unittest.TestCase):
|
|
def test_log_path_logdir(self):
|
|
cfg.CONF.log_dir = '/some/path'
|
|
cfg.CONF.log_file = None
|
|
self.assertEquals(log._get_log_file_path(binary='foo-bar'),
|
|
'/some/path/foo-bar.log')
|
|
|
|
def test_log_path_logfile(self):
|
|
cfg.CONF.log_file = '/some/path/foo-bar.log'
|
|
self.assertEquals(log._get_log_file_path(binary='foo-bar'),
|
|
'/some/path/foo-bar.log')
|
|
|
|
def test_log_path_none(self):
|
|
cfg.CONF.log_dir = None
|
|
cfg.CONF.log_file = None
|
|
self.assertTrue(log._get_log_file_path(binary='foo-bar') is None)
|
|
|
|
def test_log_path_logfile_overrides_logdir(self):
|
|
cfg.CONF.log_dir = '/some/other/path'
|
|
cfg.CONF.log_file = '/some/path/foo-bar.log'
|
|
self.assertEquals(log._get_log_file_path(binary='foo-bar'),
|
|
'/some/path/foo-bar.log')
|