openstack/deb-cinder
Code Issues Proposed changes

Re-enabled hacking checks for H105

Browse Source 
Following the upgrade to hacking version 0.10.0 the H105 issues were
ignored. There was a note left in tox.ini to clean up the H105 issues
and to re-enable the check.

Updated tox.ini to re-enable the check of H105 and fixed corresponding
pep8 issues. This way Cinder aligns rows with Nova, Neutron, Glance etc
that have H105 enabled.

Closes-Bug: 1531104
Change-Id: I2da70cbeb838f16ec8479284dda9d7c62566dace
This commit is contained in:
David Sariel 2016-01-05 10:37:42 +02:00
parent 7df01a599a
commit 01ad4ccebd
4 changed files with 1 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cinder/__init__.py
View File

@ -21,10 +21,4 @@
.. automodule:: cinder .. automodule:: cinder
:platform: Unix :platform: Unix
:synopsis: Infrastructure-as-a-Service Cloud platform. :synopsis: Infrastructure-as-a-Service Cloud platform.
.. moduleauthor:: Jesse Andrews <jesse@ansolabs.com>
.. moduleauthor:: Devin Carlen <devin.carlen@gmail.com>
.. moduleauthor:: Vishvananda Ishaya <vishvananda@gmail.com>
.. moduleauthor:: Joshua McKenty <joshua@cognition.ca>
.. moduleauthor:: Manish Singh <yosh@gimp.org>
.. moduleauthor:: Andy Smith <andy@anarkystic.com>
""" """

3
cinder/scheduler/__init__.py
View File

@ -19,7 +19,4 @@
.. automodule:: cinder.scheduler .. automodule:: cinder.scheduler
:platform: Unix :platform: Unix
:synopsis: Module that picks a volume node to create a volume. :synopsis: Module that picks a volume node to create a volume.
.. moduleauthor:: Sandy Walsh <sandy.walsh@rackspace.com>
.. moduleauthor:: Ed Leafe <ed@leafe.com>
.. moduleauthor:: Chris Behrens <cbehrens@codestud.com>
""" """

6
cinder/tests/unit/__init__.py
View File

@ -20,12 +20,6 @@
.. automodule:: cinder.tests.unit .. automodule:: cinder.tests.unit
:platform: Unix :platform: Unix
.. moduleauthor:: Jesse Andrews <jesse@ansolabs.com>
.. moduleauthor:: Devin Carlen <devin.carlen@gmail.com>
.. moduleauthor:: Vishvananda Ishaya <vishvananda@gmail.com>
.. moduleauthor:: Joshua McKenty <joshua@cognition.ca>
.. moduleauthor:: Manish Singh <yosh@gimp.org>
.. moduleauthor:: Andy Smith <andy@anarkystic.com>
""" """
import eventlet import eventlet

13
tox.ini
View File

@ -121,18 +121,7 @@ commands = bandit -c tools/bandit.yaml -r cinder -n 5 -ll
# #
# E251 unexpected spaces around keyword / parameter equals # E251 unexpected spaces around keyword / parameter equals
# reason: no improvement in readability # reason: no improvement in readability
# ignore = E251
# Due to the upgrade to hacking 0.9.2 the following checking are
# ignored on purpose for the moment and should be re-enabled.
#
# H405
# Due to the upgrade to hacking 0.10.0 the following checking are
# ignored on purpose for the moment and should be cleaned up and re-enabled.
#
# H105 Don't use author tags
#
ignore = E251,H105
exclude = .git,.venv,.tox,dist,tools,doc,common,*egg,build exclude = .git,.venv,.tox,dist,tools,doc,common,*egg,build
max-complexity=30 max-complexity=30