From 033284a419e4c6d550e253de2a88a50aaac4922e Mon Sep 17 00:00:00 2001 From: huananhuawei Date: Mon, 29 Aug 2016 19:29:04 +0800 Subject: [PATCH] Fix the password print in cinder-volume.log issue In cinder.conf replication_device may contains replication remote device password,and in cinder.volume.driver secret is not set 'true' for replication_device, So when start cinder volume service,replication remote device sensitive information will print in cinder volume log, it will cause some security problems. This commit fixes that by setting secret=true for replication_device in cinder.volume.driver. Change-Id: I710b557768ca3df0303d70b43b3c74247eed6b24 Closes-Bug: #1617534 --- cinder/volume/driver.py | 1 + 1 file changed, 1 insertion(+) diff --git a/cinder/volume/driver.py b/cinder/volume/driver.py index 5e6f37fd5..a154ae191 100644 --- a/cinder/volume/driver.py +++ b/cinder/volume/driver.py @@ -216,6 +216,7 @@ volume_opts = [ 'developers. Valid values are method and api.'), cfg.MultiOpt('replication_device', item_type=types.Dict(), + secret=True, help="Multi opt of dictionaries to represent a replication " "target device. This option may be specified multiple " "times in a single config section to specify multiple "