From 20d177db3747610d931666a7261d6fd92e91c5de Mon Sep 17 00:00:00 2001 From: Joe Gordon Date: Mon, 11 Nov 2013 11:28:18 -0800 Subject: [PATCH] Update URL for global HACKING document and remove duplicate section * Related to I579e7c889f3addc2cd40bce0c584bbc70bf435e2 * Remove section on locals since its already in global hacking doc (http://git.openstack.org/cgit/openstack-dev/hacking/tree/doc/source/index.rst#n154) Change-Id: I5acb06dfde6eb7f579d8d52bc31fafbdab8c726d --- HACKING.rst | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/HACKING.rst b/HACKING.rst index ca8dbf0f8..4c5a00de5 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -2,7 +2,7 @@ Cinder Style Commandments ========================= - Step 1: Read the OpenStack Style Commandments - https://github.com/openstack-dev/hacking/blob/master/doc/source/index.rst + http://docs.openstack.org/developer/hacking/ - Step 2: Read on Cinder Specific Commandments @@ -10,15 +10,6 @@ Cinder Specific Commandments General ------- -- Do not use locals(). Example:: - - LOG.debug(_("volume %(vol_name)s: creating size %(vol_size)sG") % - locals()) # BAD - - LOG.debug(_("volume %(vol_name)s: creating size %(vol_size)sG") % - {'vol_name': vol_name, - 'vol_size': vol_size}) # OKAY - - Use 'raise' instead of 'raise e' to preserve original traceback or exception being reraised:: except Exception as e: