From 505b8388d192e2659c8d2946a8eed606e03dad27 Mon Sep 17 00:00:00 2001 From: Cao ShuFeng Date: Sun, 19 Jun 2016 07:47:35 -0400 Subject: [PATCH] add FIXME tag for extra argument 'topic' in scheduler rpc api Some functions in scheduler rpc api receive unused argument 'topic'. We can't fix it now as we may interact with old services. It can only be fixed when we do a major version bump and drop the old compatibility. Now we add two FIXME tags in case we forget it one day. Change-Id: Iafd60bb51a2d7c8eab909d35f4b4de120a1172bb Partial-Bug: #1593149 --- cinder/scheduler/manager.py | 4 ++++ cinder/scheduler/rpcapi.py | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/cinder/scheduler/manager.py b/cinder/scheduler/manager.py index ab6487af0..86eec42b6 100644 --- a/cinder/scheduler/manager.py +++ b/cinder/scheduler/manager.py @@ -56,6 +56,10 @@ LOG = logging.getLogger(__name__) class SchedulerManager(manager.Manager): """Chooses a host to create volumes.""" + # FIXME(caosf): Remove unused argument 'topic' from functions + # create_consistencygroup(), create_volume(), migrate_volume_to_host(), + # retype() and manage_existing() in v3.0 of RPC API. + RPC_API_VERSION = '2.1' target = messaging.Target(version=RPC_API_VERSION) diff --git a/cinder/scheduler/rpcapi.py b/cinder/scheduler/rpcapi.py index 84365ecdd..35020b05a 100644 --- a/cinder/scheduler/rpcapi.py +++ b/cinder/scheduler/rpcapi.py @@ -59,6 +59,10 @@ class SchedulerAPI(rpc.RPCAPI): TOPIC = CONF.scheduler_topic BINARY = 'cinder-scheduler' + # FIXME(caosf): Remove unused argument 'topic' from functions + # create_consistencygroup(), create_volume(), migrate_volume_to_host(), + # retype() and manage_existing() in v3.0 of RPC API. + def create_consistencygroup(self, ctxt, topic, group, request_spec_list=None, filter_properties_list=None):