openstack/deb-cinder
Code Issues Proposed changes

Using oslo_config's min attribute

Browse Source 
"min=0" is now introduced in oslo_config, so no
need to check for negative integer in code for
"eqlx_cli_max_retries".

Change-Id: I4bbd188c0e7598ed4c41bae472abd2df83a7da9b
This commit is contained in:
gengchc2 2016-08-23 13:47:47 +08:00
parent ca9038628e
commit 70cf09484a
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cinder/volume/drivers/eqlx.py
View File

@ -51,6 +51,7 @@ eqlx_opts = [
'specified in cinder/volume/drivers/san/san.py '
'and will be removed in M release.'),
cfg.IntOpt('eqlx_cli_max_retries',
min=0,
default=5,
help='Maximum retry count for reconnection. Default is 5.'),
cfg.BoolOpt('eqlx_use_chap',
@ -295,10 +296,6 @@ class DellEQLSanISCSIDriver(san.SanISCSIDriver):
def check_for_setup_error(self):
super(DellEQLSanISCSIDriver, self).check_for_setup_error()
if self.configuration.eqlx_cli_max_retries < 0:
raise exception.InvalidInput(
reason=_("eqlx_cli_max_retries must be greater than or "
"equal to 0"))
def _eql_execute(self, *args, **kwargs):
return self._run_ssh(