openstack/deb-cinder
Code Issues Proposed changes

Fix messages in EMC VMAX driver with no translation

Browse Source 
There were a number of messages in the EMC VMAX driver
for LOG.info, LOG.error and LOG.warning that had no translation
marker on them.  This patch adds the appropriate _LI, _LE or _LW
marker so that the message will be translated.  Since there is
a separate effort to add in the log level markers going on I
did not attempt, in this patch, to address that issue.  Just
thought we should get translation on the messages that were missing it.

Change-Id: If6ac19369b303466afdec98589afa80ac46ad0f2
This commit is contained in:
Jay S. Bryant
2014-11-19 15:01:10 -06:00
parent c0fb19e96e
commit cc77eb2bda
3 changed files with 24 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
cinder/volume/drivers/emc/emc_vmax_fc.py
View File

@@ -15,6 +15,7 @@
import six
from cinder import context
from cinder.i18n import _LI
from cinder.openstack.common import log as logging
from cinder.volume import driver
from cinder.volume.drivers.emc import emc_vmax_common
@@ -182,7 +183,7 @@ class EMCVMAXFCDriver(driver.FibreChannelDriver):
loc = volume['provider_location']
name = eval(loc)
storage_system = name['keybindings']['SystemName']
LOG.info("Start FC detach process for volume: %(volume)s"
LOG.info(_LI("Start FC detach process for volume: %(volume)s")
% {'volume': volume['name']})
target_wwns, init_targ_map = self._build_initiator_target_map(
@@ -192,15 +193,15 @@ class EMCVMAXFCDriver(driver.FibreChannelDriver):
portGroupInstanceName = self.common.get_port_group_from_masking_view(
mvInstanceName)
LOG.info("Found port group: %(portGroup)s "
"in masking view %(maskingView)s"
% {'portGroup': portGroupInstanceName,
'maskingView': mvInstanceName})
LOG.info(_LI("Found port group: %(portGroup)s "
"in masking view %(maskingView)s"),
{'portGroup': portGroupInstanceName,
'maskingView': mvInstanceName})
self.common.terminate_connection(volume, connector)
LOG.info("Looking for masking views still associated with"
"Port Group %s" % portGroupInstanceName)
LOG.info(_LI("Looking for masking views still associated with"
"Port Group %s"), portGroupInstanceName)
mvInstances = self.common.get_masking_views_by_port_group(
portGroupInstanceName)
if len(mvInstances) > 0: