openstack/deb-cinder
Code Issues Proposed changes

Merge "Add unmanage default implementation to VolumeDriver"

Browse Source
This commit is contained in:
Jenkins 2015-09-10 06:06:06 +00:00 committed by Gerrit Code Review
commit ccd1692325
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cinder/tests/unit/test_volume.py
View File

@ -6769,6 +6769,12 @@ class LVMISCSIVolumeDriverTestCase(DriverTestCase):
self.volume.driver.manage_existing_snapshot_get_size,
snp, ref)
def test_lvm_unmanage(self):
volume = tests_utils.create_volume(self.context, status='available',
size=1, host=CONF.host)
ret = self.volume.driver.unmanage(volume)
self.assertEqual(ret, None)
class LVMVolumeDriverTestCase(DriverTestCase):
"""Test case for VolumeDriver"""

3
cinder/volume/driver.py
View File

@ -1964,8 +1964,7 @@ class VolumeDriver(ConsistencyGroupVD, TransferVD, ManageableVD, ExtendVD,
raise NotImplementedError(msg)
def unmanage(self, volume):
msg = _("Unmanage volume not implemented.")
raise NotImplementedError(msg)
pass
def manage_existing_snapshot(self, snapshot, existing_ref):
msg = _("Manage existing snapshot not implemented.")