openstack/deb-cinder
Code Issues Proposed changes

Retype issue in Kaminario Cinder drivers

Browse Source 
The value of volume.replication_status for a replicated volume is
'disabled' before 'failover-host' and it is changed to "failed-over"
after 'failover-host' command if active_backend_id is not equal to
secondary array IP. It is changed to 'enabled' after another
'failover-host' command if active_backend_id is equal to secondary
array IP(which is failback scenario).

After failback, if replication is removed from replicated volume,
then retype 'dedup without replication'<->'nodedup without replication'
with '--migration-policy on-demand' is not working since
value of volume.replication_status is enabled.

Change-Id: I193572532a36eaea5d826cff76ca9f98df86dc50
Closes-Bug: #1616329
Co-Authored-By: VenkataKrishna Reddy<Venkata.Krishna.ctr@kaminario.com>
Co-Authored-By: Lakshman<Lakshmi.Narayana.ctr@kaminario.com>
This commit is contained in:
Nikesh Mahalka 2016-08-24 05:39:07 -04:00
parent 4e92c272eb
commit ccf4884ea5
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/tests/unit/volume/drivers/test_kaminario.py
View File

@ -400,7 +400,7 @@ class TestKaminarioISCSI(test.TestCase):
backend_ip, res_volumes = self.driver.failover_host(None, volumes)
self.assertEqual('10.0.0.2', backend_ip)
status = res_volumes[0]['updates']['replication_status']
self.assertEqual(fields.ReplicationStatus.ENABLED, status)
self.assertEqual(fields.ReplicationStatus.DISABLED, status)
def test_delete_volume_replica(self):
"""Test _delete_volume_replica."""

2
cinder/volume/drivers/kaminario/kaminario_common.py
View File

@ -499,7 +499,7 @@ class KaminarioCinderDriver(cinder.volume.driver.ISCSIDriver):
src_ssn.save()
LOG.debug("The target session: %s state is "
"changed to in sync", session_name)
rep_status = fields.ReplicationStatus.ENABLED
rep_status = fields.ReplicationStatus.DISABLED
volume_updates.append({'volume_id': v['id'],
'updates':
{'replication_status': rep_status}})

6
releasenotes/notes/kaminario-cinder-driver-bug-1616329-c91bb4e747d14f3b.yaml Normal file
View File

@ -0,0 +1,6 @@
---
fixes:
- Fixed retyping 'dedup volume without replication' <->
'nodedup volume without replication' after replication failback and
removing replication for a replicated volume in Kaminario iSCSI and
FC Cinder Drivers.