From dfa050fac5d4a08dad519e1d680211db91d6d991 Mon Sep 17 00:00:00 2001 From: zhangyanxian Date: Thu, 1 Dec 2016 09:20:45 +0000 Subject: [PATCH] Set import exceptions in tox.ini configuration Instead of "from i18n import _ from i18n import _LE" this style "from i18n import _, _LE" is recommended as following: http://docs.openstack.org/developer/hacking/#real-world-import-order-examples but the pep8 failed: H301 one import per line so it needs to set import exceptions in tox.ini to avoid the problem Change-Id: I2de6cef388af65630dcba031a055f6757695006f --- designate/backend/agent.py | 3 +-- designate/objects/adapters/base.py | 3 +-- tox.ini | 1 + 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/designate/backend/agent.py b/designate/backend/agent.py index 39a1514e..cbdd7a49 100644 --- a/designate/backend/agent.py +++ b/designate/backend/agent.py @@ -36,8 +36,7 @@ import dns.opcode from oslo_config import cfg from oslo_log import log as logging -from designate.i18n import _LI -from designate.i18n import _LW +from designate.i18n import _LI, _LW from designate.backend import base from designate import exceptions from designate.mdns import rpcapi as mdns_api diff --git a/designate/objects/adapters/base.py b/designate/objects/adapters/base.py index 3745cf21..8a1c51a1 100644 --- a/designate/objects/adapters/base.py +++ b/designate/objects/adapters/base.py @@ -19,8 +19,7 @@ import six from designate import objects from designate import utils from designate import exceptions -from designate.i18n import _LE -from designate.i18n import _LI +from designate.i18n import _LE, _LI LOG = log.getLogger(__name__) diff --git a/tox.ini b/tox.ini index 533fa4ce..0365d7b3 100644 --- a/tox.ini +++ b/tox.ini @@ -131,3 +131,4 @@ exclude = .venv,.git,.tox,dist,doc,*lib/python*,*egg,build,tools,.ropeproject [hacking] local-check-factory = designate.hacking.checks.factory +import_exceptions = designate.i18n