39b233d3bd
This adds some unit tests to exercise the image cache middleware. Two new functions were also created in the cache middleware itself to make it more testable. Change-Id: Iea67119622461f1e8116b2a6913f94ca4eb22607
210 lines
7.3 KiB
Python
210 lines
7.3 KiB
Python
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
|
|
|
# Copyright 2011 OpenStack LLC.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""
|
|
Transparent image file caching middleware, designed to live on
|
|
Glance API nodes. When images are requested from the API node,
|
|
this middleware caches the returned image file to local filesystem.
|
|
|
|
When subsequent requests for the same image file are received,
|
|
the local cached copy of the image file is returned.
|
|
"""
|
|
|
|
import re
|
|
|
|
import webob
|
|
|
|
from glance.api.v1 import images
|
|
from glance.common import exception
|
|
from glance.common import utils
|
|
from glance.common import wsgi
|
|
import glance.db
|
|
from glance import image_cache
|
|
import glance.openstack.common.log as logging
|
|
from glance import registry
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
PATTERNS = {
|
|
('v1', 'GET'): re.compile(r'^/v1/images/([^\/]+)$'),
|
|
('v1', 'DELETE'): re.compile(r'^/v1/images/([^\/]+)$'),
|
|
('v2', 'GET'): re.compile(r'^/v2/images/([^\/]+)/file$'),
|
|
('v2', 'DELETE'): re.compile(r'^/v2/images/([^\/]+)$')
|
|
}
|
|
|
|
|
|
class CacheFilter(wsgi.Middleware):
|
|
|
|
def __init__(self, app):
|
|
self.cache = image_cache.ImageCache()
|
|
self.serializer = images.ImageSerializer()
|
|
LOG.info(_("Initialized image cache middleware"))
|
|
super(CacheFilter, self).__init__(app)
|
|
|
|
@staticmethod
|
|
def _match_request(request):
|
|
"""Determine the version of the url and extract the image id
|
|
|
|
:returns tuple of version and image id if the url is a cacheable,
|
|
otherwise None
|
|
"""
|
|
for ((version, method), pattern) in PATTERNS.items():
|
|
match = pattern.match(request.path_info)
|
|
try:
|
|
assert request.method == method
|
|
image_id = match.group(1)
|
|
# Ensure the image id we got looks like an image id to filter
|
|
# out a URI like /images/detail. See LP Bug #879136
|
|
assert image_id != 'detail'
|
|
except (AttributeError, AssertionError):
|
|
continue
|
|
else:
|
|
return (version, method, image_id)
|
|
|
|
def process_request(self, request):
|
|
"""
|
|
For requests for an image file, we check the local image
|
|
cache. If present, we return the image file, appending
|
|
the image metadata in headers. If not present, we pass
|
|
the request on to the next application in the pipeline.
|
|
"""
|
|
match = self._match_request(request)
|
|
try:
|
|
(version, method, image_id) = match
|
|
except TypeError:
|
|
# Trying to unpack None raises this exception
|
|
return None
|
|
|
|
self._stash_request_info(request, image_id, method)
|
|
|
|
if request.method != 'GET' or not self.cache.is_cached(image_id):
|
|
return None
|
|
|
|
LOG.debug(_("Cache hit for image '%s'"), image_id)
|
|
image_iterator = self.get_from_cache(image_id)
|
|
method = getattr(self, '_process_%s_request' % version)
|
|
|
|
try:
|
|
return method(request, image_id, image_iterator)
|
|
except exception.NotFound:
|
|
msg = _("Image cache contained image file for image '%s', "
|
|
"however the registry did not contain metadata for "
|
|
"that image!" % image_id)
|
|
LOG.error(msg)
|
|
|
|
@staticmethod
|
|
def _stash_request_info(request, image_id, method):
|
|
"""
|
|
Preserve the image id and request method for later retrieval
|
|
"""
|
|
request.environ['api.cache.image_id'] = image_id
|
|
request.environ['api.cache.method'] = method
|
|
|
|
@staticmethod
|
|
def _fetch_request_info(request):
|
|
"""
|
|
Preserve the cached image id for consumption by the
|
|
process_response method of this middleware
|
|
"""
|
|
try:
|
|
image_id = request.environ['api.cache.image_id']
|
|
method = request.environ['api.cache.method']
|
|
except KeyError:
|
|
return None
|
|
else:
|
|
return (image_id, method)
|
|
|
|
def _process_v1_request(self, request, image_id, image_iterator):
|
|
image_meta = registry.get_image_metadata(request.context, image_id)
|
|
|
|
if not image_meta['size']:
|
|
# override image size metadata with the actual cached
|
|
# file size, see LP Bug #900959
|
|
image_meta['size'] = self.cache.get_image_size(image_id)
|
|
|
|
response = webob.Response(request=request)
|
|
raw_response = {
|
|
'image_iterator': image_iterator,
|
|
'image_meta': image_meta,
|
|
}
|
|
return self.serializer.show(response, raw_response)
|
|
|
|
def _process_v2_request(self, request, image_id, image_iterator):
|
|
response = webob.Response(request=request)
|
|
response.app_iter = image_iterator
|
|
return response
|
|
|
|
def process_response(self, resp):
|
|
"""
|
|
We intercept the response coming back from the main
|
|
images Resource, removing image file from the cache
|
|
if necessary
|
|
"""
|
|
if not 200 <= self.get_status_code(resp) < 300:
|
|
return resp
|
|
|
|
try:
|
|
(image_id, method) = self._fetch_request_info(resp.request)
|
|
except TypeError:
|
|
return resp
|
|
|
|
method_str = '_process_%s_response' % method
|
|
try:
|
|
process_response_method = getattr(self, method_str)
|
|
except AttributeError:
|
|
LOG.error('could not find %s' % method_str)
|
|
# Nothing to do here, move along
|
|
return resp
|
|
else:
|
|
return process_response_method(resp, image_id)
|
|
|
|
def _process_DELETE_response(self, resp, image_id):
|
|
if self.cache.is_cached(image_id):
|
|
LOG.debug(_("Removing image %s from cache"), image_id)
|
|
self.cache.delete_cached_image(image_id)
|
|
return resp
|
|
|
|
def _process_GET_response(self, resp, image_id):
|
|
image_checksum = resp.headers.get('Content-MD5', None)
|
|
|
|
if not image_checksum:
|
|
# API V1 stores the checksum in a different header:
|
|
image_checksum = resp.headers.get('x-image-meta-checksum', None)
|
|
|
|
if not image_checksum:
|
|
LOG.error(_("Checksum header is missing."))
|
|
|
|
resp.app_iter = self.cache.get_caching_iter(image_id, image_checksum,
|
|
resp.app_iter)
|
|
return resp
|
|
|
|
def get_status_code(self, response):
|
|
"""
|
|
Returns the integer status code from the response, which
|
|
can be either a Webob.Response (used in testing) or httplib.Response
|
|
"""
|
|
if hasattr(response, 'status_int'):
|
|
return response.status_int
|
|
return response.status
|
|
|
|
def get_from_cache(self, image_id):
|
|
"""Called if cache hit"""
|
|
with self.cache.open_for_read(image_id) as cache_file:
|
|
chunks = utils.chunkiter(cache_file)
|
|
for chunk in chunks:
|
|
yield chunk
|