deb-glance/glance/tests/functional/db/test_rpc_endpoint.py
Gábor Antal 8a8e5bf56c Extracted HTTP response codes to constants in tests
There are several places in the source code where
HTTP response codes are used as numeric values.

These values are used from six.moves and the
numeric values are replaced by constants.

All of the used status codes were replaced with symbolic constants
from six.moves.http_client.
More about six.moves.http_client can be found at [2],
under the table "Supported renames:".

Also, this change improves code readibility.

This patchset does not extract numeric values from
the code itself, but it can be found at [1].

[1]: Ib9e26dcea927e96e65c626c18421621d3a29a64d
[2]: https://pythonhosted.org/six/#module-six.moves

Change-Id: Idfc7b043552f428f01ac3e47b270ee0639a8f5bc
Closes-Bug: #1520159
2016-10-06 15:17:06 +00:00

57 lines
2.0 KiB
Python

# Copyright 2014 Hewlett-Packard Development Company, L.P.
# All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from oslo_serialization import jsonutils
import requests
from six.moves import http_client as http
from glance.tests import functional
class TestRegistryURLVisibility(functional.FunctionalTest):
def setUp(self):
super(TestRegistryURLVisibility, self).setUp()
self.cleanup()
self.registry_server.deployment_flavor = ''
self.req_body = jsonutils.dumps([{"command": "image_get_all"}])
def _url(self, path):
return 'http://127.0.0.1:%d%s' % (self.registry_port, path)
def _headers(self, custom_headers=None):
base_headers = {
}
base_headers.update(custom_headers or {})
return base_headers
def test_v2_not_enabled(self):
self.registry_server.enable_v2_registry = False
self.start_servers(**self.__dict__.copy())
path = self._url('/rpc')
response = requests.post(path, headers=self._headers(),
data=self.req_body)
self.assertEqual(http.NOT_FOUND, response.status_code)
self.stop_servers()
def test_v2_enabled(self):
self.registry_server.enable_v2_registry = True
self.start_servers(**self.__dict__.copy())
path = self._url('/rpc')
response = requests.post(path, headers=self._headers(),
data=self.req_body)
self.assertEqual(http.OK, response.status_code)
self.stop_servers()