openstack/deb-heat
Code Issues Proposed changes

Remove return for rpc casts in rpc worker client

Browse Source 
RPC casts never return anything, only RPC calls do,
so remove the misleading return in the worker client.

Change-Id: I82e2ead0b350be42f808f6cb6b9b57b786aeadcf
This commit is contained in:
Sirushti Murugesan 2015-03-24 20:25:11 +05:30
parent 848d63b398
commit 8e5c35d897
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
heat/rpc/worker_client.py
View File

@ -46,4 +46,4 @@ class WorkerClient(object):
client = self._client.prepare(version=version) client = self._client.prepare(version=version)
else: else:
client = self._client client = self._client
return client.cast(ctxt, method, **kwargs) client.cast(ctxt, method, **kwargs)

6
heat/tests/test_rpc_worker_client.py
View File

@ -58,14 +58,16 @@ class WorkerClientTest(common.HeatTestCase):
msg = method, kwargs msg = method, kwargs
# go with default version # go with default version
worker_client.cast(mock_cnxt, msg) return_value = worker_client.cast(mock_cnxt, msg)
self.assertIsNone(return_value)
mock_rpc_client.cast.assert_called_once_with(mock_cnxt, mock_rpc_client.cast.assert_called_once_with(mock_cnxt,
method, method,
**kwargs) **kwargs)
# Check cast in given version # Check cast in given version
version = '1.2' version = '1.2'
worker_client.cast(mock_cnxt, msg, version) return_value = worker_client.cast(mock_cnxt, msg, version)
self.assertIsNone(return_value)
mock_rpc_client.prepare.assert_called_once_with(version=version) mock_rpc_client.prepare.assert_called_once_with(version=version)
mock_rpc_client.cast.assert_called_once_with(mock_cnxt, mock_rpc_client.cast.assert_called_once_with(mock_cnxt,
method, method,