openstack/deb-heat
Code Issues Proposed changes

Increase timeout of WaitCondition due to ConcurrentTransactions

Browse Source 
Currently we have retry logic with random period of delay.
There is a chance, when we have several re-try attemts with maximum
timeout, so it can be a root cause of floating fails, when we have not
enough time for getting all signals.

Also decrease number of signals from 30 to 25, due to small risk, when
one of signals goes to ConcurrentTransaction error.

Note, that all these changes are made in corresponding functional test
and don't affect main code.

Change-Id: I9ca85c4378d0f62e316f4f40ff73597ffaaabadf
Related-Bug: #1497274
This commit is contained in:
Sergey Kraynev 2016-03-24 04:30:39 -04:00
parent 18a1f5a5e1
commit 8f370d6174
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
heat_integrationtests/functional/test_os_wait_condition.py
View File

@ -61,9 +61,9 @@ resources:
wc_notify --data-binary ''{"status": "SUCCESS", "id": "5"}''
# loop for 25 signals without reasons and data
# loop for 20 signals without reasons and data
for i in `seq 1 25`; do wc_notify --data-binary ''{"status":
for i in `seq 1 20`; do wc_notify --data-binary ''{"status":
"SUCCESS"}'' & done
wait
@ -76,7 +76,7 @@ resources:
type: OS::Heat::WaitCondition
depends_on: instance1
properties:
count: 30
count: 25
handle: {get_resource: wait_handle}
timeout: {get_param: timeout}
@ -102,5 +102,6 @@ outputs:
def test_create_stack_with_multi_signal_waitcondition(self):
params = {'flavor': self.conf.minimal_instance_type,
'image': self.conf.minimal_image_ref,
'network': self.conf.fixed_network_name}
'network': self.conf.fixed_network_name,
'timeout': 120}
self.stack_create(template=self.template, parameters=params)