ac2844f8bf
Change-Id: I5017bcca71b626e424b5df6d4433a5ca7b75ebc6 Implements: blueprint reorganize-resources-code-structure
376 lines
15 KiB
Python
376 lines
15 KiB
Python
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import copy
|
|
|
|
import mock
|
|
import six
|
|
|
|
from heat.common import exception
|
|
from heat.common import grouputils
|
|
from heat.common import template_format
|
|
from heat.engine import resource
|
|
from heat.engine.resources.openstack.heat import instance_group as instgrp
|
|
from heat.engine import rsrc_defn
|
|
from heat.engine import scheduler
|
|
from heat.engine import stack as parser
|
|
from heat.tests.autoscaling import inline_templates
|
|
from heat.tests import common
|
|
from heat.tests import generic_resource
|
|
from heat.tests import utils
|
|
|
|
|
|
class TestInstanceGroup(common.HeatTestCase):
|
|
def setUp(self):
|
|
super(TestInstanceGroup, self).setUp()
|
|
t = template_format.parse(inline_templates.as_template)
|
|
stack = utils.parse_stack(t, params=inline_templates.as_params)
|
|
self.defn = rsrc_defn.ResourceDefinition(
|
|
'asg', 'OS::Heat::InstanceGroup',
|
|
{'Size': 2, 'AvailabilityZones': ['zoneb'],
|
|
'LaunchConfigurationName': 'config'})
|
|
self.instance_group = instgrp.InstanceGroup('asg',
|
|
self.defn, stack)
|
|
|
|
def test_child_template(self):
|
|
self.instance_group._create_template = mock.Mock(return_value='tpl')
|
|
self.assertEqual('tpl', self.instance_group.child_template())
|
|
self.instance_group._create_template.assert_called_once_with(2)
|
|
|
|
def test_child_params(self):
|
|
expected = {'parameters': {},
|
|
'resource_registry': {
|
|
'OS::Heat::ScaledResource': 'AWS::EC2::Instance'}}
|
|
self.assertEqual(expected, self.instance_group.child_params())
|
|
|
|
def test_tags_default(self):
|
|
expected = [{'Value': u'asg',
|
|
'Key': 'metering.groupname'}]
|
|
self.assertEqual(expected, self.instance_group._tags())
|
|
|
|
def test_tags_with_extra(self):
|
|
self.instance_group.properties.data['Tags'] = [
|
|
{'Key': 'fee', 'Value': 'foo'}]
|
|
expected = [{'Key': 'fee', 'Value': 'foo'},
|
|
{'Value': u'asg',
|
|
'Key': 'metering.groupname'}]
|
|
self.assertEqual(expected, self.instance_group._tags())
|
|
|
|
def test_tags_with_metering(self):
|
|
self.instance_group.properties.data['Tags'] = [
|
|
{'Key': 'metering.fee', 'Value': 'foo'}]
|
|
expected = [{'Key': 'metering.fee', 'Value': 'foo'}]
|
|
self.assertEqual(expected, self.instance_group._tags())
|
|
|
|
def test_validate_launch_conf(self):
|
|
props = self.instance_group.properties.data
|
|
props['LaunchConfigurationName'] = 'urg_i_cant_spell'
|
|
creator = scheduler.TaskRunner(self.instance_group.create)
|
|
error = self.assertRaises(exception.ResourceFailure, creator)
|
|
|
|
self.assertIn('(urg_i_cant_spell) reference can not be found.',
|
|
six.text_type(error))
|
|
|
|
def test_validate_launch_conf_no_ref(self):
|
|
props = self.instance_group.properties.data
|
|
props['LaunchConfigurationName'] = 'JobServerConfig'
|
|
creator = scheduler.TaskRunner(self.instance_group.create)
|
|
error = self.assertRaises(exception.ResourceFailure, creator)
|
|
self.assertIn('(JobServerConfig) reference can not be',
|
|
six.text_type(error))
|
|
|
|
def test_handle_create(self):
|
|
self.instance_group.create_with_template = mock.Mock(return_value=None)
|
|
self.instance_group.validate_launchconfig = mock.Mock(
|
|
return_value=None)
|
|
self.instance_group._create_template = mock.Mock(return_value='{}')
|
|
|
|
self.instance_group.handle_create()
|
|
|
|
self.instance_group.validate_launchconfig.assert_called_once_with()
|
|
self.instance_group._create_template.assert_called_once_with(2)
|
|
self.instance_group.create_with_template.assert_called_once_with('{}')
|
|
|
|
def test_update_in_failed(self):
|
|
self.instance_group.state_set('CREATE', 'FAILED')
|
|
# to update the failed instance_group
|
|
self.instance_group.resize = mock.Mock(return_value=None)
|
|
|
|
self.instance_group.handle_update(self.defn, None, None)
|
|
self.instance_group.resize.assert_called_once_with(2)
|
|
|
|
def test_handle_delete(self):
|
|
self.instance_group.delete_nested = mock.Mock(return_value=None)
|
|
self.instance_group.handle_delete()
|
|
self.instance_group.delete_nested.assert_called_once_with()
|
|
|
|
def test_handle_update_size(self):
|
|
self.instance_group._try_rolling_update = mock.Mock(return_value=None)
|
|
self.instance_group.resize = mock.Mock(return_value=None)
|
|
|
|
props = {'Size': 5}
|
|
defn = rsrc_defn.ResourceDefinition(
|
|
'nopayload',
|
|
'AWS::AutoScaling::AutoScalingGroup',
|
|
props)
|
|
|
|
self.instance_group.handle_update(defn, None, props)
|
|
self.instance_group.resize.assert_called_once_with(5)
|
|
|
|
def test_attributes(self):
|
|
mock_members = self.patchobject(grouputils, 'get_members')
|
|
instances = []
|
|
for ip_ex in six.moves.range(1, 4):
|
|
inst = mock.Mock()
|
|
inst.FnGetAtt.return_value = '2.1.3.%d' % ip_ex
|
|
instances.append(inst)
|
|
mock_members.return_value = instances
|
|
res = self.instance_group._resolve_attribute('InstanceList')
|
|
self.assertEqual('2.1.3.1,2.1.3.2,2.1.3.3', res)
|
|
|
|
|
|
class TestLaunchConfig(common.HeatTestCase):
|
|
def create_resource(self, t, stack, resource_name):
|
|
# subsequent resources may need to reference previous created resources
|
|
# use the stack's resource objects instead of instantiating new ones
|
|
rsrc = stack[resource_name]
|
|
self.assertIsNone(rsrc.validate())
|
|
scheduler.TaskRunner(rsrc.create)()
|
|
self.assertEqual((rsrc.CREATE, rsrc.COMPLETE), rsrc.state)
|
|
return rsrc
|
|
|
|
def test_update_metadata_replace(self):
|
|
"""Updating the config's metadata causes a config replacement."""
|
|
lc_template = '''
|
|
{
|
|
"AWSTemplateFormatVersion" : "2010-09-09",
|
|
"Resources": {
|
|
"JobServerConfig" : {
|
|
"Type" : "AWS::AutoScaling::LaunchConfiguration",
|
|
"Metadata": {"foo": "bar"},
|
|
"Properties": {
|
|
"ImageId" : "foo",
|
|
"InstanceType" : "m1.large",
|
|
"KeyName" : "test",
|
|
}
|
|
}
|
|
}
|
|
}
|
|
'''
|
|
self.stub_ImageConstraint_validate()
|
|
self.stub_FlavorConstraint_validate()
|
|
self.stub_KeypairConstraint_validate()
|
|
|
|
t = template_format.parse(lc_template)
|
|
stack = utils.parse_stack(t)
|
|
rsrc = self.create_resource(t, stack, 'JobServerConfig')
|
|
props = copy.copy(rsrc.properties.data)
|
|
metadata = copy.copy(rsrc.metadata_get())
|
|
update_snippet = rsrc_defn.ResourceDefinition(rsrc.name,
|
|
rsrc.type(),
|
|
props,
|
|
metadata)
|
|
# Change nothing in the first update
|
|
scheduler.TaskRunner(rsrc.update, update_snippet)()
|
|
self.assertEqual('bar', metadata['foo'])
|
|
metadata['foo'] = 'wibble'
|
|
update_snippet = rsrc_defn.ResourceDefinition(rsrc.name,
|
|
rsrc.type(),
|
|
props,
|
|
metadata)
|
|
# Changing metadata in the second update triggers UpdateReplace
|
|
updater = scheduler.TaskRunner(rsrc.update, update_snippet)
|
|
self.assertRaises(resource.UpdateReplace, updater)
|
|
|
|
|
|
class LoadbalancerReloadTest(common.HeatTestCase):
|
|
def test_Instances(self):
|
|
t = template_format.parse(inline_templates.as_template)
|
|
stack = utils.parse_stack(t)
|
|
lb = stack['ElasticLoadBalancer']
|
|
lb.update = mock.Mock(return_value=None)
|
|
|
|
defn = rsrc_defn.ResourceDefinition(
|
|
'asg', 'OS::Heat::InstanceGroup',
|
|
{'Size': 2,
|
|
'AvailabilityZones': ['zoneb'],
|
|
"LaunchConfigurationName": "LaunchConfig",
|
|
"LoadBalancerNames": ["ElasticLoadBalancer"]})
|
|
group = instgrp.InstanceGroup('asg', defn, stack)
|
|
|
|
mock_members = self.patchobject(grouputils, 'get_member_refids')
|
|
mock_members.return_value = ['aaaa', 'bbb']
|
|
expected = rsrc_defn.ResourceDefinition(
|
|
'ElasticLoadBalancer',
|
|
'AWS::ElasticLoadBalancing::LoadBalancer',
|
|
{'Instances': ['aaaa', 'bbb'],
|
|
'Listeners': [{'InstancePort': u'80',
|
|
'LoadBalancerPort': u'80',
|
|
'Protocol': 'HTTP'}],
|
|
'AvailabilityZones': ['nova']})
|
|
|
|
group._lb_reload()
|
|
mock_members.assert_called_once_with(group, exclude=[])
|
|
lb.update.assert_called_once_with(expected)
|
|
|
|
def test_members(self):
|
|
t = template_format.parse(inline_templates.as_template)
|
|
t['Resources']['ElasticLoadBalancer'] = {
|
|
'Type': 'OS::Neutron::LoadBalancer',
|
|
'Properties': {
|
|
'protocol_port': 8080,
|
|
}
|
|
}
|
|
stack = utils.parse_stack(t)
|
|
|
|
lb = stack['ElasticLoadBalancer']
|
|
lb.update = mock.Mock(return_value=None)
|
|
|
|
defn = rsrc_defn.ResourceDefinition(
|
|
'asg', 'OS::Heat::InstanceGroup',
|
|
{'Size': 2,
|
|
'AvailabilityZones': ['zoneb'],
|
|
"LaunchConfigurationName": "LaunchConfig",
|
|
"LoadBalancerNames": ["ElasticLoadBalancer"]})
|
|
group = instgrp.InstanceGroup('asg', defn, stack)
|
|
|
|
mock_members = self.patchobject(grouputils, 'get_member_refids')
|
|
mock_members.return_value = ['aaaa', 'bbb']
|
|
expected = rsrc_defn.ResourceDefinition(
|
|
'ElasticLoadBalancer',
|
|
'OS::Neutron::LoadBalancer',
|
|
{'protocol_port': 8080,
|
|
'members': ['aaaa', 'bbb']})
|
|
|
|
group._lb_reload()
|
|
mock_members.assert_called_once_with(group, exclude=[])
|
|
lb.update.assert_called_once_with(expected)
|
|
|
|
def test_lb_reload_invalid_resource(self):
|
|
t = template_format.parse(inline_templates.as_template)
|
|
t['Resources']['ElasticLoadBalancer'] = {
|
|
'Type': 'AWS::EC2::Volume',
|
|
'Properties': {
|
|
'AvailabilityZone': 'nova'
|
|
}
|
|
}
|
|
stack = utils.parse_stack(t)
|
|
|
|
lb = stack['ElasticLoadBalancer']
|
|
lb.update = mock.Mock(return_value=None)
|
|
|
|
defn = rsrc_defn.ResourceDefinition(
|
|
'asg', 'OS::Heat::InstanceGroup',
|
|
{'Size': 2,
|
|
'AvailabilityZones': ['zoneb'],
|
|
"LaunchConfigurationName": "LaunchConfig",
|
|
"LoadBalancerNames": ["ElasticLoadBalancer"]})
|
|
group = instgrp.InstanceGroup('asg', defn, stack)
|
|
|
|
mock_members = self.patchobject(grouputils, 'get_member_refids')
|
|
mock_members.return_value = ['aaaa', 'bbb']
|
|
|
|
error = self.assertRaises(exception.Error,
|
|
group._lb_reload)
|
|
self.assertEqual(
|
|
"Unsupported resource 'ElasticLoadBalancer' in "
|
|
"LoadBalancerNames",
|
|
six.text_type(error))
|
|
|
|
def test_lb_reload_static_resolve(self):
|
|
t = template_format.parse(inline_templates.as_template)
|
|
properties = t['Resources']['ElasticLoadBalancer']['Properties']
|
|
properties['AvailabilityZones'] = {'Fn::GetAZs': ''}
|
|
|
|
self.patchobject(parser.Stack, 'get_availability_zones',
|
|
return_value=['abc', 'xyz'])
|
|
|
|
mock_members = self.patchobject(grouputils, 'get_member_refids')
|
|
mock_members.return_value = ['aaaabbbbcccc']
|
|
|
|
# Check that the Fn::GetAZs is correctly resolved
|
|
expected = {u'Properties': {'Instances': ['aaaabbbbcccc'],
|
|
u'Listeners': [{u'InstancePort': u'80',
|
|
u'LoadBalancerPort': u'80',
|
|
u'Protocol': u'HTTP'}],
|
|
u'AvailabilityZones': ['abc', 'xyz']}}
|
|
|
|
stack = utils.parse_stack(t, params=inline_templates.as_params)
|
|
lb = stack['ElasticLoadBalancer']
|
|
lb.handle_update = mock.Mock(return_value=None)
|
|
group = stack['WebServerGroup']
|
|
group._lb_reload()
|
|
lb.handle_update.assert_called_once_with(
|
|
mock.ANY, expected,
|
|
{'Instances': ['aaaabbbbcccc']})
|
|
|
|
|
|
class ReplaceTest(common.HeatTestCase):
|
|
scenarios = [
|
|
('1', dict(min_in_service=0, batch_size=1, updates=2)),
|
|
('2', dict(min_in_service=0, batch_size=2, updates=1)),
|
|
('3', dict(min_in_service=3, batch_size=1, updates=3)),
|
|
('4', dict(min_in_service=3, batch_size=2, updates=2))]
|
|
|
|
def setUp(self):
|
|
super(ReplaceTest, self).setUp()
|
|
resource._register_class('ResourceWithPropsAndAttrs',
|
|
generic_resource.ResourceWithPropsAndAttrs)
|
|
t = template_format.parse(inline_templates.as_template)
|
|
stack = utils.parse_stack(t, params=inline_templates.as_params)
|
|
lc = self.create_launch_config(t, stack)
|
|
lcid = lc.FnGetRefId()
|
|
self.defn = rsrc_defn.ResourceDefinition(
|
|
'asg', 'OS::Heat::InstanceGroup',
|
|
{'Size': 2, 'AvailabilityZones': ['zoneb'],
|
|
'LaunchConfigurationName': lcid})
|
|
self.group = instgrp.InstanceGroup('asg', self.defn, stack)
|
|
|
|
self.group._lb_reload = mock.Mock()
|
|
self.group.update_with_template = mock.Mock()
|
|
self.group.check_update_complete = mock.Mock()
|
|
self.group._nested = self.get_fake_nested_stack()
|
|
|
|
def create_launch_config(self, t, stack):
|
|
self.stub_ImageConstraint_validate()
|
|
self.stub_FlavorConstraint_validate()
|
|
self.stub_SnapshotConstraint_validate()
|
|
rsrc = stack['LaunchConfig']
|
|
self.assertIsNone(rsrc.validate())
|
|
scheduler.TaskRunner(rsrc.create)()
|
|
self.assertEqual((rsrc.CREATE, rsrc.COMPLETE), rsrc.state)
|
|
return rsrc
|
|
|
|
def get_fake_nested_stack(self):
|
|
nested_t = '''
|
|
heat_template_version: 2013-05-23
|
|
description: AutoScaling Test
|
|
resources:
|
|
one:
|
|
type: ResourceWithPropsAndAttrs
|
|
properties:
|
|
Foo: hello
|
|
two:
|
|
type: ResourceWithPropsAndAttrs
|
|
properties:
|
|
Foo: fee
|
|
'''
|
|
return utils.parse_stack(template_format.parse(nested_t))
|
|
|
|
def test_rolling_updates(self):
|
|
self.group._replace(self.min_in_service, self.batch_size, 0)
|
|
self.assertEqual(self.updates,
|
|
len(self.group.update_with_template.call_args_list))
|
|
self.assertEqual(self.updates + 1,
|
|
len(self.group._lb_reload.call_args_list))
|