157a11550f
This patch adds a utility function for checking the int type parameters passed to the API layer. A test case is included for this utility function. To exemplify how to use it, the events controller is revised to make use of this function. The plan is to add this checking to all int type parameters at API layer. Change-Id: If4a1e2e5e7adbc272e2cfa5b1918cdf733926013
91 lines
4.1 KiB
Python
91 lines
4.1 KiB
Python
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from heat.common import param_utils
|
|
from heat.tests import common
|
|
|
|
|
|
class TestExtractBool(common.HeatTestCase):
|
|
def test_extract_bool(self):
|
|
for value in ('True', 'true', 'TRUE', True):
|
|
self.assertTrue(param_utils.extract_bool(value))
|
|
for value in ('False', 'false', 'FALSE', False):
|
|
self.assertFalse(param_utils.extract_bool(value))
|
|
for value in ('foo', 't', 'f', 'yes', 'no', 'y', 'n', '1', '0', None):
|
|
self.assertRaises(ValueError, param_utils.extract_bool, value)
|
|
|
|
|
|
class TestExtractInt(common.HeatTestCase):
|
|
def test_extract_int(self):
|
|
# None case
|
|
self.assertIsNone(param_utils.extract_int('num', None))
|
|
|
|
# 0 case
|
|
self.assertEqual(0, param_utils.extract_int('num', 0))
|
|
self.assertEqual(0, param_utils.extract_int('num', 0, allow_zero=True))
|
|
self.assertEqual(0, param_utils.extract_int('num', '0'))
|
|
self.assertEqual(0, param_utils.extract_int('num', '0',
|
|
allow_zero=True))
|
|
self.assertRaises(ValueError,
|
|
param_utils.extract_int,
|
|
'num', 0, allow_zero=False)
|
|
self.assertRaises(ValueError,
|
|
param_utils.extract_int,
|
|
'num', '0', allow_zero=False)
|
|
|
|
# positive values
|
|
self.assertEqual(1, param_utils.extract_int('num', 1))
|
|
self.assertEqual(1, param_utils.extract_int('num', '1'))
|
|
self.assertRaises(ValueError, param_utils.extract_int, 'num', '1.1')
|
|
self.assertRaises(ValueError, param_utils.extract_int, 'num', 1.1)
|
|
|
|
# negative values
|
|
self.assertEqual(-1, param_utils.extract_int('num', -1,
|
|
allow_negative=True))
|
|
self.assertEqual(-1, param_utils.extract_int('num', '-1',
|
|
allow_negative=True))
|
|
self.assertRaises(ValueError,
|
|
param_utils.extract_int, 'num', '-1.1',
|
|
allow_negative=True)
|
|
self.assertRaises(ValueError,
|
|
param_utils.extract_int, 'num', -1.1,
|
|
allow_negative=True)
|
|
|
|
self.assertRaises(ValueError, param_utils.extract_int, 'num', -1)
|
|
self.assertRaises(ValueError, param_utils.extract_int, 'num', '-1')
|
|
self.assertRaises(ValueError, param_utils.extract_int, 'num', '-1.1')
|
|
self.assertRaises(ValueError, param_utils.extract_int, 'num', -1.1)
|
|
|
|
self.assertRaises(ValueError,
|
|
param_utils.extract_int, 'num', -1,
|
|
allow_negative=False)
|
|
self.assertRaises(ValueError,
|
|
param_utils.extract_int, 'num', '-1',
|
|
allow_negative=False)
|
|
self.assertRaises(ValueError,
|
|
param_utils.extract_int, 'num', '-1.1',
|
|
allow_negative=False)
|
|
self.assertRaises(ValueError,
|
|
param_utils.extract_int, 'num', -1.1,
|
|
allow_negative=False)
|
|
|
|
# Non-int value
|
|
self.assertRaises(ValueError,
|
|
param_utils.extract_int, 'num', 'abc')
|
|
self.assertRaises(ValueError,
|
|
param_utils.extract_int, 'num', '')
|
|
self.assertRaises(ValueError,
|
|
param_utils.extract_int, 'num', 'true')
|
|
self.assertRaises(ValueError,
|
|
param_utils.extract_int, 'num', True)
|