Remove #noqa from most common imports and add them to import_exceptions

We have a lot of import with #noqa that is there to ignore h302,
because it's traditional to import and use a name directly, instead
of a whole module. This hides other errors and gives people the
impression that it's actually fine to import non-modules, you just
have to slap #noqa on those lines.

I went through the code and identified about a dozen names that are
most commonly imported this way. I remove the #noqa tag from them,
and added them to the list in import_exceptions.

I also removed a few unused imports that were revealed in the process.

Change-Id: I27afb8e2b1d4759ec974ded9464d8f010312ee78

HACKING.rst

@@ -3,7 +3,27 @@ Horizon Style Commandments
 
 - Step 1: Read the OpenStack Style Commandments
   http://docs.openstack.org/developer/hacking/
-- Step 2: Read on
+- Step 2: The following names can be imported directly, without triggering the
+  "H302: import only modules" flake8 warning::
+
+    collections.defaultdict,
+    django.conf.settings,
+    django.core.urlresolvers.reverse,
+    django.core.urlresolvers.reverse_lazy,
+    django.template.loader.render_to_string,
+    django.utils.datastructures.SortedDict,
+    django.utils.encoding.force_unicode,
+    django.utils.html.conditional_escape,
+    django.utils.html.escape,
+    django.utils.http.urlencode,
+    django.utils.safestring.mark_safe,
+    django.utils.translation.pgettext_lazy,
+    django.utils.translation.ugettext_lazy,
+    django.utils.translation.ungettext_lazy,
+    operator.attrgetter,
+    StringIO.StringIO
+
+- Step 3: Read on
 
 Horizon Specific Commandments
 -----------------------------

horizon/base.py

@@ -28,17 +28,17 @@ import inspect
 import logging
 import os
 
-from django.conf import settings  # noqa
+from django.conf import settings
 from django.conf.urls import include  # noqa
 from django.conf.urls import patterns  # noqa
 from django.conf.urls import url  # noqa
 from django.core.exceptions import ImproperlyConfigured  # noqa
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.utils.datastructures import SortedDict  # noqa
+from django.utils.datastructures import SortedDict
 from django.utils.functional import SimpleLazyObject  # noqa
 from django.utils.importlib import import_module  # noqa
 from django.utils.module_loading import module_has_submodule  # noqa
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import conf
 from horizon.decorators import _current_component  # noqa

horizon/browsers/base.py

@@ -15,7 +15,7 @@
 #    under the License.
 
 from django import template
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon.browsers.breadcrumb import Breadcrumb  # noqa
 from horizon.tables import DataTable  # noqa

horizon/browsers/views.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon.tables import MultiTableView  # noqa
 from horizon.utils import memoized

horizon/conf/default.py

@@ -10,8 +10,8 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
-from django.conf import settings  # noqa
+from django.conf import settings
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 # Default configuration dictionary. Do not mutate.
 HORIZON_CONFIG = {

horizon/decorators.py

@@ -24,7 +24,7 @@ General-purpose decorators for use with Horizon.
 import functools
 
 from django.utils.decorators import available_attrs  # noqa
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 
 def _current_component(view_func, dashboard=None, panel=None):

horizon/exceptions.py

@@ -25,7 +25,7 @@ import sys
 from django.contrib.auth import logout  # noqa
 from django.core.management import color_style  # noqa
 from django.http import HttpRequest  # noqa
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 from django.views.debug import CLEANSED_SUBSTITUTE  # noqa
 from django.views.debug import SafeExceptionReporterFilter  # noqa
 

horizon/loaders.py

@@ -16,7 +16,7 @@ Wrapper for loading templates from "templates" directories in panel modules.
 
 import os
 
-from django.conf import settings  # noqa
+from django.conf import settings
 from django.template.base import TemplateDoesNotExist  # noqa
 from django.template.loader import BaseLoader  # noqa
 from django.utils._os import safe_join  # noqa

horizon/middleware.py

@@ -25,7 +25,7 @@ import json
 import logging
 import time
 
-from django.conf import settings  # noqa
+from django.conf import settings
 from django.contrib.auth import REDIRECT_FIELD_NAME  # noqa
 from django.contrib.auth.views import redirect_to_login  # noqa
 from django.contrib import messages as django_messages
@@ -34,7 +34,7 @@ from django.http import HttpResponseRedirect  # noqa
 from django import shortcuts
 from django.utils.encoding import iri_to_uri  # noqa
 from django.utils import timezone
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon.utils import functions as utils

horizon/site_urls.py

@@ -18,7 +18,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.conf import settings  # noqa
+from django.conf import settings
 from django.conf.urls import include  # noqa
 from django.conf.urls import patterns  # noqa
 from django.conf.urls import url  # noqa

horizon/tables/actions.py

@@ -14,16 +14,16 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from collections import defaultdict  # noqa
+from collections import defaultdict
 import logging
 import new
 
-from django.conf import settings  # noqa
+from django.conf import settings
 from django.core import urlresolvers
 from django import shortcuts
 from django.utils.functional import Promise  # noqa
-from django.utils.translation import pgettext_lazy  # noqa
+from django.utils.translation import pgettext_lazy
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import messages

horizon/tables/base.py

@@ -18,7 +18,7 @@ import collections
 import copy
 import json
 import logging
-from operator import attrgetter  # noqa
+from operator import attrgetter
 import sys
 
 from django.core import exceptions as core_exceptions
@@ -27,14 +27,14 @@ from django import forms
 from django.http import HttpResponse  # noqa
 from django import template
 from django.template.defaultfilters import truncatechars  # noqa
-from django.template.loader import render_to_string  # noqa
+from django.template.loader import render_to_string
-from django.utils.datastructures import SortedDict  # noqa
+from django.utils.datastructures import SortedDict
-from django.utils.html import escape  # noqa
+from django.utils.html import escape
 from django.utils import http
-from django.utils.http import urlencode  # noqa
+from django.utils.http import urlencode
-from django.utils.safestring import mark_safe  # noqa
+from django.utils.safestring import mark_safe
 from django.utils import termcolors
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import conf
 from horizon import exceptions

horizon/templatetags/branding.py

@@ -22,10 +22,10 @@
 Template tags for customizing Horizon.
 """
 
-from django.conf import settings  # noqa
+from django.conf import settings
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django import template
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 
 register = template.Library()

horizon/templatetags/horizon.py

@@ -17,9 +17,9 @@
 from __future__ import absolute_import
 
 from django import template
-from django.utils.datastructures import SortedDict  # noqa
+from django.utils.datastructures import SortedDict
-from django.utils.encoding import force_unicode  # noqa
+from django.utils.encoding import force_unicode
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon.base import Horizon  # noqa
 from horizon import conf

horizon/test/tests/base.py

@@ -19,7 +19,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.conf import settings  # noqa
+from django.conf import settings
 from django.contrib.auth.models import User  # noqa
 from django.core.exceptions import ImproperlyConfigured  # noqa
 from django.core import urlresolvers

horizon/test/tests/messages.py

@@ -17,9 +17,8 @@
 import json
 
 from django import http
-from django.utils.encoding import force_unicode  # noqa
+from django.utils.encoding import force_unicode
-from django.utils.safestring import mark_safe  # noqa
+from django.utils.safestring import mark_safe
-from django.utils.translation import ugettext_lazy as _  # noqa
 
 from horizon import messages
 from horizon import middleware

horizon/test/tests/middleware.py

@@ -17,9 +17,8 @@
 
 import time
 
-from django.conf import settings  # noqa
+from django.conf import settings
 
-from django.http import HttpResponse  # noqa
 from django.http import HttpResponseRedirect  # noqa
 
 from horizon import exceptions

horizon/test/tests/tables.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django import forms
 from django import http
 from django import shortcuts

horizon/test/tests/templatetags.py

@@ -20,7 +20,7 @@
 
 import re
 
-from django.conf import settings  # noqa
+from django.conf import settings
 from django.template import Context  # noqa
 from django.template import Template  # noqa
 from django.utils.text import normalize_newlines  # noqa

horizon/utils/fields.py

@@ -13,11 +13,11 @@
 from django.core.exceptions import ValidationError  # noqa
 from django.forms import forms
 from django.forms import widgets
-from django.utils.encoding import force_unicode  # noqa
+from django.utils.encoding import force_unicode
 from django.utils.functional import Promise  # noqa
-from django.utils.html import conditional_escape  # noqa
+from django.utils.html import conditional_escape
-from django.utils.html import escape  # noqa
+from django.utils.html import escape
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 import netaddr
 import re
 

horizon/utils/functions.py

@@ -12,10 +12,10 @@
 
 import math
 
-from django.conf import settings  # noqa
+from django.conf import settings
 from django.contrib.auth import logout  # noqa
 from django import http
-from django.utils.encoding import force_unicode  # noqa
+from django.utils.encoding import force_unicode
 from django.utils.functional import lazy  # noqa
 from django.utils import translation
 

horizon/utils/validators.py

@@ -15,7 +15,7 @@
 #    under the License.
 
 from django.core.exceptions import ValidationError  # noqa
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import conf
 

horizon/workflows/base.py

@@ -25,9 +25,9 @@ from django import template
 from django.template.defaultfilters import linebreaks  # noqa
 from django.template.defaultfilters import safe  # noqa
 from django.template.defaultfilters import slugify  # noqa
-from django.utils.encoding import force_unicode  # noqa
+from django.utils.encoding import force_unicode
 from django.utils.importlib import import_module  # noqa
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import base
 from horizon import exceptions

openstack_dashboard/api/base.py

@@ -21,7 +21,7 @@
 from collections import Sequence  # noqa
 import logging
 
-from django.conf import settings  # noqa
+from django.conf import settings
 
 from horizon import exceptions
 

openstack_dashboard/api/ceilometer.py

@@ -16,9 +16,9 @@ import logging
 import threading
 
 from ceilometerclient import client as ceilometer_client
-from django.conf import settings  # noqa
+from django.conf import settings
 from django.utils import datastructures
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 

openstack_dashboard/api/cinder.py

@@ -24,8 +24,8 @@ from __future__ import absolute_import
 
 import logging
 
-from django.conf import settings  # noqa
+from django.conf import settings
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from cinderclient.v1 import client as cinder_client
 from cinderclient.v1.contrib import list_extensions as cinder_list_extensions

openstack_dashboard/api/glance.py

@@ -25,7 +25,7 @@ import logging
 import thread
 import urlparse
 
-from django.conf import settings  # noqa
+from django.conf import settings
 
 import glanceclient as glance_client
 

openstack_dashboard/api/heat.py

@@ -14,7 +14,7 @@
 
 import logging
 
-from django.conf import settings  # noqa
+from django.conf import settings
 from heatclient import client as heat_client
 from openstack_dashboard.api import base
 

openstack_dashboard/api/keystone.py

@@ -22,8 +22,8 @@
 import logging
 import urlparse
 
-from django.conf import settings  # noqa
+from django.conf import settings
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from keystoneclient import exceptions as keystone_exceptions
 

openstack_dashboard/api/network.py

@@ -21,8 +21,6 @@ introduced to abstract the differences between them for seamless consumption by
 different dashboard implementations.
 """
 
-from django.conf import settings  # noqa
-
 from openstack_dashboard.api import base
 from openstack_dashboard.api import neutron
 from openstack_dashboard.api import nova

openstack_dashboard/api/neutron.py

@@ -23,9 +23,9 @@ from __future__ import absolute_import
 
 import logging
 
-from django.conf import settings  # noqa
+from django.conf import settings
-from django.utils.datastructures import SortedDict  # noqa
+from django.utils.datastructures import SortedDict
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon.utils.memoized import memoized  # noqa
 

openstack_dashboard/api/nova.py

@@ -24,9 +24,9 @@ from __future__ import absolute_import
 
 import logging
 
-from django.conf import settings  # noqa
+from django.conf import settings
 from django.utils.functional import cached_property  # noqa
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from novaclient.v1_1 import client as nova_client
 from novaclient.v1_1.contrib import list_extensions as nova_list_extensions

openstack_dashboard/api/swift.py

@@ -23,8 +23,8 @@ import urllib
 
 import swiftclient
 
-from django.conf import settings  # noqa
+from django.conf import settings
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 

openstack_dashboard/api/trove.py

@@ -16,7 +16,7 @@
 
 import logging
 
-from django.conf import settings  # noqa
+from django.conf import settings
 from troveclient.v1 import client
 
 from openstack_dashboard.api import base

openstack_dashboard/context_processors.py

@@ -21,7 +21,7 @@
 Context processors used by Horizon.
 """
 
-from django.conf import settings  # noqa
+from django.conf import settings
 
 
 def openstack(request):

openstack_dashboard/dashboards/admin/dashboard.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 import horizon
 

openstack_dashboard/dashboards/admin/defaults/panel.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 import horizon
 

openstack_dashboard/dashboards/admin/defaults/tables.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import tables
 

openstack_dashboard/dashboards/admin/defaults/tabs.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import tabs

openstack_dashboard/dashboards/admin/defaults/tests.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django import http
 from mox import IsA  # noqa
 

openstack_dashboard/dashboards/admin/defaults/views.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import tabs
 from horizon import workflows

openstack_dashboard/dashboards/admin/defaults/workflows.py

@@ -15,7 +15,7 @@
 #    under the License.
 
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import forms

openstack_dashboard/dashboards/admin/domains/panel.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 import horizon
 

openstack_dashboard/dashboards/admin/domains/tables.py

@@ -16,10 +16,10 @@
 
 import logging
 
-from django.conf import settings  # noqa
+from django.conf import settings
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.utils.http import urlencode  # noqa
+from django.utils.http import urlencode
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from keystoneclient import exceptions
 

openstack_dashboard/dashboards/admin/domains/tests.py

@@ -15,7 +15,7 @@
 #    under the License.
 
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django import http
 
 from mox import IgnoreArg  # noqa

openstack_dashboard/dashboards/admin/domains/views.py

@@ -14,8 +14,8 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import tables

openstack_dashboard/dashboards/admin/domains/workflows.py

@@ -16,9 +16,9 @@
 
 import logging
 
-from django.conf import settings  # noqa
+from django.conf import settings
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import forms

openstack_dashboard/dashboards/admin/flavors/extras/forms.py

@@ -18,7 +18,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from openstack_dashboard import api
 

openstack_dashboard/dashboards/admin/flavors/extras/tables.py

@@ -14,8 +14,8 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import tables
 

openstack_dashboard/dashboards/admin/flavors/extras/tests.py

@@ -10,7 +10,7 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django import http
 
 from mox import IsA  # noqa

openstack_dashboard/dashboards/admin/flavors/extras/views.py

@@ -18,7 +18,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import forms

openstack_dashboard/dashboards/admin/flavors/panel.py

@@ -18,7 +18,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 import horizon
 

openstack_dashboard/dashboards/admin/flavors/tables.py

@@ -18,10 +18,10 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django.template import defaultfilters as filters
-from django.utils.http import urlencode  # noqa
+from django.utils.http import urlencode
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import tables
 

openstack_dashboard/dashboards/admin/flavors/tests.py

@@ -10,7 +10,7 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django import http
 from mox import IsA  # noqa
 

openstack_dashboard/dashboards/admin/flavors/views.py

@@ -18,8 +18,8 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse_lazy  # noqa
+from django.core.urlresolvers import reverse_lazy
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import tables

openstack_dashboard/dashboards/admin/flavors/workflows.py

@@ -19,7 +19,7 @@
 #    under the License.
 
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import forms

openstack_dashboard/dashboards/admin/groups/forms.py

@@ -16,7 +16,7 @@
 
 import logging
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import forms

openstack_dashboard/dashboards/admin/groups/panel.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 import horizon
 

openstack_dashboard/dashboards/admin/groups/tables.py

@@ -16,9 +16,9 @@
 
 import logging
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django.template import defaultfilters
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import tables
 

openstack_dashboard/dashboards/admin/groups/tests.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django import http
 
 from mox import IgnoreArg  # noqa

openstack_dashboard/dashboards/admin/groups/views.py

@@ -14,9 +14,9 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.core.urlresolvers import reverse_lazy  # noqa
+from django.core.urlresolvers import reverse_lazy
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import forms

openstack_dashboard/dashboards/admin/hypervisors/panel.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 import horizon
 from openstack_dashboard.dashboards.admin import dashboard

openstack_dashboard/dashboards/admin/hypervisors/tables.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import tables
 from horizon.templatetags import sizeformat

openstack_dashboard/dashboards/admin/hypervisors/tests.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django import http
 from mox import IsA  # noqa
 

openstack_dashboard/dashboards/admin/hypervisors/views.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import tables

openstack_dashboard/dashboards/admin/images/panel.py

@@ -18,7 +18,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 import horizon
 

openstack_dashboard/dashboards/admin/images/tables.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import tables
 

openstack_dashboard/dashboards/admin/images/tests.py

@@ -14,8 +14,8 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.conf import settings  # noqa
+from django.conf import settings
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django import http
 from django.test.utils import override_settings  # noqa
 

openstack_dashboard/dashboards/admin/images/views.py

@@ -18,8 +18,8 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse_lazy  # noqa
+from django.core.urlresolvers import reverse_lazy
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import tables

openstack_dashboard/dashboards/admin/info/panel.py

@@ -18,7 +18,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 import horizon
 

openstack_dashboard/dashboards/admin/info/tables.py

@@ -12,7 +12,7 @@
 
 from django import template
 from django.template import defaultfilters as filters
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import tables
 from horizon.utils import filters as utils_filters

openstack_dashboard/dashboards/admin/info/tabs.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import tabs

openstack_dashboard/dashboards/admin/info/tests.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django import http
 from mox import IsA  # noqa
 

openstack_dashboard/dashboards/admin/instances/forms.py

@@ -15,8 +15,8 @@
 #    under the License.
 
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import forms

openstack_dashboard/dashboards/admin/instances/panel.py

@@ -18,7 +18,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 import horizon
 

openstack_dashboard/dashboards/admin/instances/tables.py

@@ -15,11 +15,8 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse  # noqa
-from django.template.defaultfilters import timesince  # noqa
 from django.template.defaultfilters import title  # noqa
-from django.utils.http import urlencode  # noqa
+from django.utils.translation import ugettext_lazy as _
-from django.utils.translation import ugettext_lazy as _  # noqa
 
 from horizon import tables
 from horizon.utils import filters

openstack_dashboard/dashboards/admin/instances/tests.py

@@ -16,9 +16,9 @@
 
 import uuid
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django import http
-from django.utils.datastructures import SortedDict  # noqa
+from django.utils.datastructures import SortedDict
 
 from mox import IsA  # noqa
 

openstack_dashboard/dashboards/admin/instances/views.py

@@ -19,10 +19,10 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.core.urlresolvers import reverse_lazy  # noqa
+from django.core.urlresolvers import reverse_lazy
-from django.utils.datastructures import SortedDict  # noqa
+from django.utils.datastructures import SortedDict
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import forms

openstack_dashboard/dashboards/admin/metering/panel.py

@@ -12,7 +12,7 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 import horizon
 from openstack_dashboard.dashboards.admin import dashboard

openstack_dashboard/dashboards/admin/metering/tabs.py

@@ -13,7 +13,7 @@
 # under the License.
 
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import tabs
 from openstack_dashboard import api

openstack_dashboard/dashboards/admin/metering/tests.py

@@ -14,8 +14,8 @@
 import json
 import uuid
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django import http  # noqa
+from django import http
 from mox import IsA  # noqa
 
 from openstack_dashboard import api

openstack_dashboard/dashboards/admin/metering/views.py

@@ -18,7 +18,7 @@ from datetime import timedelta  # noqa
 import json
 
 from django.http import HttpResponse   # noqa
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 from django.views.generic import TemplateView  # noqa
 
 from horizon import exceptions

openstack_dashboard/dashboards/admin/networks/forms.py

@@ -16,9 +16,8 @@
 
 import logging
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.utils import datastructures  # noqa
+from django.utils.translation import ugettext_lazy as _
-from django.utils.translation import ugettext_lazy as _  # noqa
 
 from horizon import exceptions
 from horizon import forms

openstack_dashboard/dashboards/admin/networks/panel.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 import horizon
 

openstack_dashboard/dashboards/admin/networks/ports/forms.py

@@ -16,8 +16,8 @@
 
 import logging
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import forms

openstack_dashboard/dashboards/admin/networks/ports/tables.py

@@ -16,8 +16,8 @@
 
 import logging
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import tables

openstack_dashboard/dashboards/admin/networks/ports/tabs.py

@@ -14,8 +14,8 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import tabs

openstack_dashboard/dashboards/admin/networks/ports/views.py

@@ -14,8 +14,8 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import forms

openstack_dashboard/dashboards/admin/networks/subnets/tables.py

@@ -16,8 +16,8 @@
 
 import logging
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import tables

openstack_dashboard/dashboards/admin/networks/subnets/workflows.py

@@ -16,8 +16,8 @@
 
 import logging
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 

openstack_dashboard/dashboards/admin/networks/tables.py

@@ -16,9 +16,9 @@
 
 import logging
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django.template import defaultfilters as filters
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import tables

openstack_dashboard/dashboards/admin/networks/tests.py

@@ -14,7 +14,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django import http
 
 from horizon.workflows import views

openstack_dashboard/dashboards/admin/networks/views.py

@@ -14,9 +14,9 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse_lazy  # noqa
+from django.core.urlresolvers import reverse_lazy
-from django.utils.datastructures import SortedDict  # noqa
+from django.utils.datastructures import SortedDict
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import forms

openstack_dashboard/dashboards/admin/overview/panel.py

@@ -18,7 +18,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 import horizon
 

openstack_dashboard/dashboards/admin/overview/tests.py

@@ -20,7 +20,7 @@
 
 import datetime
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django import http
 from django.utils import timezone
 

openstack_dashboard/dashboards/admin/overview/views.py

@@ -18,9 +18,9 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.conf import settings  # noqa
+from django.conf import settings
 from django.template.defaultfilters import floatformat  # noqa
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 

openstack_dashboard/dashboards/admin/projects/panel.py

@@ -18,7 +18,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 import horizon
 

openstack_dashboard/dashboards/admin/projects/tables.py

@@ -11,9 +11,9 @@
 # under the License.
 
 from django.core.exceptions import ValidationError  # noqa
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.utils.http import urlencode  # noqa
+from django.utils.http import urlencode
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import forms

openstack_dashboard/dashboards/admin/projects/tests.py

@@ -19,7 +19,7 @@ import datetime
 import logging
 import os
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
 from django import http
 from django.test.utils import override_settings  # noqa
 from django.utils import timezone

openstack_dashboard/dashboards/admin/projects/views.py

@@ -18,8 +18,8 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from django.core.urlresolvers import reverse  # noqa
+from django.core.urlresolvers import reverse
-from django.utils.translation import ugettext_lazy as _  # noqa
+from django.utils.translation import ugettext_lazy as _
 
 from horizon import exceptions
 from horizon import tables