openstack
/
deb-horizon
Code Issues Proposed changes

Use correct casing on jQuery. 

Many places in the comments of our code base, we incorrectly
case jQuery.

Change-Id: I9c8d20dc4e38fd1a821d9dc04eb36f0fcc79ae56
This commit is contained in:
Diana Whitten 2016-05-12 09:25:03 -07:00
parent 4f9e33d4c5
commit 3536c7183f
7 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
horizon/static/auth/login/login.spec.js
View File

@ -34,7 +34,7 @@
regularMarkup = $templateCache.get(basePath + 'login.regular.mock.html');
jasmine.addMatchers({
// jquery show is not consistent across different browsers
// jQuery show is not consistent across different browsers
// on FF, it is 'block' while on chrome it is 'inline'
// to reconcile this difference, we need a custom matcher
toBeVisible: function() {

2
horizon/static/framework/util/tech-debt/helper-functions.service.js
View File

@ -30,7 +30,7 @@
/*
* Compile angular directives in a DOM element that has typically been
* loaded into the page (the only current use of this is in JQuery
* loaded into the page (the only current use of this is in jQuery
* modal dialogs).
*/
function loadAngular(element) {

2
horizon/static/framework/widgets/modal-wait-spinner/modal-wait-spinner.service.js
View File

@ -13,7 +13,7 @@
* @description
* In order to provide a seamless transition to a Horizon that uses more Angular
* based pages, the service is currently implemented using the existing
* Spin.js library and the corresponding JQuery plugin (jquery.spin.js). This widget
* Spin.js library and the corresponding jQuery plugin (jquery.spin.js). This widget
* looks and feels the same as the existing spinner we are familiar with in Horizon.
* Over time, uses of the existing Horizon spinner ( horizon.modals.modal_spinner() )
* can be phased out, or refactored to use this component.

2
horizon/static/horizon/js/horizon.d3barchart.js
View File

@ -540,7 +540,7 @@ horizon.d3_bar_chart = {
},
/**
* Function for initializing of the charts.
* @param selector JQuery selector of charts we want to initialize.
* @param selector jQuery selector of charts we want to initialize.
* @param settings An object containing settings of the chart.
* @param data An object containing data of the chart.
*/

18
horizon/static/horizon/js/horizon.d3linechart.js
View File

@ -7,10 +7,10 @@
data-chart-type - REQUIRED(string) must be "line_chart" so chart gets initialized
data-url - REQUIRED(string) url for the json data for the chart
data-form-selector - Optional(string) JQuery selector of Forms that controls this chart
data-legend-selector - Optional(string) JQuery selector of div element that will display legend
data-smoother-selector - Optional(string) JQuery selector of TODO(lsmola)
data-slider-selector - Optional(string) JQuery selector of TODO(lsmola)
data-form-selector - Optional(string) jQuery selector of Forms that controls this chart
data-legend-selector - Optional(string) jQuery selector of div element that will display legend
data-smoother-selector - Optional(string) jQuery selector of TODO(lsmola)
data-slider-selector - Optional(string) jQuery selector of TODO(lsmola)
If used in popup, initialization must be made manually e.g.:
@ -464,7 +464,7 @@ horizon.d3_line_chart = {
});
/*
TODO(lsmola) add JQuery UI slider to make this work
TODO(lsmola) add jQuery UI slider to make this work
if (self.slider_element) {
var slider = new Rickshaw.Graph.RangeSlider({
graph: graph,
@ -624,7 +624,7 @@ horizon.d3_line_chart = {
* If settings['auto_resize'] is true, the chart will be refreshed when
* the size of the window is changed. This option made only sense when
* the size of the chart and its wrapper is not static.
* @param selector JQuery selector of charts we want to initialize.
* @param selector jQuery selector of charts we want to initialize.
* @param settings An object containing settings of the chart.
*/
init: function(selector, settings) {
@ -686,7 +686,7 @@ horizon.d3_line_chart = {
* timespan or various parameters we want to show in the chart. The
* charts will be refreshed immediately after the form element connected
* to them is changed.
* @param selector JQuery selector of charts we are initializing.
* @param selector jQuery selector of charts we are initializing.
* @param settings An object containing settings of the chart.
*/
bind_commands: function (selector, settings){
@ -697,7 +697,7 @@ horizon.d3_line_chart = {
/**
* Connecting forms to charts it controls. Each chart contains
* JQuery selector data-form-selector, which defines by which
* jQuery selector data-form-selector, which defines by which
* html Forms is a particular chart controlled. This information
* has to be projected to forms. So when form input is changed,
* all connected charts are refreshed.
@ -721,7 +721,7 @@ horizon.d3_line_chart = {
/**
* A helper function for delegating form events to charts, causing their
* refreshing.
* @param selector JQuery selector of charts we are initializing.
* @param selector jQuery selector of charts we are initializing.
* @param event_name Event name we want to delegate.
* @param settings An object containing settings of the chart.
*/

2
horizon/static/horizon/js/horizon.tables_inline_edit.js
View File

@ -52,7 +52,7 @@ horizon.inline_edit = {
self.start_loading();
},
complete: function () {
// Bug in Jquery tool-tip, if I hover tool-tip, then confirm the field with
// Bug in jQuery tool-tip, if I hover tool-tip, then confirm the field with
// enter and the cell is reloaded, tool-tip stays. So just to be sure, I am
// removing tool-tips manually
$(".tooltip.fade.top.in").remove();

4
openstack_dashboard/contrib/developer/static/dashboard/developer/theme-preview/theme-preview.directive.js
View File

@ -27,7 +27,7 @@
* @ngdoc directive
* @name themepreview
* @description
* Wraps the JS code for displaying the theme preview page. Shouldnt be used elsewhere.
* Wraps the JS code for displaying the theme preview page. Shouldn't be used elsewhere.
*/
function themePreview(path) {
@ -42,7 +42,7 @@
function link(scope, element) {
//TODO(tqtran) Use angular, not jquery
//TODO(tqtran) Use angular, not jQuery
$('a[href="#"]').click(function(e) {
e.preventDefault();
});