openstack/deb-horizon
Code Issues Proposed changes

Set target to _self for Header Links

Browse Source 
Angular Panels have enabled ngRoute and HTML5 which
allows Angular to handle routing which makes all
routes to pass via Angular.

Links that do not have route defintion as a result stop
working.
This can be fixed by specifying the target="_self" on the <a> tags.

This is already in place for the Sidebar. It needs to done for the
Header Links as well.

Closes-Bug: #1531734
Change-Id: Ida76b40fdf0b66ba3ee3af4d32701974c312af57
This commit is contained in:
Rajat Vig 2016-01-06 22:53:38 -08:00 committed by Matt Borland
parent e302753a96
commit 6698d26fba
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
openstack_dashboard/templates/_header.html
View File

@ -11,7 +11,7 @@
<span class="icon-bar"></span>
<span class="icon-bar"></span>
</button>
<a class="navbar-brand" href="{% site_branding_link %}">
<a class="navbar-brand" href="{% site_branding_link %}" target="_self"">
<img class="openstack-logo" src="{{ STATIC_URL }}dashboard/img/logo.png" alt="{% site_branding %}">
</a>
</div>
@ -61,7 +61,7 @@
</a>
<ul id="editor_list" class="dropdown-menu dropdown-menu-right">
<li>
<a href="{% url 'horizon:settings:user:index' %}">
<a href="{% url 'horizon:settings:user:index' %}" target="_self">
<span class="fa fa-cog"></span>
{% trans "Settings" %}
</a>
@ -84,7 +84,7 @@
{% endif %}
<li class="divider"></li>
<li>
<a href="{% url 'logout' %}">
<a href="{% url 'logout' %}" target="_self">
<span class="fa fa-sign-out"></span>
{% trans "Sign Out" %}
</a>

2
openstack_dashboard/templates/context_selection/_project_list.html
View File

@ -5,7 +5,7 @@
<li class="dropdown-header">{% trans "Projects:" %}</li>
{% for project in projects %}
<li>
<a href="{% url 'switch_tenants' project.id %}?next={{ dashboard_url }}">
<a href="{% url 'switch_tenants' project.id %}?next={{ dashboard_url }}" target="_self">
{{ project.name }}
{% if project.enabled and project.id == project_id %}
<span class="fa fa-check"></span>

2
openstack_dashboard/templates/context_selection/_region_list.html
View File

@ -5,7 +5,7 @@
<li class="dropdown-header">{% trans "Regions:" %}</li>
{% for region in regions %}
<li>
<a href="{% url 'switch_services_region' region %}?next={{ panel_url }}">
<a href="{% url 'switch_services_region' region %}?next={{ panel_url }}" target="_self">
{{ region }}
{% if region == region_name %}
<span class="fa fa-check"></span>

6
openstack_dashboard/themes/material/templates/_header.html
View File

@ -20,7 +20,7 @@
<script src='{{ STATIC_URL }}custom/js/material.hamburger.js'></script>
{% endcompress %}
</div>
<a class="navbar-brand" href="{% site_branding_link %}">
<a class="navbar-brand" href="{% site_branding_link %}" target="_self">
<img class="openstack-logo" src="{{ STATIC_URL }}dashboard/img/logo.png" alt="{% site_branding %}">
</a>
</div>
@ -70,7 +70,7 @@
</a>
<ul id="editor_list" class="dropdown-menu">
<li>
<a href="{% url 'horizon:settings:user:index' %}">
<a href="{% url 'horizon:settings:user:index' %}" target="_self">
<span class="fa fa-cog"></span>
{% trans "Settings" %}
</a>
@ -93,7 +93,7 @@
{% endif %}
<li class="divider"></li>
<li>
<a href="{% url 'logout' %}">
<a href="{% url 'logout' %}" target="_self">
<span class="fa fa-sign-out"></span>
{% trans "Sign Out" %}
</a>