Use OS::Nova::Server resource type for instance metadata

Horizon currently uses the OS::Nova::Instance resource type when
querying for instance metadata, but it should use OS::Nova::Server
to align with Heat and Searchlight.

See also:
  https://review.openstack.org/272271

Closes-Bug: #1537903
Change-Id: I1deab8ed74515d08301e68bd2c75604d35592c50

openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js

@@ -544,7 +544,7 @@
         flavor: ['OS::Nova::Flavor', ''],
         image: ['OS::Glance::Image', ''],
         volume: ['OS::Cinder::Volumes', ''],
-        instance: ['OS::Nova::Instance', 'metadata']
+        instance: ['OS::Nova::Server', 'metadata']
       };
 
       angular.forEach(resourceTypes, applyForResourceType);

openstack_dashboard/static/app/core/metadata/metadata.service.js

@@ -86,7 +86,7 @@
           aggregate: 'OS::Nova::Aggregate',
           flavor: 'OS::Nova::Flavor',
           image: 'OS::Glance::Image',
-          instance: 'OS::Nova::Instance'
+          instance: 'OS::Nova::Server'
         }[resource]
       };
       if (propertiesTarget) {

openstack_dashboard/static/app/core/metadata/metadata.service.spec.js

@@ -121,7 +121,7 @@
       spyOn(glance, 'getNamespaces');
       metadataService.getNamespaces('instance', 'metadata');
       expect(glance.getNamespaces)
-      .toHaveBeenCalledWith({ resource_type: 'OS::Nova::Instance',
+      .toHaveBeenCalledWith({ resource_type: 'OS::Nova::Server',
                               properties_target: 'metadata' }, false);
     });
 

openstack_dashboard/static/app/core/openstack-service-api/glance.service.js

@@ -307,7 +307,7 @@
      *
      * @param {string} params.properties_target
      * The properties target, if the resource type has more than one type
-     * of property. For example, the OS::Nova::Instance resource type has
+     * of property. For example, the OS::Nova::Server resource type has
      * "metadata" and "scheduler_hints" properties targets.
      *
      * @param {boolean} params.paginate
@@ -359,7 +359,7 @@
      * The listing result is an object with property "items".
      * Each item is a resource type. Resource types are Strings that
      * correlate to Heat and Searchlight resource types.
-     * For example: OS::Glance::Image and OS::Nova::Instance.
+     * For example: OS::Glance::Image and OS::Nova::Server.
      *
      */
     function getResourceTypes() {

releasenotes/notes/bp-add-server-metadata-a5d5582966ef25c5.yaml

@@ -2,4 +2,4 @@
 features:
   - Added the Metadata tab to the new Launch Instance workflow to allow adding
     key-value metadata to an instance at launch. This includes any properties
-    from the OS::Nova::Instance namespace of the glance metadata definitions.
+    from the OS::Nova::Server namespace of the glance metadata definitions.