From fca46ab60ffd798fda67ea045905f7932ed1347b Mon Sep 17 00:00:00 2001
From: Tyr Johanson <tyr@hp.com>
Date: Tue, 31 May 2016 12:52:14 -0600
Subject: [PATCH] Pre-populate the Angular template cache and allow template
 overrides

This patch populates the Angular template cache from Django.
This eliminates the need for Angular to do an http get for every HTML
fragment.

In addition, now that we are filling the template cache, this patch
introduces the logic needed to override any Angular template HTML from
the current theme.

How it works:
A new template tag is created called "template_cache_preloads". This
tag is used in _scripts.html to generate a list of text/javascript
script tags, each one containing an Angular "run" method that loads
a template contents into the Angular template cache. The first time
any Horizon page is loaded after server start, the template cache
preloads are computed for the current theme.

The output of this tag is cached for 30 days in Django using the
"cache" tag. Further, that cached result is wrapped in a "compress js"
tag to collapse the individual <script> tags into 1 block of
javascript, and compress like all other javascript Horizon serves to
the client.

Finally, when using offline compression, the compressor evaluates the
nodelist (HTML content) of _scripts.html, notices the compress tag
and builds the template cache preloads for each possible theme. Later,
at runtime, when the preloads are generated for the current theme, the
compressor gets the result from the Django cache, and hashes the
contents to determine which manifest file to serve to the client.
Since the preloads generated at run-time are identical to those
generated off-line, the compressor hash matches an existing manifest
which is served to the client.

Notice that even though the template cache pre-loads are generated
off-line...the template_cache_preloads tag will be executed once
every 30 days anyway. However, since the result matches the off-line
compression, the existing manifest continues to be served to the client.

Finally, this patch ALSO watches for 'post_compress' signals. If it
detects that the angular template preloads have been re-compressed, it
clears the old version from the Django cache.

To test the template caching:
- Run horizon
- View page source
- Notice the new <script type="text/javascript"> tags contained in
  the body (only visible if COMPRESS_ENABLED=False
- Open the javascript inspector
- Load launch instance
- Notice there are no longer http calls to load each HTML fragment
  used by the Angular launch instance

To test the override:
- Set the DEFAULT_THEME='material'
- Create /horizon/openstack_dashboard/themes/material/\
static/templates/framework/widgets/help-panel/help-panel.html
- Set the content to <h1>TEST</h1>
- Run Horizon and open launch instance.
- The help content should contain "TEST"

To test the new template tag:
- set a breakpoint or print in angular.py:template_cache_preloads
  and observe when it is called during off-line or run-time use

Co-Authored-By: Diana Whitten <hurgleburgler@gmail.com>

Implements: blueprint angular-template-overrides
Change-Id: I0e4e2623be58abbc68c6e02b2e9c5d7cdaba8e4d
---
 doc/source/topics/settings.rst                |  10 +-
 horizon/templatetags/angular.py               | 120 ++++++++++++++++++
 horizon/templatetags/horizon.py               |   5 +
 horizon/themes.py                             |   3 +
 openstack_dashboard/settings.py               |  12 +-
 openstack_dashboard/static_settings.py        |  53 +++++++-
 .../templates/angular/angular_templates.html  |   5 +
 .../templates/angular/angular_templates.js    |  11 ++
 .../templates/horizon/_scripts.html           |  13 ++
 openstack_dashboard/test/settings.py          |  20 ++-
 ...r-template-overrides-9f05ffd61367245a.yaml |  11 ++
 11 files changed, 258 insertions(+), 5 deletions(-)
 create mode 100644 horizon/templatetags/angular.py
 create mode 100644 openstack_dashboard/templates/angular/angular_templates.html
 create mode 100644 openstack_dashboard/templates/angular/angular_templates.js
 create mode 100644 releasenotes/notes/bp-angular-template-overrides-9f05ffd61367245a.yaml

diff --git a/doc/source/topics/settings.rst b/doc/source/topics/settings.rst
index aaa4a28f3..e81f41f1a 100644
--- a/doc/source/topics/settings.rst
+++ b/doc/source/topics/settings.rst
@@ -1675,13 +1675,21 @@ Template loaders defined here will have their output cached if DEBUG
 is set to False.
 
 ``ADD_TEMPLATE_LOADERS``
----------------------------
+------------------------
 
 .. versionadded:: 10.0.0(Newton)
 
 Template loaders defined here will be be loaded at the end of TEMPLATE_LOADERS,
 after the CACHED_TEMPLATE_LOADERS and will never have a cached output.
 
+``NG_TEMPLATE_CACHE_AGE``
+-------------------------
+
+.. versionadded:: 10.0.0(Newton)
+
+Angular Templates are cached using this duration (in seconds) if DEBUG
+is set to False.  Default value is ``2592000`` (or 30 days).
+
 ``SECRET_KEY``
 --------------
 
diff --git a/horizon/templatetags/angular.py b/horizon/templatetags/angular.py
new file mode 100644
index 000000000..8f37b565c
--- /dev/null
+++ b/horizon/templatetags/angular.py
@@ -0,0 +1,120 @@
+# Copyright 2016 Hewlett Packard Enterprise Development Company LP
+# All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+
+from compressor.signals import post_compress
+from django.contrib.staticfiles import finders
+from django.core.cache import caches
+from django.core.cache.utils import make_template_fragment_key
+from django.dispatch import receiver
+from django import template
+
+register = template.Library()
+
+
+@receiver(post_compress)
+def update_angular_template_hash(sender, **kwargs):
+    """Listen for compress events. If the angular templates
+    have been re-compressed, also clear them from the Django
+    cache backend.  This is important to allow deployers to
+    change a template file, re-compress, and not accidentally
+    serve the old Django cached version of that content to
+    clients.
+    """
+    context = kwargs['context']  # context the compressor is working with
+    theme = context['THEME']  # current theme being compressed
+    compressed = context['compressed']  # the compressed content
+    compressed_name = compressed['name']  # name of the compressed content
+    if compressed_name == 'angular_template_cache_preloads':
+        # The compressor has modified the angular template cache preloads
+        # which are cached in the 'default' Django cache. Fetch that cache.
+        cache = caches['default']
+
+        # generate the same key as used in _scripts.html when caching the
+        # preloads
+        key = make_template_fragment_key(
+            "angular",
+            ['template_cache_preloads', theme]
+        )
+
+        # if template preloads have been cached, clear them
+        if cache.get(key):
+            cache.delete(key)
+
+
+@register.filter(name='angular_escapes')
+def angular_escapes(value):
+    """Djangos 'escapejs' is too aggressive and inserts unicode. Provide
+    a basic filter to allow angular template content to be used within
+    javascript strings.
+
+    Args:
+        value: a string
+
+    Returns:
+        string with escaped values
+    """
+    return value \
+        .replace('"', '\\"') \
+        .replace("'", "\\'") \
+        .replace("\n", "\\n") \
+        .replace("\r", "\\r")
+
+
+@register.inclusion_tag('angular/angular_templates.html', takes_context=True)
+def angular_templates(context):
+    """For all static HTML templates, generate a dictionary of template
+    contents. If the template has been overridden by a theme, load the
+    override contents instead of the original HTML file.  One use for
+    this is to pre-populate the angular template cache.
+
+    Args:
+        context: the context of the current Django template
+
+    Returns: an object containing
+     angular_templates: dictionary of angular template contents
+      - key is the template's static path,
+      - value is a string of HTML template contents
+    """
+    template_paths = context['HORIZON_CONFIG']['external_templates']
+    all_theme_static_files = context['HORIZON_CONFIG']['theme_static_files']
+    this_theme_static_files = all_theme_static_files[context['THEME']]
+    template_overrides = this_theme_static_files['template_overrides']
+    angular_templates = {}
+
+    for relative_path in template_paths:
+
+        template_static_path = context['STATIC_URL'] + relative_path
+
+        # If the current theme overrides this template, use the theme
+        # content instead of the original file content
+        if relative_path in template_overrides:
+            relative_path = template_overrides[relative_path]
+
+        result = []
+        for finder in finders.get_finders():
+            result.extend(finder.find(relative_path, True))
+        path = result[-1]
+        try:
+            with open(path) as template_file:
+                angular_templates[template_static_path] = template_file.read()
+        except (OSError, IOError):
+            # Failed to read template, leave the template dictionary blank
+            # If the caller is using this dictionary to pre-populate a cache
+            # there will simply be no pre-loaded version for this template.
+            pass
+
+    return {
+        'angular_templates': angular_templates
+    }
diff --git a/horizon/templatetags/horizon.py b/horizon/templatetags/horizon.py
index c9d2c764d..d13b1165a 100644
--- a/horizon/templatetags/horizon.py
+++ b/horizon/templatetags/horizon.py
@@ -211,6 +211,11 @@ def datepicker_locale():
     return locale_mapping.get(translation.get_language(), 'en')
 
 
+@register.assignment_tag
+def template_cache_age():
+    return getattr(settings, 'NG_TEMPLATE_CACHE_AGE', 0)
+
+
 @register.tag
 def minifyspace(parser, token):
     """Removes whitespace including tab and newline characters. Do not use this
diff --git a/horizon/themes.py b/horizon/themes.py
index 5df6c7257..36976e13e 100644
--- a/horizon/themes.py
+++ b/horizon/themes.py
@@ -149,6 +149,9 @@ class ThemeTemplateLoader(tLoaderCls):
             elif template_name.find(template_path) != -1:
                 yield template_name
 
+        except SuspiciousFileOperation:
+            # In case we are loading a theme outside of Django, pass along
+            pass
         except UnicodeDecodeError:
             # The template dir name wasn't valid UTF-8.
             raise
diff --git a/openstack_dashboard/settings.py b/openstack_dashboard/settings.py
index e96a4dff7..04e36e6d6 100644
--- a/openstack_dashboard/settings.py
+++ b/openstack_dashboard/settings.py
@@ -56,6 +56,7 @@ MEDIA_URL = None
 STATIC_ROOT = None
 STATIC_URL = None
 INTEGRATION_TESTS_SUPPORT = False
+NG_TEMPLATE_CACHE_AGE = 2592000
 
 ROOT_URLCONF = 'openstack_dashboard.urls'
 
@@ -307,6 +308,7 @@ try:
 except ImportError:
     logging.warning("No local_settings file found.")
 
+# Template loaders
 if DEBUG:
     TEMPLATE_LOADERS += CACHED_TEMPLATE_LOADERS + tuple(ADD_TEMPLATE_LOADERS)
 else:
@@ -314,6 +316,8 @@ else:
         ('django.template.loaders.cached.Loader', CACHED_TEMPLATE_LOADERS),
     ) + tuple(ADD_TEMPLATE_LOADERS)
 
+NG_TEMPLATE_CACHE_AGE = NG_TEMPLATE_CACHE_AGE if not DEBUG else 0
+
 # allow to drop settings snippets into a local_settings_dir
 LOCAL_SETTINGS_DIR_PATH = os.path.join(ROOT_PATH, "local", "local_settings.d")
 if os.path.exists(LOCAL_SETTINGS_DIR_PATH):
@@ -376,7 +380,8 @@ if DEFAULT_THEME_PATH is not None:
 
 # populate HORIZON_CONFIG with auto-discovered JavaScript sources, mock files,
 # specs files and external templates.
-find_static_files(HORIZON_CONFIG)
+find_static_files(HORIZON_CONFIG, AVAILABLE_THEMES,
+                  THEME_COLLECTION_DIR, ROOT_PATH)
 
 # Ensure that we always have a SECRET_KEY set, even when no local_settings.py
 # file is present. See local_settings.py.example for full documentation on the
@@ -416,12 +421,15 @@ def check(actions, request, target=None):
 if POLICY_CHECK_FUNCTION is None:
     POLICY_CHECK_FUNCTION = check
 
+NG_TEMPLATE_CACHE_AGE = NG_TEMPLATE_CACHE_AGE if not DEBUG else 0
+
 # This base context objects gets added to the offline context generator
 # for each theme configured.
 HORIZON_COMPRESS_OFFLINE_CONTEXT_BASE = {
     'WEBROOT': WEBROOT,
     'STATIC_URL': STATIC_URL,
-    'HORIZON_CONFIG': HORIZON_CONFIG
+    'HORIZON_CONFIG': HORIZON_CONFIG,
+    'NG_TEMPLATE_CACHE_AGE': NG_TEMPLATE_CACHE_AGE,
 }
 
 if DEBUG:
diff --git a/openstack_dashboard/static_settings.py b/openstack_dashboard/static_settings.py
index b726ef44b..f68d88226 100644
--- a/openstack_dashboard/static_settings.py
+++ b/openstack_dashboard/static_settings.py
@@ -47,6 +47,8 @@ import xstatic.pkg.termjs
 
 from horizon.utils import file_discovery
 
+from openstack_dashboard import theme_settings
+
 
 def get_staticfiles_dirs(webroot='/'):
     STATICFILES_DIRS = [
@@ -139,7 +141,11 @@ def get_staticfiles_dirs(webroot='/'):
     return STATICFILES_DIRS
 
 
-def find_static_files(HORIZON_CONFIG):
+def find_static_files(
+        HORIZON_CONFIG,
+        AVAILABLE_THEMES,
+        THEME_COLLECTION_DIR,
+        ROOT_PATH):
     import horizon
     import openstack_dashboard
     os_dashboard_home_dir = openstack_dashboard.__path__[0]
@@ -163,3 +169,48 @@ def find_static_files(HORIZON_CONFIG):
         os.path.join(os_dashboard_home_dir, 'static/'),
         sub_path='app/'
     )
+
+    # Discover theme static resources, and in particular any
+    # static HTML (client-side) that the theme overrides
+    theme_static_files = {}
+    theme_info = theme_settings.get_theme_static_dirs(
+        AVAILABLE_THEMES,
+        THEME_COLLECTION_DIR,
+        ROOT_PATH)
+
+    for url, path in theme_info:
+        discovered_files = {}
+
+        # discover static files provided by the theme
+        file_discovery.populate_horizon_config(
+            discovered_files,
+            path
+        )
+
+        # Get the theme name from the theme url
+        theme_name = url.split('/')[-1]
+
+        # build a dictionary of this theme's static HTML templates.
+        # For each overridden template, strip off the '/templates/' part of the
+        # theme filename then use that name as the key, and the location in the
+        # theme directory as the value. This allows the quick lookup of
+        # theme path for any file overridden by a theme template
+        template_overrides = {}
+        for theme_file in discovered_files['external_templates']:
+            # Example:
+            #   external_templates_dict[
+            #       'framework/widgets/help-panel/help-panel.html'
+            #   ] = 'themes/material/templates/framework/widgets/\
+            #        help-panel/help-panel.html'
+            (templates_part, override_path) = theme_file.split('/templates/')
+            template_overrides[override_path] = 'themes/' +\
+                                                theme_name + theme_file
+
+        discovered_files['template_overrides'] = template_overrides
+
+        # Save all of the discovered file info for this theme in our
+        # 'theme_files' object using the theme name as the key
+        theme_static_files[theme_name] = discovered_files
+
+    # Add the theme file info to the horizon config for use by template tags
+    HORIZON_CONFIG['theme_static_files'] = theme_static_files
diff --git a/openstack_dashboard/templates/angular/angular_templates.html b/openstack_dashboard/templates/angular/angular_templates.html
new file mode 100644
index 000000000..76575b429
--- /dev/null
+++ b/openstack_dashboard/templates/angular/angular_templates.html
@@ -0,0 +1,5 @@
+{% for static_path, template_html in angular_templates.items %}
+  <script type='text/javascript' id='{{ static_path }}'>
+    {% include 'angular/angular_templates.js' %}
+  </script>
+{% endfor %}
\ No newline at end of file
diff --git a/openstack_dashboard/templates/angular/angular_templates.js b/openstack_dashboard/templates/angular/angular_templates.js
new file mode 100644
index 000000000..167e5ae69
--- /dev/null
+++ b/openstack_dashboard/templates/angular/angular_templates.js
@@ -0,0 +1,11 @@
+{% autoescape off %}
+{% load angular_escapes from angular %}
+angular
+ .module('horizon.app')
+ .run(['$templateCache', function($templateCache) {
+   $templateCache.put(
+     "{{ static_path }}",
+     "{{ template_html|angular_escapes }}"
+   );
+}]);
+{% endautoescape %}
diff --git a/openstack_dashboard/templates/horizon/_scripts.html b/openstack_dashboard/templates/horizon/_scripts.html
index 345083542..409312337 100644
--- a/openstack_dashboard/templates/horizon/_scripts.html
+++ b/openstack_dashboard/templates/horizon/_scripts.html
@@ -1,7 +1,13 @@
 {% load compress %}
 {% load datepicker_locale from horizon %}
+{% load template_cache_age from horizon %}
+{% load themes %}
+{% load cache %}
+{% load angular_templates from angular %}
 
 {% datepicker_locale as DATEPICKER_LOCALE %}
+{% current_theme as THEME %}
+{% template_cache_age as NG_TEMPLATE_CACHE_AGE %}
 
 {% include "horizon/_script_i18n.html" %}
 
@@ -66,6 +72,13 @@
 {% endfor %}
 
 {% block custom_js_files %}{% endblock %}
+
+{% endcompress %}
+
+{% compress js file angular_template_cache_preloads %}
+  {% cache NG_TEMPLATE_CACHE_AGE angular 'template_cache_preloads' THEME %}
+    {% angular_templates %}
+  {% endcache %}
 {% endcompress %}
 
 {% comment %} Client-side Templates (These should *not* be inside the "compress" tag.) {% endcomment %}
diff --git a/openstack_dashboard/test/settings.py b/openstack_dashboard/test/settings.py
index fee5aa0e2..c62c298fc 100644
--- a/openstack_dashboard/test/settings.py
+++ b/openstack_dashboard/test/settings.py
@@ -12,6 +12,7 @@
 
 import os
 
+from django.utils.translation import pgettext_lazy
 from horizon.test.settings import *  # noqa
 from horizon.utils import secret_key
 from openstack_dashboard import exceptions
@@ -43,6 +44,22 @@ TEMPLATE_DIRS = (
 
 CUSTOM_THEME_PATH = 'themes/default'
 
+# 'key', 'label', 'path'
+AVAILABLE_THEMES = [
+    (
+        'default',
+        pgettext_lazy('Default style theme', 'Default'),
+        'themes/default'
+    ), (
+        'material',
+        pgettext_lazy("Google's Material Design style theme", "Material"),
+        'themes/material'
+    ),
+]
+
+# Theme Static Directory
+THEME_COLLECTION_DIR = 'themes'
+
 TEMPLATE_CONTEXT_PROCESSORS += (
     'openstack_dashboard.context_processors.openstack',
 )
@@ -101,7 +118,8 @@ INSTALLED_APPS[0:0] = []
 # the stacks MappingsTests are updated with the new URL path.
 HORIZON_CONFIG['swift_panel'] = 'legacy'
 
-find_static_files(HORIZON_CONFIG)
+find_static_files(HORIZON_CONFIG, AVAILABLE_THEMES,
+                  THEME_COLLECTION_DIR, ROOT_PATH)
 
 # Set to True to allow users to upload images to glance via Horizon server.
 # When enabled, a file form field will appear on the create image form.
diff --git a/releasenotes/notes/bp-angular-template-overrides-9f05ffd61367245a.yaml b/releasenotes/notes/bp-angular-template-overrides-9f05ffd61367245a.yaml
new file mode 100644
index 000000000..71cab054d
--- /dev/null
+++ b/releasenotes/notes/bp-angular-template-overrides-9f05ffd61367245a.yaml
@@ -0,0 +1,11 @@
+---
+features:
+  - >
+    [`blueprint angular-template-overrides <https://blueprints.launchpad.net/horizon/+spec/angular-template-overrides>`_]
+    This blueprint provides a way for deployers to use a theme to override HTML
+    fragments used by Angular code in Horizon.  For example, to override the
+    launch instance help panel when the 'material' theme is used, create
+    openstack_dashboard/themes/material/static/templates/framework
+    /widgets/help-panel/help-panel.html. All of the client side templates are
+    now compiled into a single JavaScript file that is minified and is given
+    as an additional file in the manifest.json file.
\ No newline at end of file