From 05f3c12107086cadd5517448a7f19ed9dfa820e6 Mon Sep 17 00:00:00 2001 From: David Stanek Date: Wed, 2 Apr 2014 20:10:24 +0000 Subject: [PATCH] Removes unused db_sync methods In reviewing https://review.openstack.org/79211 we discovered that none of the db_sync methods are called anymore. Change-Id: Ie9714822efd06ba51654ac3aa3b93886cae24d6f --- keystone/assignment/backends/sql.py | 8 -------- keystone/catalog/backends/sql.py | 6 ------ keystone/credential/backends/sql.py | 7 ------- keystone/identity/backends/sql.py | 8 -------- keystone/policy/backends/sql.py | 7 ------- 5 files changed, 36 deletions(-) diff --git a/keystone/assignment/backends/sql.py b/keystone/assignment/backends/sql.py index 7da44777b..1523a65f5 100644 --- a/keystone/assignment/backends/sql.py +++ b/keystone/assignment/backends/sql.py @@ -18,10 +18,8 @@ import sqlalchemy from keystone import assignment from keystone import clean from keystone.common import sql -from keystone.common.sql import migration_helpers from keystone import config from keystone import exception -from keystone.openstack.common.db.sqlalchemy import migration from keystone.openstack.common.gettextutils import _ @@ -37,12 +35,6 @@ class AssignmentType: class Assignment(assignment.Driver): - # Internal interface to manage the database - def db_sync(self, version=None): - migration.db_sync( - sql.get_engine(), migration_helpers.find_migrate_repo(), - version=version) - def _get_project(self, session, project_id): project_ref = session.query(Project).get(project_id) if project_ref is None: diff --git a/keystone/catalog/backends/sql.py b/keystone/catalog/backends/sql.py index 61f112865..a5e10fb40 100644 --- a/keystone/catalog/backends/sql.py +++ b/keystone/catalog/backends/sql.py @@ -19,10 +19,8 @@ import sqlalchemy from keystone import catalog from keystone.catalog import core from keystone.common import sql -from keystone.common.sql import migration_helpers from keystone import config from keystone import exception -from keystone.openstack.common.db.sqlalchemy import migration CONF = config.CONF @@ -82,10 +80,6 @@ class Endpoint(sql.ModelBase, sql.DictBase): class Catalog(catalog.Driver): - def db_sync(self, version=None): - migration.db_sync( - sql.get_engine(), migration_helpers.find_migrate_repo(), - version=version) # Regions def list_regions(self): diff --git a/keystone/credential/backends/sql.py b/keystone/credential/backends/sql.py index 3bd93c1bd..d74e79a9c 100644 --- a/keystone/credential/backends/sql.py +++ b/keystone/credential/backends/sql.py @@ -13,10 +13,8 @@ # under the License. from keystone.common import sql -from keystone.common.sql import migration_helpers from keystone import credential from keystone import exception -from keystone.openstack.common.db.sqlalchemy import migration class CredentialModel(sql.ModelBase, sql.DictBase): @@ -32,11 +30,6 @@ class CredentialModel(sql.ModelBase, sql.DictBase): class Credential(credential.Driver): - # Internal interface to manage the database - def db_sync(self, version=None): - migration.db_sync( - sql.get_engine(), migration_helpers.find_migrate_repo(), - version=version) # credential crud diff --git a/keystone/identity/backends/sql.py b/keystone/identity/backends/sql.py index 221a38069..37f2df309 100644 --- a/keystone/identity/backends/sql.py +++ b/keystone/identity/backends/sql.py @@ -14,11 +14,9 @@ from keystone.common import dependency from keystone.common import sql -from keystone.common.sql import migration_helpers from keystone.common import utils from keystone import exception from keystone import identity -from keystone.openstack.common.db.sqlalchemy import migration from keystone.openstack.common.gettextutils import _ # Import assignment sql to ensure that the models defined in there are @@ -79,12 +77,6 @@ class Identity(identity.Driver): def default_assignment_driver(self): return "keystone.assignment.backends.sql.Assignment" - # Internal interface to manage the database - def db_sync(self, version=None): - migration.db_sync( - sql.get_engine(), migration_helpers.find_migrate_repo(), - version=version) - def _check_password(self, password, user_ref): """Check the specified password against the data store. diff --git a/keystone/policy/backends/sql.py b/keystone/policy/backends/sql.py index a95db2db7..b2cccd015 100644 --- a/keystone/policy/backends/sql.py +++ b/keystone/policy/backends/sql.py @@ -13,9 +13,7 @@ # under the License. from keystone.common import sql -from keystone.common.sql import migration_helpers from keystone import exception -from keystone.openstack.common.db.sqlalchemy import migration from keystone.policy.backends import rules @@ -29,11 +27,6 @@ class PolicyModel(sql.ModelBase, sql.DictBase): class Policy(rules.Policy): - # Internal interface to manage the database - def db_sync(self, version=None): - migration.db_sync( - sql.get_engine(), migration_helpers.find_migrate_repo(), - version=version) @sql.handle_conflicts(conflict_type='policy') def create_policy(self, policy_id, policy):