Bump hacking to 0.9.x series

Change-Id: I6c67a2c448f9d3d00867fe45233f7119fe627e93
Partial-Bug: #1328469

keystone/cli.py

@@ -219,9 +219,9 @@ class MappingPurge(BaseApp):
 
             if (CONF.command.all is True and
                 (CONF.command.domain_name is not None or
-                CONF.command.public_id is not None or
-                CONF.command.local_id is not None or
-                    CONF.command.type is not None)):
+                 CONF.command.public_id is not None or
+                 CONF.command.local_id is not None or
+                 CONF.command.type is not None)):
                 raise ValueError(_('--all option cannot be mixed with '
                                    'other options'))
 

keystone/common/environment/__init__.py

@@ -66,6 +66,7 @@ def use_eventlet(monkeypatch_thread=None):
     import eventlet
     from eventlet.green import httplib as _httplib
     from eventlet.green import subprocess as _subprocess
+
     from keystone.common.environment import eventlet_server
 
     if monkeypatch_thread is None:

keystone/common/ldap/core.py

@@ -13,17 +13,17 @@
 # under the License.
 
 import abc
-import os.path
-import re
-
 import codecs
 import functools
+import os.path
+import re
+import sys
+import weakref
+
 import ldap
 import ldap.filter
 import ldappool
 import six
-import sys
-import weakref
 
 from keystone import exception
 from keystone.i18n import _

keystone/common/validation/validators.py

@@ -52,10 +52,8 @@ class SchemaValidator(object):
                 # we don't expose sensitive user information in the event it
                 # fails validation.
                 detail = _("Invalid input for field '%(path)s'. The value is "
-                           "'%(value)s'.") % {
-                               'path': ex.path.pop(),
-                               'value': ex.instance
-                           }
+                           "'%(value)s'.") % {'path': ex.path.pop(),
+                                              'value': ex.instance}
             else:
                 detail = ex.message
             raise exception.SchemaValidationError(detail=detail)

keystone/contrib/ec2/controllers.py

@@ -36,9 +36,8 @@ import abc
 import sys
 import uuid
 
-import six
-
 from keystoneclient.contrib.ec2 import utils as ec2_utils
+import six
 
 from keystone.common import controller
 from keystone.common import dependency

keystone/contrib/oauth1/core.py

@@ -18,11 +18,11 @@ from __future__ import absolute_import
 
 import abc
 import string
+import uuid
 
 import oauthlib.common
 from oauthlib import oauth1
 import six
-import uuid
 
 from keystone.common import dependency
 from keystone.common import extension

keystone/models/token_model.py

@@ -105,7 +105,7 @@ class KeystoneToken(dict):
             elif 'user' in self:
                 return CONF.identity.default_domain_id
         except KeyError:
-        # Do not raise KeyError, raise UnexpectedError
+            # Do not raise KeyError, raise UnexpectedError
             pass
         raise exception.UnexpectedError()
 

keystone/service.py

@@ -12,9 +12,9 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
+import functools
 import sys
 
-import functools
 import routes
 
 from keystone import assignment

keystone/tests/core.py

@@ -16,6 +16,7 @@ from __future__ import absolute_import
 import atexit
 import copy
 import functools
+import logging
 import os
 import re
 import shutil
@@ -25,7 +26,6 @@ import time
 import warnings
 
 import fixtures
-import logging
 from oslo.config import fixture as config_fixture
 import oslotest.base as oslotest
 from oslotest import mockpatch
@@ -37,7 +37,7 @@ import webob
 # NOTE(ayoung)
 # environment.use_eventlet must run before any of the code that will
 # call the eventlet monkeypatching.
-from keystone.common import environment
+from keystone.common import environment  # noqa
 environment.use_eventlet()
 
 from keystone import auth
@@ -61,7 +61,6 @@ from keystone.openstack.common import policy as common_policy  # noqa
 
 config.configure()
 
-
 LOG = log.getLogger(__name__)
 PID = six.text_type(os.getpid())
 TESTSDIR = os.path.dirname(os.path.abspath(__file__))

keystone/tests/test_backend.py

@@ -15,10 +15,10 @@
 import copy
 import datetime
 import hashlib
-import mock
 import uuid
 
 from keystoneclient.common import cms
+import mock
 from oslo.utils import timeutils
 import six
 from testtools import matchers

keystone/tests/test_contrib_stats_core.py

@@ -12,9 +12,8 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
-from keystone.contrib import stats
-
 from keystone import config
+from keystone.contrib import stats
 from keystone import tests
 
 

keystone/tests/test_driver_hints.py

@@ -12,10 +12,8 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
-
-from keystone.tests import core as test
-
 from keystone.common import driver_hints
+from keystone.tests import core as test
 
 
 class ListHintsTests(test.TestCase):

keystone/tests/test_keystoneclient.py

@@ -15,10 +15,10 @@
 import datetime
 import os
 import uuid
-import webob
 
 import mock
 from oslo.utils import timeutils
+import webob
 
 from keystone import config
 from keystone.openstack.common import jsonutils

keystone/tests/test_keystoneclient_sql.py

@@ -291,13 +291,14 @@ class KcMasterSqlTestCase(test_keystoneclient.KcMasterTestCase):
                           id=uuid.uuid4().hex)
 
     def test_policy_crud(self):
+        from keystoneclient import exceptions as client_exceptions
+
         # FIXME(dolph): this test was written prior to the v3 implementation of
         #               the client and essentially refers to a non-existent
         #               policy manager in the v2 client. this test needs to be
         #               moved to a test suite running against the v3 api
         self.skipTest('Written prior to v3 client; needs refactor')
 
-        from keystoneclient import exceptions as client_exceptions
         client = self.get_client(admin=True)
 
         policy_blob = uuid.uuid4().hex

keystone/tests/test_ldap_livetest.py

@@ -12,11 +12,12 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
-import ldap
-import ldap.modlist
 import subprocess
 import uuid
 
+import ldap
+import ldap.modlist
+
 from keystone import config
 from keystone import exception
 from keystone.identity.backends import ldap as identity_ldap

keystone/tests/test_ldap_pool_livetest.py

@@ -12,9 +12,10 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
-import ldappool
 import uuid
 
+import ldappool
+
 from keystone.common.ldap import core as ldap_core
 from keystone import config
 from keystone.identity.backends import ldap

keystone/tests/test_no_admin_token_auth.py

@@ -13,6 +13,7 @@
 #    under the License.
 
 import os
+
 import webtest
 
 from keystone import tests

keystone/tests/test_pemutils.py

@@ -13,9 +13,11 @@
 #    under the License.
 
 import base64
+
+from six import moves
+
 from keystone.common import pemutils
 from keystone import tests
-from six import moves
 
 
 # List of 2-tuples, (pem_type, pem_header)

keystone/tests/test_v3_auth.py

@@ -15,11 +15,11 @@
 import copy
 import datetime
 import operator
-from testtools import testcase
 import uuid
 
 from keystoneclient.common import cms
 from oslo.utils import timeutils
+from testtools import testcase
 
 from keystone import auth
 from keystone.common import dependency

keystone/token/providers/common.py

@@ -22,13 +22,11 @@ from keystone.contrib import federation
 from keystone import exception
 from keystone.i18n import _
 from keystone.openstack.common import jsonutils
+from keystone.openstack.common import log
 from keystone import token
 from keystone.token import provider
 
 
-from keystone.openstack.common import log
-
-
 LOG = log.getLogger(__name__)
 CONF = config.CONF
 

test-requirements-py3.txt

@@ -1,4 +1,4 @@
-hacking>=0.8.0,<0.9
+hacking>=0.9.2,<0.10
 bashate >= 0.2
 
 # pysqlite does not install on py3

test-requirements.txt

@@ -1,4 +1,4 @@
-hacking>=0.8.0,<0.9
+hacking>=0.9.2,<0.10
 bashate >= 0.2
 
 # Optional backend: SQL

tox.ini

@@ -74,8 +74,11 @@ commands =
 filename= *.py,keystone-*
 show-source = true
 
+# H104  File contains nothing but comments
+# H405  multi line docstring summary not separated with an empty line
 # H803  Commit message should not end with a period (do not remove per list discussion)
-ignore = H803
+# H904  Wrap long lines in parentheses instead of a backslash
+ignore = H104,H405,H803,H904
 
 builtins = _
 exclude=.venv,.git,.tox,build,dist,doc,*openstack/common*,*lib/python*,*egg,tools,vendor,.update-venv,*.ini,*.po,*.pot