From fc3de2491d15f446d6223ff494bbeaef06fda8ac Mon Sep 17 00:00:00 2001 From: Monty Taylor Date: Tue, 31 Jan 2012 13:40:29 -0500 Subject: [PATCH] Use gerrit instead of github When we run gating tests in jenkins, any access of network resources is a potential source of false-negative on the test due to intermittent service failures on systems that are out of our control. We observe that this is actually quite frequent when things want to access PyPI or github. With pypi, we pre-create virtualenvs and cache the eggs so that an individual test run doesn't fail due to pypi not responding. For repos, if at all possible, we direct them all at the gerrit instance, because since gerrit is driving the test run in the first place, it's indicative of a much larger problem if jenkins can't talk to it - and it's one that we can fix if it does come up. Change-Id: I9f54133f7f2025d15a9d0b270d2466438cbc6dd5 --- tests/test_keystoneclient.py | 3 ++- tests/test_legacy_compat.py | 8 ++++---- tests/test_novaclient_compat.py | 3 ++- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/tests/test_keystoneclient.py b/tests/test_keystoneclient.py index 9766108ad..d7748649d 100644 --- a/tests/test_keystoneclient.py +++ b/tests/test_keystoneclient.py @@ -7,7 +7,8 @@ from keystone import test import default_fixtures CONF = config.CONF -KEYSTONECLIENT_REPO = 'git://github.com/openstack/python-keystoneclient.git' +OPENSTACK_REPO = 'https://review.openstack.org/p/openstack' +KEYSTONECLIENT_REPO = '%s/python-keystoneclient.git' % OPENSTACK_REPO class CompatTestCase(test.TestCase): diff --git a/tests/test_legacy_compat.py b/tests/test_legacy_compat.py index ff6b7fdbc..e9d9ebc0f 100644 --- a/tests/test_legacy_compat.py +++ b/tests/test_legacy_compat.py @@ -13,11 +13,11 @@ from keystone.common import utils CONF = config.CONF +OPENSTACK_REPO = 'https://review.openstack.org/p/openstack/' -IDENTITY_API_REPO = 'git://github.com/openstack/identity-api.git' -KEYSTONE_REPO = 'git://github.com/openstack/keystone.git' -NOVACLIENT_REPO = 'git://github.com/rackspace/python-novaclient.git' - +IDENTITY_API_REPO = '%s/identity-api.git' % OPENSTACK_REPO +KEYSTONE_REPO = '%s/keystone.git' % OPENSTACK_REPO +NOVACLIENT_REPO = '%s/python-novaclient.git' % OPENSTACK_REPO IDENTITY_SAMPLE_DIR = 'openstack-identity-api/src/docbkx/samples' KEYSTONE_SAMPLE_DIR = 'keystone/content/common/samples' diff --git a/tests/test_novaclient_compat.py b/tests/test_novaclient_compat.py index b4f6dc792..5578e4f78 100644 --- a/tests/test_novaclient_compat.py +++ b/tests/test_novaclient_compat.py @@ -12,7 +12,8 @@ import default_fixtures CONF = config.CONF -NOVACLIENT_REPO = 'git://github.com/openstack/python-novaclient.git' +OPENSTACK_REPO = 'https://review.openstack.org/p/openstack' +NOVACLIENT_REPO = '%s/python-novaclient.git' % OPENSTACK_REPO class CompatTestCase(test.TestCase):