openstack/deb-manila
Code Issues Proposed changes

Merge "Add missing filter function in HSP driver"

Browse Source
This commit is contained in:
Jenkins 2016-09-02 17:57:48 +00:00 committed by Gerrit Code Review
commit 108d3b177d
3 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manila/share/drivers/hitachi/hsp/driver.py
View File

@ -319,3 +319,6 @@ class HitachiHSPDriver(driver.ShareDriver):
"%(shr_id)s is no longer being managed."), "%(shr_id)s is no longer being managed."),
{'shr_path': share['export_locations'][0]['path'], {'shr_path': share['export_locations'][0]['path'],
'shr_id': share['id']}) 'shr_id': share['id']})
def get_default_filter_function(self):
return "share.size >= 128"

7
manila/tests/share/drivers/hitachi/hsp/test_driver.py
View File

@ -413,3 +413,10 @@ class HitachiHSPTestCase(test.TestCase):
rest.HSPRestBackend.get_cluster.assert_called_once_with() rest.HSPRestBackend.get_cluster.assert_called_once_with()
mock__update_share_stats.assert_called_once_with(fakes.stats_data) mock__update_share_stats.assert_called_once_with(fakes.stats_data)
self.assertTrue(self.mock_log.info.called) self.assertTrue(self.mock_log.info.called)
def test_get_default_filter_function(self):
expected = "share.size >= 128"
actual = self._driver.get_default_filter_function()
self.assertEqual(expected, actual)

3
releasenotes/notes/add-hsp-default-filter-function-0af60a819faabfec.yaml Normal file
View File

@ -0,0 +1,3 @@
---
fixes:
- Added missing default filter function on Hitachi HSP driver.