openstack/deb-manila
Code Issues Proposed changes

Merge "fix case sensitivity"

Browse Source
This commit is contained in:
Jenkins 2015-02-12 19:19:20 +00:00 committed by Gerrit Code Review
commit d1ce6c79e0
4 changed files with 65 additions and 65 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
manila/exception.py
View File

@ -170,24 +170,24 @@ class InUse(ManilaException):
class ShareNetworkNotFound(NotFound):
message = _("Share Network %(share_network_id)s could not be found.")
message = _("Share network %(share_network_id)s could not be found.")
class ShareServerNotFound(NotFound):
message = _("Share Server %(share_server_id)s could not be found.")
message = _("Share server %(share_server_id)s could not be found.")
class ShareServerNotFoundByFilters(ShareServerNotFound):
message = _("Share Server could not be found by "
message = _("Share server could not be found by "
"filters: %(filters_description)s.")
class ShareServerInUse(InUse):
message = _("Share Server %(share_server_id)s is in use.")
message = _("Share server %(share_server_id)s is in use.")
class ShareServerNotCreated(ManilaException):
message = _("Share Server %(share_server_id)s failed on creation.")
message = _("Share server %(share_server_id)s failed on creation.")
class ServiceNotFound(NotFound):
@ -199,11 +199,11 @@ class HostNotFound(NotFound):
class SchedulerHostFilterNotFound(NotFound):
message = _("Scheduler Host Filter %(filter_name)s could not be found.")
message = _("Scheduler host filter %(filter_name)s could not be found.")
class SchedulerHostWeigherNotFound(NotFound):
message = _("Scheduler Host Weigher %(weigher_name)s could not be found.")
message = _("Scheduler host weigher %(weigher_name)s could not be found.")
class HostBinaryNotFound(NotFound):
@ -303,7 +303,7 @@ class QuotaError(ManilaException):
class ShareSizeExceedsAvailableQuota(QuotaError):
message = _("Requested share or snapshot exceeds "
"allowed Gigabytes quota.")
"allowed gigabytes quota.")
class ShareLimitExceeded(QuotaError):
@ -412,17 +412,17 @@ class VolumeTypeNotFoundByName(VolumeTypeNotFound):
class VolumeTypeExtraSpecsNotFound(NotFound):
message = _("Volume Type %(volume_type_id)s has no extra specs with "
message = _("Volume type %(volume_type_id)s has no extra specs with "
"key %(extra_specs_key)s.")
class VolumeTypeInUse(ManilaException):
message = _("Volume Type %(volume_type_id)s deletion is not allowed with "
message = _("Volume type %(volume_type_id)s deletion is not allowed with "
"volumes present with the type.")
class VolumeTypeExists(ManilaException):
message = _("Volume Type %(id)s already exists.")
message = _("Volume type %(id)s already exists.")
class VolumeTypeCreateFailed(ManilaException):
@ -443,7 +443,7 @@ class ServiceInstanceException(ManilaException):
class ServiceInstanceUnavailable(ServiceInstanceException):
message = _("Service Instance is not available.")
message = _("Service instance is not available.")
class NetAppException(ManilaException):

6
manila/share/drivers/emc/plugins/vnx/connection.py
View File

@ -512,12 +512,12 @@ class VNXStorageConnection(driver.StorageConnection):
# Refresh DataMover/VDM by the configuration
moverRef = self.get_mover_ref_by_name(self._mover_name)
if not self._vdm_exist(vdm_name):
LOG.debug('Share Server %s not found. Creating', vdm_name)
LOG.debug('Share server %s not found, creating.', vdm_name)
self._create_vdm(vdm_name, moverRef)
status, vdmRef = self._XMLAPI_helper.get_vdm_by_name(vdm_name)
if constants.STATUS_OK != status:
message = (_('Could not get Share Server by name %(name)s. '
message = (_('Could not get share server by name %(name)s. '
'Reason: %(err)s.')
% {'name': vdm_name,
'err': vdmRef})
@ -901,7 +901,7 @@ class VNXStorageConnection(driver.StorageConnection):
if (service_number > 1 or
security_services[0]['type'] != 'active_directory'):
return False, _("Unsupported Security Services. "
return False, _("Unsupported security services. "
"Only support single security service and "
"only support type 'active_directory'")

2
manila/share/drivers/huawei/huawei_helper.py
View File

@ -387,7 +387,7 @@ class RestHelper():
fileparam['ALLOCTYPE'] = 0
else:
err_msg = (_(
'Config file is wrong. Filesystem Type must be "Thin"'
'Config file is wrong. Filesystem type must be "Thin"'
' or "Thick". AllocType:%(fetchtype)s') %
{'fetchtype': fstype})
LOG.error(err_msg)

98
manila/share/drivers/zfssa/zfssarest.py
View File

@ -96,9 +96,9 @@ class ZFSSAApi(object):
self.verify_project(pool, project)
avail = self.get_project_stats(pool, project)
if avail < size:
exception_msg = (_('Error Creating '
'Share: %(share)s on '
'Pool: %(pool)s. '
exception_msg = (_('Error creating '
'share: %(share)s on '
'pool: %(pool)s. '
'Not enough space.')
% {'share': share,
'pool': pool})
@ -112,18 +112,18 @@ class ZFSSAApi(object):
svc = self.pool_path % pool
ret = self.rclient.get(svc)
if ret.status != restclient.Status.OK:
exception_msg = (_('Error Getting Pool Stats: '
'Pool: %(pool)s '
'Return code: %(ret.status)d '
'Message: %(ret.data)s.')
exception_msg = (_('Error getting pool stats: '
'pool: %(pool)s '
'return code: %(ret.status)d '
'message: %(ret.data)s.')
% {'pool': pool,
'ret.status': ret.status,
'ret.data': ret.data})
raise exception.InvalidInput(reason=exception_msg)
val = jsonutils.loads(ret.data)
if not self._is_pool_owned(val):
exception_msg = (_('Error Pool ownership: '
'Pool %(pool)s is not owned '
exception_msg = (_('Error pool ownership: '
'pool %(pool)s is not owned '
'by %(host)s.')
% {'pool': pool,
'host': self.host})
@ -141,11 +141,11 @@ class ZFSSAApi(object):
svc = self.project_path % (pool, project)
ret = self.rclient.get(svc)
if ret.status != restclient.Status.OK:
exception_msg = (_('Error Getting Project Stats: '
'Pool: %(pool)s '
'Project: %(project)s '
'Return code: %(ret.status)d '
'Message: %(ret.data)s.')
exception_msg = (_('Error getting project stats: '
'pool: %(pool)s '
'project: %(project)s '
'return code: %(ret.status)d '
'message: %(ret.data)s.')
% {'pool': pool,
'project': project,
'ret.status': ret.status,
@ -164,11 +164,11 @@ class ZFSSAApi(object):
svc = self.projects_path % pool
ret = self.rclient.post(svc, arg)
if ret.status != restclient.Status.CREATED:
exception_msg = (_('Error Creating Project: '
exception_msg = (_('Error creating project: '
'%(project)s on '
'Pool: %(pool)s '
'Return code: %(ret.status)d '
'Message: %(ret.data)s .')
'pool: %(pool)s '
'return code: %(ret.status)d '
'message: %(ret.data)s.')
% {'project': project,
'pool': pool,
'ret.status': ret.status,
@ -195,10 +195,10 @@ class ZFSSAApi(object):
svc = self.shares_path % (pool, project)
ret = self.rclient.post(svc, share)
if ret.status != restclient.Status.CREATED:
exception_msg = (_('Error Creating '
'Share: %(name)s '
'Return code: %(ret.status)d '
'Message: %(ret.data)s.')
exception_msg = (_('Error creating '
'share: %(name)s '
'return code: %(ret.status)d '
'message: %(ret.data)s.')
% {'name': share['name'],
'ret.status': ret.status,
'ret.data': ret.data})
@ -234,12 +234,12 @@ class ZFSSAApi(object):
svc = self.share_path % (pool, project, share)
ret = self.rclient.delete(svc)
if ret.status != restclient.Status.NO_CONTENT:
exception_msg = (_LE('Error Deleting '
'Share: %(share)s to '
'Pool: %(pool)s '
'Project: %(project)s '
'Return code: %(ret.status)d '
'Message: %(ret.data)s.'),
exception_msg = (_LE('Error deleting '
'share: %(share)s to '
'pool: %(pool)s '
'project: %(project)s '
'return code: %(ret.status)d '
'message: %(ret.data)s.'),
{'share': share,
'pool': pool,
'project': project,
@ -253,13 +253,13 @@ class ZFSSAApi(object):
arg = {'name': snapshot}
ret = self.rclient.post(svc, arg)
if ret.status != restclient.Status.CREATED:
exception_msg = (_('Error Creating '
'Snapshot: %(snapshot)s on'
'Share: %(share)s to '
'Pool: %(pool)s '
'Project: %(project)s '
'Return code: %(ret.status)d '
'Message: %(ret.data)s.')
exception_msg = (_('Error creating '
'snapshot: %(snapshot)s on '
'share: %(share)s to '
'pool: %(pool)s '
'project: %(project)s '
'return code: %(ret.status)d '
'message: %(ret.data)s.')
% {'snapshot': snapshot,
'share': share,
'pool': pool,
@ -273,13 +273,13 @@ class ZFSSAApi(object):
svc = self.snapshot_path % (pool, project, share, snapshot)
ret = self.rclient.delete(svc)
if ret.status != restclient.Status.NO_CONTENT:
exception_msg = (_('Error Deleting '
'Snapshot: %(snapshot)s on '
'Share: %(share)s to '
'Pool: %(pool)s '
'Project: %(project)s '
'Return code: %(ret.status)d '
'Message: %(ret.data)s.')
exception_msg = (_('Error deleting '
'snapshot: %(snapshot)s on '
'share: %(share)s to '
'pool: %(pool)s '
'project: %(project)s '
'return code: %(ret.status)d '
'message: %(ret.data)s.')
% {'snapshot': snapshot,
'share': share,
'pool': pool,
@ -297,13 +297,13 @@ class ZFSSAApi(object):
snapshot['id'])
ret = self.rclient.put(svc, arg)
if ret.status != restclient.Status.CREATED:
exception_msg = (_('Error Cloning '
'Snapshot: %(snapshot)s on '
'Share: %(share)s of '
exception_msg = (_('Error cloning '
'snapshot: %(snapshot)s on '
'share: %(share)s of '
'Pool: %(pool)s '
'Project: %(project)s '
'Return code: %(ret.status)d '
'Message: %(ret.data)s.')
'project: %(project)s '
'return code: %(ret.status)d '
'message: %(ret.data)s.')
% {'snapshot': snapshot['id'],
'share': snapshot['share_id'],
'pool': pool,
@ -337,7 +337,7 @@ class ZFSSAApi(object):
if sharenfs == 'off':
sharenfs = 'sec=sys'
if ip in sharenfs:
LOG.debug('Access to Share %(share)s via NFS '
LOG.debug('Access to share %(share)s via NFS '
'already granted to %(ip)s.',
{'share': share,
'ip': ip})